emrg: document gen-assets.sh for local packaging (post-#688 host symmetry) - #690
Conversation
…etry) #688 made icon products (png/icns/ico) gitignored — CI generates them at build time, but local installer builds (make-installer.sh / build-runtime.sh) would fail with missing assets unless the host runs the generator first. - DEVELOPMENT.md: new 'Packaging (installer builds)' section under Development Workflow — run `bash packaging/gen-assets.sh` first (idempotent; renderer priority rsvg-convert → Chrome headless → sips; .icns needs macOS iconutil, skipped elsewhere) - Agent.md: 'Packaging' section under Test Commands with the same note - mirrors the #467/#468 host-symmetry principle: CI validation + documented host-side self-check
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1st)
Docs-only change (Agent.md + DEVELOPMENT.md): Packaging section documents running bash packaging/gen-assets.sh before local installer builds (icon products gitignored since #688). Verified: pytest 694 + doc-count guard 3 pass (no test counts touched), import + --help OK, CI Test green (31484828892). Addresses the #688 review's non-blocking note + #467/#468 host-symmetry principle.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Verified:
- Doc-only change (Agent.md + DEVELOPMENT.md) documenting that icon products are gitignored and local installer builds must run
bash packaging/gen-assets.shfirst — correct host-symmetry follow-up to #688 (#467/#468 principle: CI validation + documented host-side self-check) - Content matches actual gen-assets.sh behavior (renderer priority rsvg-convert → Chrome headless → sips; iconutil macOS-only, skipped elsewhere)
- CI test PASS (31484828892)
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3rd, different cycle)
Fresh re-verification of head c1f01b4 (unchanged since R828): docs-only (Agent.md + DEVELOPMENT.md Packaging sections); pytest 694 + doc-count guard pass; CI Test green (31484828892). Mergeable — proceeding to merge.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3rd)
Fresh re-verification on head c1f01b4 (unchanged):
- Doc-only change (Agent.md + DEVELOPMENT.md) — Packaging section documents running
bash packaging/gen-assets.shbefore local installer builds, since icon products are gitignored (#688); renderer priority and macOS-only iconutil accurately described - Correct host-symmetry follow-up (#467/#468: CI generates at build time, host self-check documented)
- Local: pytest 694 ✓ import ✓ --help ✓; CI Test PASS (31484828892)
Mergeable.
…n + stop-emrg fix + gen-assets doc) (#691) Co-authored-by: EMRG Evolution <emrg@argszero.dev>
1 participant
Documentation follow-up to #688 (icon finalization).
Why
#688 made generated icon products (icon.png/icon-512/icon-256/icon.icns/icon.ico) gitignored — the repo keeps only
packaging/assets/icon.svg(design source), and CI generates the products at build time. But local installer builds (make-installer.sh/build-runtime.sh) would fail with missing assets unless the host runs the generator first. No doc mentioned this (flagged as non-blocking in the #688 review).Changes
DEVELOPMENT.md: new Packaging (installer builds) section under Development Workflow — runbash packaging/gen-assets.shbefore local installer builds; documents idempotency, renderer priority (rsvg-convert → Chrome/Chromium headless → sips), and macOS-onlyiconutilfor .icnsAgent.md: Packaging section under Test Commands with the same noteMirrors the #467/#468 host-symmetry principle: CI validates the path, host has a documented self-check so it succeeds on the first attempt.
Verification
--helpOK (docs-only change)