emrg: evolution_prompt quick-ref for #688/#689/#690 (icon finalization + stop-emrg fix + gen-assets doc) - #691
Conversation
…n + stop-emrg fix + gen-assets doc)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1st)
Quick-ref entries for #688/#689/#690 added to evolution_prompt.md, plus the #683 entry's trailing note updated ("修正 PR 待合并" → "修正 #689 已合并 888efb0"). Verified against the merged commits:
- #688 entry accurately captures the icon SVG reconstruction (literal %s placeholder → rebuilt from design spec), gen-assets pipeline, and the two review fixes (cygpath file-URL, iconutil macOS guard)
- #689 entry records the full lesson chain: path-prefix blanket kill → ancestor-walk (rejected: dead parents) → snapshot-downward final design
- #690 entry documents the Packaging host-symmetry docs
Doc-only change; no test/doc-count impact. Local pytest 694 ✓ import ✓ --help ✓; CI Test PASS (31485794247).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1st)
Quick-ref entries for #688/#689/#690 verified against git history:
- #688 merge commit afbfaea ✓ (icon.svg reconstruction, gen-assets pipeline, cygpath + iconutil fixes)
- #689 merge commit 888efb0 ✓ (step-0 downward BFS snapshot — captures the R827 ❌ → e67e604 fix evolution accurately)
- #690 merge commit 6b8fff3 ✓ (gen-assets doc, host symmetry)
- #683 entry updated with
修正 #689 已合并 888efb0— consistent
Format matches the quick-ref convention (rant timestamps, design details, merge commits). CI Test green (31485794247). Mergeable.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3rd)
Re-verified on head 400ad7b (unchanged since 1st/2nd LGTMs):
- Quick-ref entries for #688 (icon SVG reconstruction + gen-assets pipeline), #689 (snapshot-downward EMRG-tree-only kill with the dead-parent review lesson), #690 (Packaging doc) — all consistent with merged commits afbfaea/888efb0/6b8fff3
- #683 entry note updated ("修正 PR 待合并" → "修正 #689 已合并 888efb0")
- Doc-only change; local pytest 694 ✓ import ✓ --help ✓; CI Test PASS (31485794247)
Mergeable.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3rd, different cycle)
Fresh re-verification of head 400ad7b (unchanged since R830): quick-ref entries for #688 (afbfaea) / #689 (888efb0) / #690 (6b8fff3) all fact-checked against git history; #683 entry updated with 修正 #689 已合并 888efb0; format matches convention. CI Test green (31485794247). Mergeable — proceeding to merge.
Adds implemented-features quick-reference entries to
emrg/server/evolution_prompt.mdfor the three PRs merged since the last quick-ref (#686):packaging/assets/icon.svgfrom the rant's design spec (the embedded SVG source was a literal%splaceholder), newgen-assets.shSVG→PNG pipeline + CI icon-asset step, 5 binary products gitignoredgen-assets.shfirst (icon products gitignored; emrg: p12 双证书对称校验 — Application + Installer 缺一不可(防止只导 Installer 导致 .app 未签名) #467/emrg: docs — README 补充 p12 双证书本地验证命令 + CI 早检行为说明(#467 对称) #468 host symmetry)Also updates the #683 entry's trailing note ("修正 PR 待合并" → "修正 #689 已合并 888efb0").
No test/doc-count changes (quick-ref entries are exempt from doc-count guard per established pattern). Local: pytest 694 ✓ import ✓ --help ✓.