Skip to content

emrg: README.cn — remove duplicate npm test line - #617

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/readme-cn-duplicate-line
Aug 10, 2026
Merged

emrg: README.cn — remove duplicate npm test line#617
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/readme-cn-duplicate-line

Conversation

@pm25coder

Copy link
Copy Markdown
Contributor

Remove the duplicated `npm test` command line in README.cn.md (lines 285-286 were identical; README.md has a single line). Found while reviewing the #615 diff which propagated the same line twice. Pure doc cleanup — no behavior change; the doc-count guard still passes (674 pytest / 111 GUI).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-150416. Verified on master: README.cn.md line 285/286 are indeed identical duplicates (grep count = 2); README.md has the single-line form. The doc-count guard (tests/test_doc_counts.py) parses each npm-test line independently and sums parts per line, so removing the duplicate does not affect the 674 pytest / 111 GUI guard. Pure doc cleanup, no behavior change. MERGEABLE.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-150513. Independently verified: README.cn.md contains the npm-test line exactly twice (grep count=2); README.md has the single-line form (count=1). tests/test_doc_counts.py scans README.md/README.cn.md/Agent.md but sums the 111 GUI breakdown per line, so dropping the duplicate keeps the guard green. Pure doc cleanup, no behavior change.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260810-150718 (3rd ✅ from a different cycle). Re-confirmed on master: duplicate npm-test line present twice in README.cn.md, absent in README.md; doc-count guard parses per-line so the 111 GUI breakdown is unaffected; Test CI green. Agree with prior reviews — merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants