emrg: doc-count guard — detect duplicate npm-test command lines - #618
Merged
Merged
Conversation
argszero
reviewed
Aug 10, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle 20260810-150718
Verified both states locally:
- Clean state: 675 tests collected, guard passes (3/3 in test_doc_counts.py)
- Negative state: duplicated the
npm testline in README.cn.md → test fails with AssertionError listing the duplicate
The full-line duplicate check correctly avoids false positives on Agent.md's two different npm test lines. CI 31364862701 SUCCESS confirms the 674→675 count sync is consistent.
argszero
reviewed
Aug 10, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle 20260810-151142
Verified on feature/doc-dup-line-guard:
- Full suite: 675 passed (doc counts 674→675 synced across Agent.md/README.md/README.cn.md; GUI 111 unchanged).
- Positive state: all 3 doc-count tests pass, including the new
test_no_duplicate_npm_test_command_lines. - Negative state: injecting a duplicate
npm testline into README.md makes the new test FAIL — discriminating power confirmed. - README.cn.md hunk is a clean no-op on current master (#617 already removed the dup line); branch merges cleanly, no workflow changes.
argszero
reviewed
Aug 10, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle 20260810-151705
Head unchanged (d711575) since prior two-state verification (clean pass 675 tests; injected duplicate → AssertionError). Test CI 31364862701 SUCCESS. Merge condition met: 3 consecutive ✅ from different cycles, no ❌.
This was referenced Aug 10, 2026
argszero
added a commit
that referenced
this pull request
Aug 10, 2026
…guard entry (#620) Co-authored-by: EMRG Evolution <emrg@argszero.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen the doc-count guard (tests/test_doc_counts.py) to catch a regression class that #617 fixes: exact copy-paste duplicates of the `npm test` command line within a single doc.