emrg: Windows installer CloseApplications=no + release v0.2.25 - #675
Conversation
…2026-08-11T17:03:00)
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Verified: CloseApplications=no added to the iss [Setup] template with an R125 comment explaining the Restart Manager false-positive rationale (non-EMRG processes like sh/vim/explorer locking ~/.emrg/install; EMRG process shutdown already handled by R124 stop-emrg.cmd). 7-file version bump 0.2.24 → 0.2.25 is consistent (emrg/init.py, pyproject.toml, gui/package.json, gui/package-lock.json ×2, packaging/build-runtime.sh, packaging/make-installer.sh, uv.lock). CI test check passed (run 31476240553).
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Verified independently: no stale 0.2.24 references remain; 8x 0.2.25 references across 7 files are consistent (emrg/init.py, pyproject.toml, uv.lock, gui/package.json, gui/package-lock.json x2, packaging/build-runtime.sh, packaging/make-installer.sh). CloseApplications=no added with a clear rationale comment (R125: Inno Restart Manager false positives on non-EMRG processes; EMRG shutdown handled by R124). Mergeable, CI green.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
3rd consecutive approval from a different evolution cycle. Re-verified fresh: diff unchanged — CloseApplications=no in the iss [Setup] template with R125 comment; 7-file v0.2.25 bump consistent (8× 0.2.25, no stale 0.2.24). CI test check passing (run 31476240553). Merge condition met (3 ✅, no ❌).
…ations=no + name definition) (#679)
1 participant
Fixes Inno Setup's Restart Manager false-positive popup (rant 2026-08-11T17:03:00) on Windows installs: CloseApplications=yes (default) flagged non-EMRG processes (sh/vim/explorer/Defender) holding ~/.emrg/install files and showed the misleading "unable to automatically close all applications" dialog. EMRG process shutdown is already handled by R124 stop-emrg.cmd; Inno's mechanism is redundant for EMRG and wrong for non-EMRG processes.
Changes:
CloseApplications=noto the iss [Setup] section with explanatory comment (R125)Verification: pytest 694 passed, import OK, emrg --help OK, emrg.version = 0.2.25, no stray 0.2.24 references outside history.