You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Electron suite: 4 pre-existing red tests on main (env + fixture drift) #535
Found during the perf pass (thread 693440a8) — all reproduce with the perf diff stashed and are independent of any branch:
store.test.js "round-trips projects, threads, messages, work log" — migrateThread injects reviewAcceptedHunks: [] (store.js:798) but the test fixture never expects it. Same failure class as the earlier quota-wait-keys red: migrateThread defaults keep landing without the round-trip fixture being updated. Fails on origin/main (test file byte-identical).
web.test.js "package-app.sh copies electron/*.js and node_modules/ws" — test regex expects a literal node_modules/ws in package-app.sh; the script now copies via ROOT_NM_PKGS=(ws cross-spawn ...). Test/script drift on main.
checkpoints.test.js "runner auto-checkpoint on successful turn" — throws worktreeBase is not configured from materializePendingWorktree (runner.js:4260). Environment/settings dependent.
verify-gate.test.js — 4 subtests red at baseline.
Note: 10 other electron failures seen during the pass were environment rot and are now fixed: the tracked core/dist symlink breakage (main deleted it upstream; rebuilt locally) and missing memory-server node_modules (docs/ISSUES.md already documents the SDK-missing half).
Stale — re-measured on main (5b1c6da) today, full suites:
npm run test:renderer 1338 pass / 0 fail (368 suites)
npm run test:electron 1681 pass / 1 fail (352 suites)
The four named here are green now, as are the seven from #536 (already closed). The single remaining failure is web-integration's reconnect test, and it is not a baseline — it is a race in the test's injected clock, root-caused and fixed in #620 (1 fail/5 runs before, 0 fail/8 runs after).
Suggest closing this in favour of #620, which is the only red left.
Duplicate of #536, which lists the same four red files (verify-gate, checkpoints, web, store) plus three more, and was closed COMPLETED on 2026-08-20 with a per-file fix:
Fixed on coder/fork-electron-suite-7-pre-existing-failu-b31efc. These were fixture/assertion drift, not product bugs. verify-gate (4) + checkpoints (1):createRunner omitted userDataPath ... web.test.js (2):contextMenu:show is registered outside IPC_HANDLERS on purpose ...
No surviving work here. Closing as a duplicate of the already-fixed #536.
Activity
currentbits commentedon Aug 20, 2026
Stale — re-measured on
main(5b1c6da) today, full suites:The four named here are green now, as are the seven from #536 (already closed). The single remaining failure is web-integration's reconnect test, and it is not a baseline — it is a race in the test's injected clock, root-caused and fixed in #620 (1 fail/5 runs before, 0 fail/8 runs after).
Suggest closing this in favour of #620, which is the only red left.
currentbits commentedon Aug 20, 2026
Duplicate of #536, which lists the same four red files (verify-gate, checkpoints, web, store) plus three more, and was closed COMPLETED on 2026-08-20 with a per-file fix:
No surviving work here. Closing as a duplicate of the already-fixed #536.