Skip to content

refactor: Call the text path Dialogue - #1988

Merged
omesser merged 4 commits into
mainfrom
refactor/1955-dialogue-names
Oct 31, 2026
Merged

omesser merged 4 commits into
mainfrom
refactor/1955-dialogue-names

Conversation

@omesser

@omesser omesser commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Why

A Character's words are Dialogue. ADR-0040 reserves Speech for a future audio engine. PR #1953 renamed the docs. Code still called the text path speech: the reply parser, the streaming settle action, the action-log result, and the landing page's current line.

What changed

Those identifiers and the comments that name the text path now say Dialogue. Chat settle reports action: "dialogue". The action log's prose result is dialogue. The landing page stores the current line as dialogue.

The dated site pages are revised in place, which ADR-0011 allows. website/chat.html and website/chat-mockups.html no longer mock a speak tool call: the reply streams into the chat and grows in the Speech bubble, and the controls are s-dialogue, dialogueTurn, and showDialogue. website/design.html and website/bubble.html say Dialogue for the text path and keep Speech for the bubble. website/expression.html names the demo control Say (say-line / sayLine).

Left in place, because they are the Speech bubble or real audio:

  • SpeechBubble, showSpeech / hideSpeech, data-mode="speech", and mod speech (the bubble clock)
  • Apple SpeechAnalyzer
  • Anchored docs/research/
  • near_reaction = "speak", a cursor reaction, not the text path

How to verify

  • cargo test --workspace passed (core 688, app 981, plus the smaller crates).
  • node --test on the chat-settle, bubble, quick-message, overlay-rect, and landing-walker files passed.
  • cargo fmt --all -- --check and cargo clippy --workspace --all-targets -- -D warnings passed through pre-commit.

Notes

Lines already in action-log.jsonl keep result speech until that file rotates. New lines say dialogue. Nothing in the repo branches on that word.

Closes #1955
Closes #1935

— Grok Build, on @omesser's behalf.

@omesser omesser added refactoring harness website GitHub Pages site: landing page, character gallery, design pages, etc, and their automation labels Oct 30, 2026
omesser

This comment was marked as outdated.

@omesser

omesser commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

The non-blocking note is in the Notes now.

website/chat.html, website/chat-mockups.html, and the website/design.html index line for the chat proposal still say Speech, and the first two still mock speak. ADR-0011 freezes those dated pages so they do not claim to be the current product, so this PR does not rewrite them. bubble.html and expression.html stay as Speech-bubble prose.

— Grok Build, on @omesser's behalf.

The chat demos now show a line arriving as the reply text plus
play_behavior, per ADR-0040: no speak tool call, and the reply streams
into the chat and the Speech bubble at once. Prose naming the text path
says Dialogue; the Speech bubble keeps its glossary name and the
data-mode="speech" hooks stay as the app has them.
omesser

This comment was marked as outdated.

The button and its handler no longer use the removed speak tool's name.
omesser

This comment was marked as outdated.

@omesser

omesser commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

The Notes now match the branch. chat.html, chat-mockups.html, and design.html were revised in place, which ADR-0011 allows, and expression.html names the demo control Say.

Older Action Log lines still say speech until that file rotates. The log is a record, and nothing in the repo reads the word. near_reaction = "speak" stays a cursor reaction.

— Grok Build, on @omesser's behalf.

omesser

This comment was marked as outdated.

@omesser

omesser commented Oct 31, 2026

Copy link
Copy Markdown
Owner Author

The Action Log note is already in the Notes, and it stays that way. New parsed lines say dialogue. Lines already in action-log.jsonl keep speech until that file rotates, because the log is a record. Nothing in the repo reads the word.

— Grok Build, on @omesser's behalf.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: bc037209

What changed

  • Callback name: The stream helper in chat.html and chat-mockups.html names its callback onDialogue instead of onText, so codespell accepts it and the name matches the Dialogue text path the callback receives.

What is wrong

  • Nothing blocking: The rename is local to each stream function, every use is updated, and no onText is left. Nothing a Harness or the Model API reads changes.

Soft-FIX

  • None

Verified: codespell is clean on both pages, the push only touches those four lines since 1405a2c7, and main merges cleanly.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 07b406d into main Oct 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harness refactoring website GitHub Pages site: landing page, character gallery, design pages, etc, and their automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the speech identifiers for the text path to dialogue A Character says things only through its reply, with no MCP speak tool

1 participant