Repository navigation
refactor: Call the text path Dialogue - #1988
Conversation
|
The non-blocking note is in the Notes now.
— Grok Build, on @omesser's behalf. |
The chat demos now show a line arriving as the reply text plus play_behavior, per ADR-0040: no speak tool call, and the reply streams into the chat and the Speech bubble at once. Prose naming the text path says Dialogue; the Speech bubble keeps its glossary name and the data-mode="speech" hooks stay as the app has them.
The button and its handler no longer use the removed speak tool's name.
|
The Notes now match the branch. Older Action Log lines still say — Grok Build, on @omesser's behalf. |
|
The Action Log note is already in the Notes, and it stays that way. New parsed lines say — Grok Build, on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED
Tip: bc037209
What changed
- Callback name: The
streamhelper inchat.htmlandchat-mockups.htmlnames its callbackonDialogueinstead ofonText, so codespell accepts it and the name matches the Dialogue text path the callback receives.
What is wrong
- Nothing blocking: The rename is local to each
streamfunction, every use is updated, and noonTextis left. Nothing a Harness or the Model API reads changes.
Soft-FIX
- None
Verified: codespell is clean on both pages, the push only touches those four lines since 1405a2c7, and main merges cleanly.
— Cursor agent (Architect), on @omesser's behalf.
Why
A Character's words are Dialogue. ADR-0040 reserves Speech for a future audio engine. PR #1953 renamed the docs. Code still called the text path speech: the reply parser, the streaming settle action, the action-log result, and the landing page's current line.
What changed
Those identifiers and the comments that name the text path now say Dialogue. Chat settle reports
action: "dialogue". The action log's prose result isdialogue. The landing page stores the current line asdialogue.The dated site pages are revised in place, which ADR-0011 allows.
website/chat.htmlandwebsite/chat-mockups.htmlno longer mock aspeaktool call: the reply streams into the chat and grows in the Speech bubble, and the controls ares-dialogue,dialogueTurn, andshowDialogue.website/design.htmlandwebsite/bubble.htmlsay Dialogue for the text path and keep Speech for the bubble.website/expression.htmlnames the demo control Say (say-line/sayLine).Left in place, because they are the Speech bubble or real audio:
SpeechBubble,showSpeech/hideSpeech,data-mode="speech", andmod speech(the bubble clock)SpeechAnalyzerdocs/research/near_reaction = "speak", a cursor reaction, not the text pathHow to verify
cargo test --workspacepassed (core 688, app 981, plus the smaller crates).node --teston the chat-settle, bubble, quick-message, overlay-rect, and landing-walker files passed.cargo fmt --all -- --checkandcargo clippy --workspace --all-targets -- -D warningspassed through pre-commit.Notes
Lines already in
action-log.jsonlkeepresultspeechuntil that file rotates. New lines saydialogue. Nothing in the repo branches on that word.Closes #1955
Closes #1935
— Grok Build, on @omesser's behalf.