Skip to content

feat(mcp): Say things only through the reply - #1953

Merged
omesser merged 3 commits into
mainfrom
feat/1935-reply-only
Oct 30, 2026
Merged

omesser merged 3 commits into
mainfrom
feat/1935-reply-only

Conversation

@omesser

@omesser omesser commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Summary

A Character says things through one channel: its reply. The MCP speak tool is deleted outright, with no deprecation shim, since there is no backcompat before v1. ADR-0040 records the decision.

 tools/list
-  speak            # wrote Dialogue straight into an Instance, from any session
   play_behavior
   list_windows · describe_screen · recall · remember
   list_instances · whereabouts · caffeinate

The instance_id schema text and the ambiguous-target docs now name only play_behavior. The README tool table also gains the missing caffeinate row, so "Eight tools" matches list_tools().

Naming: the text path is Dialogue in the docs. The engine already carries it as Frame::dialogue and BehaviorProposal::dialogue, and "Line" is already a wake class in ADR-0016. "Speech" is kept for a future audio engine.

Was Now Where
Speech (glossary term) Dialogue GLOSSARY.md, docs/harness.md, docs/DEVELOPMENT.md, ADR-0016
speak (glossary term) removed GLOSSARY.md
"speech and motion" "words and motion" README.md
"agent speech" / "/loop-driven speech" "agent text" / "/loop-driven text" docs/harness.md

ADRs: ADR-0040 is new. ADR-0003, 0016, 0023, 0026 and 0036 get wording edits only (their tool lists and the term), because none of their decisions changed. ADR-0015 and ADR-0018 use "speak" only as a verb ("Cargo speaks it", "speaking JSON-RPC"), so they are unchanged.

Left alone on purpose:

  • The dated proposals website/chat.html and website/chat-mockups.html still mock a speak call. ADR-0011 freezes dated pages. "Speech bubble" stays the glossary term, per Oded.
  • docs/research/ is anchored and is not updated to follow main.
  • near_reaction = "speak" is a cursor reaction that plays talk. It is not the tool.

Evidence

Test first: list_tools_includes_all_handler_tools now expects 8 tools and no speak, and the tools/list test in mcp_http.rs expects 8. The previous agent changed code and tests together, so I did not watch them fail. On origin/main list_tools() returns 9 names including speak, so assert_eq!(names.len(), 8) and !names.contains(&"speak") both fail there.

  • cargo fmt --all, cargo clippy --workspace --all-targets -- -D warnings: clean.
  • cargo test --workspace: all pass (core 675, app 973).
  • node --test tests/*.test.js: 801 pass, 50 fail. The failures are local environment only: no headless Chromium, no X/Wayland, and a system Python that rejects the site generator's f-strings. No settings or snapshot test fails.

Merge Danger

Door: two-way

Bringing speak back means reverting this PR, plus the rules between two channels that #1701 listed.

Blast Radius: Harnesses

A Harness prompt or user config that calls speak now gets an unknown-tool error. Fidget's prompt names no tools (#917), so only hand-written prompts are affected.

Follow-up

The issue says the text path is not called "speech" anywhere. Docs, ADRs and GLOSSARY.md are done here. The code rename is #1955, which waits on #1923 because it touches engine.rs.

Refs #1935. #1935 stays open until #1955 renames the code.

🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.

omesser and others added 2 commits October 30, 2026 00:43
Two channels for Dialogue needed ordering, gating and dedupe rules
(#1701, #1910). With the speak tool gone, the reply is the only one.
Docs call the text path Dialogue; Speech is kept for audio.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
near_reaction = "speak" is a live manifest value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser

This comment was marked as outdated.

Oded keeps "Speech bubble" as the glossary term; only the text path is Dialogue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft CLEARED

Tip: 97c92aa2

What changed

  • Rename tracked: the body now says "Refs #1935", and #1955 holds the code rename of speech to dialogue, waiting on #1923. #1935 stays open until it lands, which closes the earlier Soft-FIX.
  • Speech bubble kept: GLOSSARY.md, DESIGN.md, SPEC, ADR-0036 and two verify-fidget feature pages go back to "Speech bubble" for the bubble, and it leaves Dialogue's avoid list.

What is wrong
Nothing blocking.

Soft-FIX
None.

Verified: since ddffdffa only Markdown changed, so the earlier core test and clippy results still hold, and no doc outside dated pages and docs/research/ still names a bare "Bubble" term the PR added.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 4ad3516 into main Oct 30, 2026
10 checks passed
@omesser
omesser deleted the feat/1935-reply-only branch October 31, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant