Repository navigation
feat(mcp): Say things only through the reply - #1953
Merged
Merged
Conversation
near_reaction = "speak" is a live manifest value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Oded keeps "Speech bubble" as the glossary term; only the text path is Dialogue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
commented
Oct 30, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 97c92aa2
What changed
- Rename tracked: the body now says "Refs #1935", and #1955 holds the code rename of
speechtodialogue, waiting on #1923. #1935 stays open until it lands, which closes the earlier Soft-FIX. - Speech bubble kept: GLOSSARY.md, DESIGN.md, SPEC, ADR-0036 and two verify-fidget feature pages go back to "Speech bubble" for the bubble, and it leaves Dialogue's avoid list.
What is wrong
Nothing blocking.
Soft-FIX
None.
Verified: since ddffdffa only Markdown changed, so the earlier core test and clippy results still hold, and no doc outside dated pages and docs/research/ still names a bare "Bubble" term the PR added.
— Cursor agent (Architect), on @omesser's behalf.
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Character says things through one channel: its reply. The MCP
speaktool is deleted outright, with no deprecation shim, since there is no backcompat before v1. ADR-0040 records the decision.tools/list - speak # wrote Dialogue straight into an Instance, from any session play_behavior list_windows · describe_screen · recall · remember list_instances · whereabouts · caffeinateThe
instance_idschema text and the ambiguous-target docs now name onlyplay_behavior. The README tool table also gains the missingcaffeinaterow, so "Eight tools" matcheslist_tools().Naming: the text path is Dialogue in the docs. The engine already carries it as
Frame::dialogueandBehaviorProposal::dialogue, and "Line" is already a wake class in ADR-0016. "Speech" is kept for a future audio engine.speak(glossary term)/loop-driven speech"/loop-driven text"ADRs: ADR-0040 is new. ADR-0003, 0016, 0023, 0026 and 0036 get wording edits only (their tool lists and the term), because none of their decisions changed. ADR-0015 and ADR-0018 use "speak" only as a verb ("Cargo speaks it", "speaking JSON-RPC"), so they are unchanged.
Left alone on purpose:
website/chat.htmlandwebsite/chat-mockups.htmlstill mock aspeakcall. ADR-0011 freezes dated pages. "Speech bubble" stays the glossary term, per Oded.docs/research/is anchored and is not updated to followmain.near_reaction = "speak"is a cursor reaction that playstalk. It is not the tool.Evidence
Test first:
list_tools_includes_all_handler_toolsnow expects 8 tools and nospeak, and thetools/listtest inmcp_http.rsexpects 8. The previous agent changed code and tests together, so I did not watch them fail. On origin/mainlist_tools()returns 9 names includingspeak, soassert_eq!(names.len(), 8)and!names.contains(&"speak")both fail there.cargo fmt --all,cargo clippy --workspace --all-targets -- -D warnings: clean.cargo test --workspace: all pass (core 675, app 973).node --test tests/*.test.js: 801 pass, 50 fail. The failures are local environment only: no headless Chromium, no X/Wayland, and a system Python that rejects the site generator's f-strings. No settings or snapshot test fails.Merge Danger
Door: two-way
Bringing
speakback means reverting this PR, plus the rules between two channels that #1701 listed.Blast Radius: Harnesses
A Harness prompt or user config that calls
speaknow gets an unknown-tool error. Fidget's prompt names no tools (#917), so only hand-written prompts are affected.Follow-up
The issue says the text path is not called "speech" anywhere. Docs, ADRs and GLOSSARY.md are done here. The code rename is #1955, which waits on #1923 because it touches
engine.rs.Refs #1935. #1935 stays open until #1955 renames the code.
🤖 Generated with Claude Code
— Claude Code agent, on @omesser's behalf.