Skip to content

Tables and sidebar: multi-row select, row and multi-cell menus, draggable views, nav icons - #1969

Closed
joepio wants to merge 7 commits into
developfrom
claude/improve-tables-5jwegn
Closed

joepio wants to merge 7 commits into
developfrom
claude/improve-tables-5jwegn

Conversation

@joepio

@joepio joepio commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Requested by Joep · project thread

Before: Rows could only be deleted one at a time. Right-clicking a row's number did nothing, a selection of several cells had no menu, and the order of a table's views was fixed. Notifications and sync were only in the sidebar account menu (with dividers) and the cog was brighter than the menu items. Names in the Share dialog were not links, long subject URLs filled error toasts, and deleting a row typed this session showed its neighbour twice until reload.

After:

  • Select rows. A checkbox sits left of each row number (on hover, always on touch). Ticking one row starts select mode: every row shows its checkbox and the toolbar next to the filter button shows "N selected", delete and clear. One undo restores all deleted rows.
  • Row menu. Right-clicking a row's number opens the same resource menu as right-clicking one of its cells.
  • Multi-cell menu. Right-clicking inside a shift+click or drag selection opens a menu that clears the values, sets one value in all of them (parsed per column type, like pasting), or deletes the rows the selection touches (with confirmation, one undo step).
  • Views. View tabs can be dragged to change their order.
  • Sidebar. Notifications (with an unread dot) and sync get their own icon buttons next to Settings, still in the account menu, all in the muted color of the menu items. The dividers in the menu are gone.
  • Share. Names under "People with access" open that person's profile and close the dialog.
  • Error toasts. Long subject URLs (atomic:, did:ad:, https://) are shortened in the message; Copy still copies the full text.
  • Deleted typed rows. Deleting a row created this session no longer leaves a phantom member that duplicated a neighbour.

How

  • Tick boxes are role=checkbox buttons rather than inputs, because the grid's keyboard code and e2e helpers take the first input in the grid to be the cell editor. They enter the row header through a new RowHeaderExtra prop on FancyTable. Selection is kept per row subject and dropped when the view, filter or sorting changes.
  • A right-click inside a multi-cell selection no longer collapses it on mouse down. The menu snapshots the selected cells when it opens, since clicking into the dialog it opens collapses the live selection.
  • The index column is 8ch instead of 6ch to fit the checkbox.
  • View order is saved by writing the table's tableViews array.
  • The stale-row fix: a deleted session row left newRowSubjects before the collection dropped it, which the member baseline read as a foreign row and raised for good. deletedSessionRowsRef counts those rows until the collection catches up.

Screenshots are in the project thread, not committed. Added e2e tests in tables.spec.ts (not @smoke) and a unit test for the URL shortener. I could not run the e2e tests through the repo's Playwright runner here; I ran the same steps with standalone Playwright scripts against a local server and they passed. Lint (pnpm run -r lint), tsc and the data-browser chunk unit tests pass.

Not done: the Escape-in-cell report did not reproduce, and rows coming back in a different order after reload did not reproduce (three fast 10-row runs came back in order).

🤖 Generated with Claude Code

https://claude.ai/code/session_01MShPQ1DGfFRgmoMz6MVJHo

A checkbox sits left of each row number (on hover, always on touch). Once a row is ticked every row shows one and the toolbar next to the filter button shows the count with a delete button. Undo restores the whole batch.
@joepio joepio self-assigned this Oct 1, 2026
Right-click a row's number for its resource menu. Right-clicking inside a shift+click or drag selection opens a menu that clears the values, sets one value in all of them, or deletes the rows they touch (one undo step). View tabs can be dragged to reorder them.
@joepio joepio changed the title Tables: tick rows and delete them in one go Tables: multi-row select, row and multi-cell context menus, draggable views Oct 1, 2026
…r error toasts, fix stale rows after deleting a typed row
@joepio joepio changed the title Tables: multi-row select, row and multi-cell context menus, draggable views Tables and top bar: multi-row select, row and multi-cell menus, draggable views, nav icons Oct 1, 2026
…ders in the account menu; undo the top bar change
@joepio joepio changed the title Tables and top bar: multi-row select, row and multi-cell menus, draggable views, nav icons Tables and sidebar: multi-row select, row and multi-cell menus, draggable views, nav icons Oct 1, 2026
joepio added a commit that referenced this pull request Oct 6, 2026
One tested commit for the open PRs of 5 October: link device to account (#1948), one profile form (#1953), faster branch runs (#1956), end-to-end encrypted conversations (#1971), passkey ceremony header (#1972), Flutter account package (#2035), cheap canvas undo (#2053), atomic.place tab title (#2056), table resource cell (#2057), small table fixes (#2058), storage map (#2061), Sync page cloud ladder (#2072), several served-domain suffixes (#2073), one sign-in (#2074), smaller chat messages (#2077), bring-along e2e fix (#2078), inline row data loss (#2079), Retry-After (#2080), #2070, #2071, #2066, #2067, #2068, #1969, #1887, #1897 and #1920.

Compressed stored values from #2077 stay readable, but a downgrade cannot read compressed rows.

Co-authored-by: Joep Meindertsma <joep@ontola.io>
@joepio joepio closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant