Skip to content

Let --served-domain-suffix take several domains - #2073

Closed
joepio wants to merge 1 commit into
developfrom
node-domain-suffixes
Closed

joepio wants to merge 1 commit into
developfrom
node-domain-suffixes

Conversation

@joepio

@joepio joepio commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Before: --served-domain-suffix accepted one domain. A node that has to answer under atomicserver.eu and under atomic.place at the same time (while it moves from one to the other) could name only one, so requests on the other were treated as foreign: subjects were localized to the configured origin and credentialed CORS was refused.

After: The flag and ATOMIC_SERVED_DOMAIN_SUFFIX take a comma-separated list (atomicserver.eu,atomic.place). A single value behaves exactly as before, and lookalikes such as notatomic.place or atomic.place.evil.example are still rejected.

How: host_is_served_here in server/src/context.rs splits the value on commas; the CORS credentials gate goes through the same function, so it follows. Unit test several_served_domain_suffixes_are_all_served added; the five existing context tests still pass.

Pairs with atomic-saas #187 (public node hostnames under atomic.place). Nothing changes for a node that keeps a single suffix.

Requested by Joep

A node moving from one domain to another has to answer under both while links
to the old one are still around. The flag took a single suffix.
joepio added a commit that referenced this pull request Oct 6, 2026
One tested commit for the open PRs of 5 October: link device to account (#1948), one profile form (#1953), faster branch runs (#1956), end-to-end encrypted conversations (#1971), passkey ceremony header (#1972), Flutter account package (#2035), cheap canvas undo (#2053), atomic.place tab title (#2056), table resource cell (#2057), small table fixes (#2058), storage map (#2061), Sync page cloud ladder (#2072), several served-domain suffixes (#2073), one sign-in (#2074), smaller chat messages (#2077), bring-along e2e fix (#2078), inline row data loss (#2079), Retry-After (#2080), #2070, #2071, #2066, #2067, #2068, #1969, #1887, #1897 and #1920.

Compressed stored values from #2077 stay readable, but a downgrade cannot read compressed rows.

Co-authored-by: Joep Meindertsma <joep@ontola.io>
@joepio joepio closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant