Repository navigation
Conversation
A node moving from one domain to another has to answer under both while links to the old one are still around. The flag took a single suffix.
This was referenced Oct 5, 2026
joepio
added a commit
that referenced
this pull request
Oct 6, 2026
One tested commit for the open PRs of 5 October: link device to account (#1948), one profile form (#1953), faster branch runs (#1956), end-to-end encrypted conversations (#1971), passkey ceremony header (#1972), Flutter account package (#2035), cheap canvas undo (#2053), atomic.place tab title (#2056), table resource cell (#2057), small table fixes (#2058), storage map (#2061), Sync page cloud ladder (#2072), several served-domain suffixes (#2073), one sign-in (#2074), smaller chat messages (#2077), bring-along e2e fix (#2078), inline row data loss (#2079), Retry-After (#2080), #2070, #2071, #2066, #2067, #2068, #1969, #1887, #1897 and #1920. Compressed stored values from #2077 stay readable, but a downgrade cannot read compressed rows. Co-authored-by: Joep Meindertsma <joep@ontola.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
--served-domain-suffixaccepted one domain. A node that has to answer underatomicserver.euand underatomic.placeat the same time (while it moves from one to the other) could name only one, so requests on the other were treated as foreign: subjects were localized to the configured origin and credentialed CORS was refused.After: The flag and
ATOMIC_SERVED_DOMAIN_SUFFIXtake a comma-separated list (atomicserver.eu,atomic.place). A single value behaves exactly as before, and lookalikes such asnotatomic.placeoratomic.place.evil.exampleare still rejected.How:
host_is_served_hereinserver/src/context.rssplits the value on commas; the CORS credentials gate goes through the same function, so it follows. Unit testseveral_served_domain_suffixes_are_all_servedadded; the five existing context tests still pass.Pairs with atomic-saas #187 (public node hostnames under atomic.place). Nothing changes for a node that keeps a single suffix.
Requested by Joep