Skip to content

Fix the bring-along e2e red since the template account gate - #2078

Closed
joepio wants to merge 1 commit into
developfrom
claude/project-thread-u8vgm0-bring-along
Closed

joepio wants to merge 1 commit into
developfrom
claude/project-thread-u8vgm0-bring-along

Conversation

@joepio

@joepio joepio commented Oct 5, 2026

Copy link
Copy Markdown
Member

Before: both identity-bring-along.spec.ts tests failed in CI on every retry since #2055 (guests make an account before a template drive). Their own steps passed. What failed them was an unexpected browser error, [t, t, t] [Object, Object, Object].

After: both tests pass. Locally, with the spec repeated 6 times on 4 workers, 11 of 12 runs passed and that error did not appear. The one failure was a route.fetch socket hang-up under load, which has nothing to do with this change.

That error is loro-prosemirror's console.error for a remote cursor it cannot place yet. #2055 made the guest's drive directly while the page was still on the demo document. The scripted teammates there keep moving their cursors, and under load each one is logged. The old template step navigated away first. The bring-along flow itself was not broken.

How: guestWorkspace now opens the settings page before it makes the drive. It is not /app/agent, because the conflict-dialog test navigates there to start the check.

Related Issues

Unblocks #2066 (vault delta packs), whose CI is red only on these two tests.

Checklist

  • Add changelog entry linking to issue, describe API changes
  • Add or update tests if needed
  • Update docs if needed

Generated by Claude Code

Since #2055 the bring-along spec made its guest drive while still on the demo
document. Its scripted teammates keep moving their cursors, and under load
loro-prosemirror logs each cursor it cannot place yet as a console error,
which fails both tests in CI. Open the settings page first, as the old
template step did by navigating away.
joepio added a commit that referenced this pull request Oct 6, 2026
One tested commit for the open PRs of 5 October: link device to account (#1948), one profile form (#1953), faster branch runs (#1956), end-to-end encrypted conversations (#1971), passkey ceremony header (#1972), Flutter account package (#2035), cheap canvas undo (#2053), atomic.place tab title (#2056), table resource cell (#2057), small table fixes (#2058), storage map (#2061), Sync page cloud ladder (#2072), several served-domain suffixes (#2073), one sign-in (#2074), smaller chat messages (#2077), bring-along e2e fix (#2078), inline row data loss (#2079), Retry-After (#2080), #2070, #2071, #2066, #2067, #2068, #1969, #1887, #1897 and #1920.

Compressed stored values from #2077 stay readable, but a downgrade cannot read compressed rows.

Co-authored-by: Joep Meindertsma <joep@ontola.io>
@joepio joepio closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant