Repository navigation
Share action configuration fields and raw numeric validation - #2528
Closed
michielbdejong wants to merge 1 commit into
Closed
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
michielbdejong
marked this pull request as draft
November 13, 2026 16:04
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structurally split — superseded by #2551 (code moves) and #2552 (functionality improvements).
The improvement child’s full Git tree matches this original head exactly. Original refs/review history are preserved. The pair uses this PR’s legacy base for review; later restacking remains necessary and it is not a prerequisite of the independent clean extraction #2536. This is a structural content split, not completion of the whole TablePage port. The original description follows.
Mixed extraction and behavior changes — held for separation.
This branch combines moved UI/model/query code with changed validation, scope, recovery or state behavior. Those changes must be separated before this PR is ready: move the existing complete TablePage first, preserving behavior, then review improvements as follow-ups. The original branch and validation are preserved below; the current legacy stack is not a completed clean split and must not be merged as the TablePage extraction.
See the revised scope.
Move the actual row-action configuration fields into TableRowActionFields: action kind, compatible property/tag choices, label and literal/step input. Kind and property changes clear their previous target/literal. Numeric steps retain partial raw text and block Save until valid; zero remains numeric zero. Incoming metadata rerenders preserve the local action identity and draft.
AtomicServer supplies compatibility and subscribed option labels, and retains its input wrapper styling. Dialog lifecycle and backend execution remain host-owned.
Validation: 185 package tests, 149 Atomic adapter tests, package and host typechecks, packed external consumer, changed-component React compiler checks and repository hooks pass. Actual SDK desktop/mobile verification retains '-' with Save blocked, then independently reads numeric 0 from the saved action metadata. Screenshots reviewed in chat; artifacts remain outside Git in /workspace/artifacts/table-row-action-fields.
Stacked on #2527. Planning records merged native quick-add adoption in database-apps #118. Native row actions, complete page/renderer adoption and catalog/lens discovery remain unfinished.