Skip to content

Share action configuration fields and raw numeric validation - #2528

Closed
michielbdejong wants to merge 1 commit into
codex/tablepage-quick-add-controlfrom
codex/tablepage-row-action-fields
Closed

michielbdejong wants to merge 1 commit into
codex/tablepage-quick-add-controlfrom
codex/tablepage-row-action-fields

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Structurally split — superseded by #2551 (code moves) and #2552 (functionality improvements).

The improvement child’s full Git tree matches this original head exactly. Original refs/review history are preserved. The pair uses this PR’s legacy base for review; later restacking remains necessary and it is not a prerequisite of the independent clean extraction #2536. This is a structural content split, not completion of the whole TablePage port. The original description follows.


Mixed extraction and behavior changes — held for separation.

This branch combines moved UI/model/query code with changed validation, scope, recovery or state behavior. Those changes must be separated before this PR is ready: move the existing complete TablePage first, preserving behavior, then review improvements as follow-ups. The original branch and validation are preserved below; the current legacy stack is not a completed clean split and must not be merged as the TablePage extraction.

See the revised scope.


Move the actual row-action configuration fields into TableRowActionFields: action kind, compatible property/tag choices, label and literal/step input. Kind and property changes clear their previous target/literal. Numeric steps retain partial raw text and block Save until valid; zero remains numeric zero. Incoming metadata rerenders preserve the local action identity and draft.

AtomicServer supplies compatibility and subscribed option labels, and retains its input wrapper styling. Dialog lifecycle and backend execution remain host-owned.

Validation: 185 package tests, 149 Atomic adapter tests, package and host typechecks, packed external consumer, changed-component React compiler checks and repository hooks pass. Actual SDK desktop/mobile verification retains '-' with Save blocked, then independently reads numeric 0 from the saved action metadata. Screenshots reviewed in chat; artifacts remain outside Git in /workspace/artifacts/table-row-action-fields.

Stacked on #2527. Planning records merged native quick-add adoption in database-apps #118. Native row actions, complete page/renderer adoption and catalog/lens discovery remain unfinished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant