Skip to content

Own action drafts and validate raw numeric configuration (split #2528) - #2552

Open
michielbdejong wants to merge 2 commits into
codex/split-2528-movefrom
codex/split-2528-improvement
Open

michielbdejong wants to merge 2 commits into
codex/split-2528-movefrom
codex/split-2528-improvement

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The shared action form owns its draft, retains the initial action identity while editing, preserves unfinished numeric text, validates finite decimal input and compatible target/tag identity, and supports locking. These input-state/lifetime changes are separate from the controlled presentation move in #2551.

A review regression fixes an additional stale-metadata hole: if subscribed allowed tag options become empty, the form now blocks saving instead of treating that empty list as unrestricted input. The original draft is retained and becomes valid again if its option returns. An absent allowed-values list still permits free text.

This is the behavior half of superseded #2528. The initial split commit c0e6e52 has the exact complete Git tree of original 324191063b6bd23937f044f089faf2f5dc69e790; follow-up 57a6419 adds only the empty-option fix and regressions. Original refs/review history are preserved.

Ready for trekmeester's content review; not independently ready to merge. It retains legacy ancestry through #2551 and needs clean-base restacking and full integration CI before merge. It is not a prerequisite of the clean extraction #2536. No useValue/Resource/Store contract changes, ELFA pin changes or additional TablePage extraction.

Validation: 186 package tests passed after the stale-option fix; the final focused action-form suite passes all 4 tests, including an additional unrestricted-literal control. Package typecheck/build and React Compiler pass (memoization emitted). Mandatory staged-snapshot workspace lint passes. The original split also passed 17 Atomic row-action checks; this follow-up changes only the shared form's option validation/rendering.

Real Chromium mounted the actual shared component in a standalone browser fixture and verified option removal disables Save, keeps a select, and restoration recovers the original value, without page errors. Actual desktop/mobile captures were shown in the task chat and remain outside Git at /workspace/artifacts/action-drafts-review/empty-options-{desktop,mobile}.png. These are component-fixture captures; the original full SDK desktop/mobile captures remain at /workspace/artifacts/table-row-action-fields.

@michielbdejong
michielbdejong marked this pull request as ready for review November 16, 2026 12:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant