Repository navigation
Own action drafts and validate raw numeric configuration (split #2528) - #2552
Open
michielbdejong wants to merge 2 commits into
Open
michielbdejong wants to merge 2 commits into
michielbdejong wants to merge 2 commits into
Conversation
This was referenced Nov 16, 2026
michielbdejong
marked this pull request as ready for review
November 16, 2026 12:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared action form owns its draft, retains the initial action identity while editing, preserves unfinished numeric text, validates finite decimal input and compatible target/tag identity, and supports locking. These input-state/lifetime changes are separate from the controlled presentation move in #2551.
A review regression fixes an additional stale-metadata hole: if subscribed allowed tag options become empty, the form now blocks saving instead of treating that empty list as unrestricted input. The original draft is retained and becomes valid again if its option returns. An absent allowed-values list still permits free text.
This is the behavior half of superseded #2528. The initial split commit
c0e6e52has the exact complete Git tree of original324191063b6bd23937f044f089faf2f5dc69e790; follow-up57a6419adds only the empty-option fix and regressions. Original refs/review history are preserved.Ready for trekmeester's content review; not independently ready to merge. It retains legacy ancestry through #2551 and needs clean-base restacking and full integration CI before merge. It is not a prerequisite of the clean extraction #2536. No useValue/Resource/Store contract changes, ELFA pin changes or additional TablePage extraction.
Validation: 186 package tests passed after the stale-option fix; the final focused action-form suite passes all 4 tests, including an additional unrestricted-literal control. Package typecheck/build and React Compiler pass (memoization emitted). Mandatory staged-snapshot workspace lint passes. The original split also passed 17 Atomic row-action checks; this follow-up changes only the shared form's option validation/rendering.
Real Chromium mounted the actual shared component in a standalone browser fixture and verified option removal disables Save, keeps a select, and restoration recovers the original value, without page errors. Actual desktop/mobile captures were shown in the task chat and remain outside Git at
/workspace/artifacts/action-drafts-review/empty-options-{desktop,mobile}.png. These are component-fixture captures; the original full SDK desktop/mobile captures remain at/workspace/artifacts/table-row-action-fields.