Skip to content

Move action field presentation with host-owned draft state (split #2528) - #2551

Open
michielbdejong wants to merge 1 commit into
codex/tablepage-extraction-onlyfrom
codex/split-2528-move
Open

michielbdejong wants to merge 1 commit into
codex/tablepage-extraction-onlyfrom
codex/split-2528-move

Conversation

@michielbdejong

@michielbdejong michielbdejong commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Combined clean-stack verification: this head (9c9b5e9) is included in validation batch bd4fa0e. On that combined tree, the full Data Browser typecheck, UI/table builds, table types, 39 package tests and 107 affected Atomic host tests pass, including real WASM formula/aggregate coverage. Real local-only TablePage desktop/touch-mobile journeys reopen stored SDK data and exercise row selection without page errors; screenshots were shown in chat at /workspace/artifacts/tablepage-clean-restack-combined. The batch reconciles additive exports/type wrappers and coverage notes; it adds no state-management improvement. Full Main CI is still pending; Table, Shared UI and Flutter hosted checks pass on that batch; Main and downstream remain queued for the self-hosted runner. This supersedes the pending combined-app-check note below, not the full-CI merge prerequisite. Trekmeester owns merge review; nothing has been merged.

Move the existing row-action configuration fields into @tomic/table on the clean #2536 foundation. The Atomic dialog still owns its state, initialization, numeric conversion, validation and Save/Cancel handlers. Inputs reuse the canonical @tomic/ui implementations; the four existing action verbs and option types are shared without importing the legacy saved-view configuration framework.

This is a behavior-preserving code move. Native numeric inputs and the existing free-text fallback for empty tag options are retained; raw draft ownership, stricter validation and stale-option recovery belong in improvement #2552. Resource/property editor APIs, useValue/Resource/Store contracts and ELFA's pin are unchanged. It adds 121 net production lines, including an 18-line data-only type module also used by the separate create-fields restack.

Restack and preservation

Restacked onto clean extraction #2536 at cbaa6c1; this PR no longer carries the legacy state-service ancestry. The old move head 5190a49 is retained on codex/legacy-split-2528-move. Improvement #2552 now targets that preserved branch, so its existing review diff and history remain intact until its own clean-base restack. The original mixed #2528 review is retained.

Validation

  • 17 table-package tests and 17 Atomic row-action regressions pass; package typecheck and build pass.
  • Mandatory staged-snapshot full workspace lint passes. The new shared component compiles cleanly with memoization; the host retains its identical baseline effect-suppression diagnostic.
  • The host's draft conversion/validation and Save/Cancel sections were compared directly with the clean foundation and remain byte-for-byte identical.
  • Actual Chromium mounts the extracted component in a standalone controlled-host fixture and verifies numeric zero, action/target changes and tag selection with no page errors. Desktop/mobile captures were inspected in the task chat and are outside Git at /workspace/artifacts/action-move-restack/{numeric-desktop,tag-mobile}.png. These are component-fixture checks, not a completed full-TablePage integration claim.
  • The standalone full Data Browser typecheck was stopped during concurrent-worker memory pressure without a completed result; it is deferred to the coordinator's sequential combined-candidate check. Dedicated checks are being rerun for this new head. Previous legacy-head green CI is not validation of this restack. Full Main integration remains required before merge.

Prepared for trekmeester's review. No merge performed; clean foundation dependencies #2535/#2536 remain open.

@michielbdejong
michielbdejong changed the base branch from codex/tablepage-quick-add-control to codex/tablepage-extraction-only November 18, 2026 08:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant