Repository navigation
Move action field presentation with host-owned draft state (split #2528) - #2551
Open
michielbdejong wants to merge 1 commit into
Open
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
This was referenced Nov 16, 2026
michielbdejong
marked this pull request as ready for review
November 16, 2026 12:12
michielbdejong
force-pushed
the
codex/split-2528-move
branch
from
November 18, 2026 08:27
5190a49 to
9c9b5e9
Compare
michielbdejong
changed the base branch from
codex/tablepage-quick-add-control
to
codex/tablepage-extraction-only
November 18, 2026 08:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined clean-stack verification: this head (
9c9b5e9) is included in validation batchbd4fa0e. On that combined tree, the full Data Browser typecheck, UI/table builds, table types, 39 package tests and 107 affected Atomic host tests pass, including real WASM formula/aggregate coverage. Real local-only TablePage desktop/touch-mobile journeys reopen stored SDK data and exercise row selection without page errors; screenshots were shown in chat at/workspace/artifacts/tablepage-clean-restack-combined. The batch reconciles additive exports/type wrappers and coverage notes; it adds no state-management improvement. Full Main CI is still pending; Table, Shared UI and Flutter hosted checks pass on that batch; Main and downstream remain queued for the self-hosted runner. This supersedes the pending combined-app-check note below, not the full-CI merge prerequisite. Trekmeester owns merge review; nothing has been merged.Move the existing row-action configuration fields into
@tomic/tableon the clean #2536 foundation. The Atomic dialog still owns its state, initialization, numeric conversion, validation and Save/Cancel handlers. Inputs reuse the canonical@tomic/uiimplementations; the four existing action verbs and option types are shared without importing the legacy saved-view configuration framework.This is a behavior-preserving code move. Native numeric inputs and the existing free-text fallback for empty tag options are retained; raw draft ownership, stricter validation and stale-option recovery belong in improvement #2552. Resource/property editor APIs, useValue/Resource/Store contracts and ELFA's pin are unchanged. It adds 121 net production lines, including an 18-line data-only type module also used by the separate create-fields restack.
Restack and preservation
Restacked onto clean extraction #2536 at
cbaa6c1; this PR no longer carries the legacy state-service ancestry. The old move head5190a49is retained oncodex/legacy-split-2528-move. Improvement #2552 now targets that preserved branch, so its existing review diff and history remain intact until its own clean-base restack. The original mixed #2528 review is retained.Validation
/workspace/artifacts/action-move-restack/{numeric-desktop,tag-mobile}.png. These are component-fixture checks, not a completed full-TablePage integration claim.Prepared for trekmeester's review. No merge performed; clean foundation dependencies #2535/#2536 remain open.