Skip to content

chore: Update JSII version constraint - #245

Merged
jsteinich merged 2 commits into
open-constructs:mainfrom
X-Guardian:chore/update-jsii-version-constraint
Jun 8, 2026
Merged

chore: Update JSII version constraint#245
jsteinich merged 2 commits into
open-constructs:mainfrom
X-Guardian:chore/update-jsii-version-constraint

Conversation

@X-Guardian

@X-Guardian X-Guardian commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Change all jsii and jsii-rosetta pins from exact versions to floating patch ranges (~5.9.0). This matches the same pattern that jsii-rosetta itself uses internally, ensuring our constraints are satisfied by whatever 5.9.x patch lands in the dependency tree.

This avoids getting unmet dependency warnings on new releases of jsii.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@sakul-learning

sakul-learning commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Non-blocking package/workspace consistency note from running sherif on this PR:

sherif found repo-wide package consistency issues that look broader than this JSII constraint update, so I would not treat the broad autofix as a blocker for this PR.

High-level findings:

  • sherif could not fully run until one package metadata issue was normalized locally: tools/generate-function-bindings/package.json has "private": "true", which should be boolean true.
  • After that local normalization, sherif reported 23 issues across 69 packages: 15 errors and 8 warnings.
  • The issues are mostly workspace/package hygiene:
    • workspace globs matching folders without package.json
    • .yalc/* / .yalc/@*/* workspace globs matching no packages
    • multiple dependency versions across workspace packages
    • unordered dependencies in packages/cdktn-cli/package.json
  • The generated sherif autofix is broad: 33 package.json files changed, mostly selecting highest dependency versions and normalizing versions across examples/packages/tooling.

Full report, raw sherif output, and the broad autofix diff are here:

https://gist.github.com/sakul-learning/332a1434a26e1fa619fc498e59f807b1

Recommendation: if maintainers want to act on this, I’d split it into a small metadata/workspace follow-up and a separate dedicated package-consistency cleanup PR, rather than folding the broad 33-file autofix into this PR.

@lucasdesmet lucasdesmet mentioned this pull request Jun 6, 2026
Open
@lucasdesmet

lucasdesmet commented Jun 6, 2026

Copy link
Copy Markdown

Filed #246 to track the sherif workspace/package-consistency findings separately, so this PR stays scoped to the JSII constraint change. The issue captures the recommended two-PR split (trivial metadata/workspace fix + a dedicated dependency-consistency cleanup) and links back to the report and autofix gist. An agent can pick it up from there.

@X-Guardian
X-Guardian marked this pull request as ready for review June 6, 2026 08:00
@X-Guardian
X-Guardian requested a review from a team as a code owner June 6, 2026 08:00
@jsteinich

jsteinich commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

I was hoping not to create yet another conflict with #170, but we could merge this earlier.

@X-Guardian

X-Guardian commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

This will be simple to rebase on #170 if you want to merge it first.

@jsteinich
jsteinich merged commit d89558f into open-constructs:main Jun 8, 2026
258 checks passed
@open-constructs-cdktn open-constructs-cdktn Bot mentioned this pull request Jun 8, 2026
Merged
so0k pushed a commit that referenced this pull request Jul 3, 2026
@open-constructs-cdktn
chore(release): release v0.23.4 (#254)
bf3131c 
🤖 Release PR — merge to cut a new release. Kept open and rebased
as commits land on `main`.
---


<details><summary>0.23.4</summary>

##
[0.23.4](v0.23.3...v0.23.4)
(2026-07-02)


### Features

* **cli:** validate Terraform CLI feature versions
([#237](#237))
([32d434c](32d434c))
* declared Terraform/OpenTofu target versions (validation foundation)
([#269](#269))
([0aa2343](0aa2343))
* **lib:** S3-backend - Add `useLockfile` field and update
`dynamodbTable` deprecated JSDoc
([#234](#234))
([32a408f](32a408f))
* **lib:** validate Fn usage against Terraform/OpenTofu versions
([#268](#268))
([cdf8115](cdf8115))


### Bug Fixes

* **cli:** don't mistake terraform error output for a missing-variable
prompt
([#267](#267))
([0ea946f](0ea946f))
* **cli:** release terraform state lock when interrupting diff/deploy
([#284](#284))
([de617db](de617db))
* **cli:** resolve prebuilt Java provider versions via repo1.maven.org
([#285](#285))
([d5af07d](d5af07d))
* **gha:** Adding CHANGELOG.md to prettier ignore list
([#258](#258))
([5160469](5160469))
* **gha:** pull jsii-terraform CI image from GHCR instead of Docker Hub
([#261](#261))
([f19d34b](f19d34b))
* **provider-generator:** copy only publishable files into the jsii
compile bundle
([#292](#292))
([562d4c7](562d4c7))
* **provider-generator:** match shorthand provider sources against
OpenTofu schema keys
([#293](#293))
([fda0103](fda0103))
* **release:** add Changelog title for correct release-please insertion
([#255](#255))
([004818a](004818a))
* **release:** drop devEngines.packageManager that broke npm publish
([ef508a6](ef508a6))
* **tools:** repair generate-function-bindings tool
([#273](#273))
([821e1cf](821e1cf))


### Miscellaneous Chores

* Add Gradle to Mise config
([#271](#271))
([1578270](1578270))
* add pnpm to mise
([#266](#266))
([48ab91f](48ab91f))
* add uv to mise
([#260](#260))
([163cf3d](163cf3d))
* **deps:** bump nrwl/nx-set-shas from
38457b511e60ee4e1da09255b658e480748a1af4 to
afb73a62d26e41464e9254689e1fd6122ee683c1
([#236](#236))
([b5ac018](b5ac018))
* **deps:** bump the github-actions-backward-compatible group across 1
directory with 7 updates
([#235](#235))
([de67d9f](de67d9f))
* **deps:** replace uuid dependency with node:crypto.randomUUID
([#291](#291))
([6d3657a](6d3657a))
* ESLint ignore test edge-provider-bindings
([#270](#270))
([ba407bb](ba407bb))
* Fix Verdaccio logging config
([#272](#272))
([aded64b](aded64b))
* **gha:** parallelize provider binding generation for documentation
examples
([#244](#244))
([0a9c955](0a9c955))
* Migrate package manager from yarn to pnpm
([#170](#170))
([d23da4e](d23da4e))
* migrate planning artifacts to cdktn-planning [skip ci]
([968c358](968c358))
* **release:** add release-please automation for versioning
([#243](#243))
([c759eec](c759eec))
* Remove dependency-pinner tool
([#250](#250))
([42c27d5](42c27d5))
* Remove unused dependencies
([#281](#281))
([c7de65e](c7de65e))
* **tests:** run verdaccio in-process
([#248](#248))
([c17677d](c17677d))
* Update JSII version constraint
([#245](#245))
([d89558f](d89558f))
* Update scheduled workflows to only run on open-constructs/cdk-terrain
([#256](#256))
([ba408cf](ba408cf))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: open-constructs-cdktn[bot] <291052431+open-constructs-cdktn[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jsteinich jsteinich jsteinich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@X-Guardian @sakul-learning @lucasdesmet @jsteinich