Skip to content

fix(tools): repair generate-function-bindings tool - #273

Merged
so0k merged 7 commits into
open-constructs:mainfrom
sakul-learning:chore/supersede-262-generate-function-bindings
Jun 13, 2026
Merged

fix(tools): repair generate-function-bindings tool#273
so0k merged 7 commits into
open-constructs:mainfrom
sakul-learning:chore/supersede-262-generate-function-bindings

Conversation

@sakul-learning

@sakul-learning sakul-learning commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Supersedes chore: fix generate-function-bindings tool #262 by carrying forward the existing X-Guardian generate-function-bindings fix history and adding a minimal follow-up fix.
  • Preserves the original X-Guardian contribution commits in this branch history for author attribution, including 3e3741298 chore: fix generate-function-bindings tool.
  • Fixes the root generator command to run through the pnpm workspace instead of running a nested install.
  • Avoids requiring @cdktn/commons as a tool package workspace dependency by using a type-only source import for AttributeType.

Test Plan

  • pnpm install --frozen-lockfile --ignore-scripts
  • pnpm run generate-function-bindings
  • git diff --exit-code -- packages/cdktn/src/functions/terraform-functions.generated.ts packages/@cdktn/hcl2cdk/src/function-bindings/functions.generated.ts
  • pnpm --filter generate-function-bindings exec tsc --noEmit
  • pnpm exec prettier --check package.json tools/generate-function-bindings/package.json tools/generate-function-bindings/scripts/generate.ts pnpm-lock.yaml

Notes

  • I could not push the branch directly to open-constructs/cdk-terrain with the available sakul-learning GitHub token (403 Permission denied), so this PR uses sakul-learning:chore/supersede-262-generate-function-bindings as the head while targeting open-constructs/cdk-terrain:main.
  • The submitted branch preserves the original commit SHAs where possible instead of cherry-picking/squashing them.

Supersedes #262.

@sakul-learning
sakul-learning requested a review from a team as a code owner June 13, 2026 03:14
@so0k so0k added ci/skip-examples Skip Examples Testing in PR ci/skip-integration Skips Integration Testing on PR ci/skip-provider-integration Skips Provider Integration Tests on PR ci/skip-unit Skips Unit Testing on PR labels Jun 13, 2026
@so0k so0k changed the title chore: fix generate-function-bindings tool chore(tools): fix generate-function-bindings tool Jun 13, 2026
@so0k so0k changed the title chore(tools): fix generate-function-bindings tool chore(lib): fix generate-function-bindings tool Jun 13, 2026
@sakul-learning sakul-learning changed the title chore(lib): fix generate-function-bindings tool fix(tools): repair generate-function-bindings tool Jun 13, 2026
so0k
so0k approved these changes Jun 13, 2026
View reviewed changes

@so0k so0k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this merged to unblock function availability matrix

@so0k
so0k enabled auto-merge (squash) June 13, 2026 03:46
@so0k
so0k merged commit 821e1cf into open-constructs:main Jun 13, 2026
13 checks passed
@open-constructs-cdktn open-constructs-cdktn Bot mentioned this pull request Jun 13, 2026
Merged
This was referenced Jun 13, 2026
Closed
Open
so0k pushed a commit that referenced this pull request Jul 3, 2026
@open-constructs-cdktn
chore(release): release v0.23.4 (#254)
bf3131c 
🤖 Release PR — merge to cut a new release. Kept open and rebased
as commits land on `main`.
---


<details><summary>0.23.4</summary>

##
[0.23.4](v0.23.3...v0.23.4)
(2026-07-02)


### Features

* **cli:** validate Terraform CLI feature versions
([#237](#237))
([32d434c](32d434c))
* declared Terraform/OpenTofu target versions (validation foundation)
([#269](#269))
([0aa2343](0aa2343))
* **lib:** S3-backend - Add `useLockfile` field and update
`dynamodbTable` deprecated JSDoc
([#234](#234))
([32a408f](32a408f))
* **lib:** validate Fn usage against Terraform/OpenTofu versions
([#268](#268))
([cdf8115](cdf8115))


### Bug Fixes

* **cli:** don't mistake terraform error output for a missing-variable
prompt
([#267](#267))
([0ea946f](0ea946f))
* **cli:** release terraform state lock when interrupting diff/deploy
([#284](#284))
([de617db](de617db))
* **cli:** resolve prebuilt Java provider versions via repo1.maven.org
([#285](#285))
([d5af07d](d5af07d))
* **gha:** Adding CHANGELOG.md to prettier ignore list
([#258](#258))
([5160469](5160469))
* **gha:** pull jsii-terraform CI image from GHCR instead of Docker Hub
([#261](#261))
([f19d34b](f19d34b))
* **provider-generator:** copy only publishable files into the jsii
compile bundle
([#292](#292))
([562d4c7](562d4c7))
* **provider-generator:** match shorthand provider sources against
OpenTofu schema keys
([#293](#293))
([fda0103](fda0103))
* **release:** add Changelog title for correct release-please insertion
([#255](#255))
([004818a](004818a))
* **release:** drop devEngines.packageManager that broke npm publish
([ef508a6](ef508a6))
* **tools:** repair generate-function-bindings tool
([#273](#273))
([821e1cf](821e1cf))


### Miscellaneous Chores

* Add Gradle to Mise config
([#271](#271))
([1578270](1578270))
* add pnpm to mise
([#266](#266))
([48ab91f](48ab91f))
* add uv to mise
([#260](#260))
([163cf3d](163cf3d))
* **deps:** bump nrwl/nx-set-shas from
38457b511e60ee4e1da09255b658e480748a1af4 to
afb73a62d26e41464e9254689e1fd6122ee683c1
([#236](#236))
([b5ac018](b5ac018))
* **deps:** bump the github-actions-backward-compatible group across 1
directory with 7 updates
([#235](#235))
([de67d9f](de67d9f))
* **deps:** replace uuid dependency with node:crypto.randomUUID
([#291](#291))
([6d3657a](6d3657a))
* ESLint ignore test edge-provider-bindings
([#270](#270))
([ba407bb](ba407bb))
* Fix Verdaccio logging config
([#272](#272))
([aded64b](aded64b))
* **gha:** parallelize provider binding generation for documentation
examples
([#244](#244))
([0a9c955](0a9c955))
* Migrate package manager from yarn to pnpm
([#170](#170))
([d23da4e](d23da4e))
* migrate planning artifacts to cdktn-planning [skip ci]
([968c358](968c358))
* **release:** add release-please automation for versioning
([#243](#243))
([c759eec](c759eec))
* Remove dependency-pinner tool
([#250](#250))
([42c27d5](42c27d5))
* Remove unused dependencies
([#281](#281))
([c7de65e](c7de65e))
* **tests:** run verdaccio in-process
([#248](#248))
([c17677d](c17677d))
* Update JSII version constraint
([#245](#245))
([d89558f](d89558f))
* Update scheduled workflows to only run on open-constructs/cdk-terrain
([#256](#256))
([ba408cf](ba408cf))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: open-constructs-cdktn[bot] <291052431+open-constructs-cdktn[bot]@users.noreply.github.com>
@so0k

so0k commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

this resolved upstream issues:

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@so0k so0k so0k approved these changes

Assignees

No one assigned

Labels

ci/skip-examples Skip Examples Testing in PR ci/skip-integration Skips Integration Testing on PR ci/skip-provider-integration Skips Provider Integration Tests on PR ci/skip-unit Skips Unit Testing on PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sakul-learning @so0k @X-Guardian