Skip to content

chore: Remove unused dependencies - #281

Merged
so0k merged 3 commits into
open-constructs:mainfrom
X-Guardian:chore/remove-unused-dependencies
Jun 29, 2026
Merged

chore: Remove unused dependencies#281
so0k merged 3 commits into
open-constructs:mainfrom
X-Guardian:chore/remove-unused-dependencies

Conversation

@X-Guardian

@X-Guardian X-Guardian commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Removes four declared dependencies with no usage. Each was verified before removal:

  • Root package.json devDependencies:
    • infer-owner — no source references anywhere in the repo.
    • semver — the root declaration has no importer. The semver deps in packages/cdktn, packages/cdktn-cli, and packages/@cdktn/cli-core are used and are left in place; only the redundant root-level declaration is removed.
  • test/package.json devDependencies:
    • express and @types/express — no usage.

changelog-parser is kept: it's required by tools/extract-changelog (invoked from tools/release-github.sh). knip can't see this because it traces dependencies through the import graph, and a shell-invoked script isn't in that graph — so it carries a knip.jsonc ignore entry documenting the consumer.

knip.jsonc is updated to remove the ignoreDependencies entries for the deleted deps.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@X-Guardian
X-Guardian marked this pull request as ready for review June 26, 2026 13:44
@X-Guardian
X-Guardian requested a review from a team as a code owner June 26, 2026 13:44
@sakul-learning

sakul-learning commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Thanks for the cleanup here. One important release-path detail: release-please has not taken over the full release job yet; it only maintains the release PR / changelog / manifest in the current setup. The GitHub Release is still created by the existing release workflow, which still depends on the tool that imports changelog-parser.

Current dependency trace:

  1. .github/workflows/release-please.yml documents that release-please runs with skip-github-release: true, so it does not create the tag or GitHub Release. Its comments say that responsibility remains with release.yml's release_github job.
  2. .github/workflows/release.yml has the active release_github job (Release to Github) which runs pnpm run release-github.
  3. package.json maps release-github to tools/release-github.sh.
  4. tools/release-github.sh calls tools/extract-changelog to build the GitHub Release body.
  5. tools/extract-changelog does require("changelog-parser").

So removing the root changelog-parser dependency breaks the currently configured GitHub Release creation path. If the goal is to retire that path because release-please should own GitHub releases too, this PR should also update the release ownership intentionally (for example, flip release-please off skip-github-release and remove/update the release_github job and the now-obsolete tools). Otherwise, changelog-parser should stay declared.

@sakul-learning sakul-learning mentioned this pull request Jun 26, 2026
Open
so0k
so0k requested changes Jun 28, 2026
View reviewed changes

@so0k so0k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either define package.json in tools and move changelog-parser as a dependency for the tools, or keep the root changelog-parser dependency

Comment thread package.json Resolved
@so0k
so0k merged commit c7de65e into open-constructs:main Jun 29, 2026
258 checks passed
@open-constructs-cdktn open-constructs-cdktn Bot mentioned this pull request Jun 26, 2026
Merged
@X-Guardian
X-Guardian deleted the chore/remove-unused-dependencies branch June 30, 2026 08:40
so0k pushed a commit that referenced this pull request Jul 3, 2026
@open-constructs-cdktn
chore(release): release v0.23.4 (#254)
bf3131c 
🤖 Release PR — merge to cut a new release. Kept open and rebased
as commits land on `main`.
---


<details><summary>0.23.4</summary>

##
[0.23.4](v0.23.3...v0.23.4)
(2026-07-02)


### Features

* **cli:** validate Terraform CLI feature versions
([#237](#237))
([32d434c](32d434c))
* declared Terraform/OpenTofu target versions (validation foundation)
([#269](#269))
([0aa2343](0aa2343))
* **lib:** S3-backend - Add `useLockfile` field and update
`dynamodbTable` deprecated JSDoc
([#234](#234))
([32a408f](32a408f))
* **lib:** validate Fn usage against Terraform/OpenTofu versions
([#268](#268))
([cdf8115](cdf8115))


### Bug Fixes

* **cli:** don't mistake terraform error output for a missing-variable
prompt
([#267](#267))
([0ea946f](0ea946f))
* **cli:** release terraform state lock when interrupting diff/deploy
([#284](#284))
([de617db](de617db))
* **cli:** resolve prebuilt Java provider versions via repo1.maven.org
([#285](#285))
([d5af07d](d5af07d))
* **gha:** Adding CHANGELOG.md to prettier ignore list
([#258](#258))
([5160469](5160469))
* **gha:** pull jsii-terraform CI image from GHCR instead of Docker Hub
([#261](#261))
([f19d34b](f19d34b))
* **provider-generator:** copy only publishable files into the jsii
compile bundle
([#292](#292))
([562d4c7](562d4c7))
* **provider-generator:** match shorthand provider sources against
OpenTofu schema keys
([#293](#293))
([fda0103](fda0103))
* **release:** add Changelog title for correct release-please insertion
([#255](#255))
([004818a](004818a))
* **release:** drop devEngines.packageManager that broke npm publish
([ef508a6](ef508a6))
* **tools:** repair generate-function-bindings tool
([#273](#273))
([821e1cf](821e1cf))


### Miscellaneous Chores

* Add Gradle to Mise config
([#271](#271))
([1578270](1578270))
* add pnpm to mise
([#266](#266))
([48ab91f](48ab91f))
* add uv to mise
([#260](#260))
([163cf3d](163cf3d))
* **deps:** bump nrwl/nx-set-shas from
38457b511e60ee4e1da09255b658e480748a1af4 to
afb73a62d26e41464e9254689e1fd6122ee683c1
([#236](#236))
([b5ac018](b5ac018))
* **deps:** bump the github-actions-backward-compatible group across 1
directory with 7 updates
([#235](#235))
([de67d9f](de67d9f))
* **deps:** replace uuid dependency with node:crypto.randomUUID
([#291](#291))
([6d3657a](6d3657a))
* ESLint ignore test edge-provider-bindings
([#270](#270))
([ba407bb](ba407bb))
* Fix Verdaccio logging config
([#272](#272))
([aded64b](aded64b))
* **gha:** parallelize provider binding generation for documentation
examples
([#244](#244))
([0a9c955](0a9c955))
* Migrate package manager from yarn to pnpm
([#170](#170))
([d23da4e](d23da4e))
* migrate planning artifacts to cdktn-planning [skip ci]
([968c358](968c358))
* **release:** add release-please automation for versioning
([#243](#243))
([c759eec](c759eec))
* Remove dependency-pinner tool
([#250](#250))
([42c27d5](42c27d5))
* Remove unused dependencies
([#281](#281))
([c7de65e](c7de65e))
* **tests:** run verdaccio in-process
([#248](#248))
([c17677d](c17677d))
* Update JSII version constraint
([#245](#245))
([d89558f](d89558f))
* Update scheduled workflows to only run on open-constructs/cdk-terrain
([#256](#256))
([ba408cf](ba408cf))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: open-constructs-cdktn[bot] <291052431+open-constructs-cdktn[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@so0k so0k so0k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@X-Guardian @sakul-learning @so0k