Repository navigation
feat(provider-generator): don't emit property params - #43
Merged
Merged
Conversation
gabegorelick
commented
Feb 22, 2026
Typescript property parameters are not an erasable syntax [1]. As such, Typescript code emitted by cdktn cannot be run directly in Node.js. This change removes one use of property parameters to get us closer to emitting Typescript that can be run directly by Node.js. See hashicorp/terraform-cdk#3870 [1] https://www.typescriptlang.org/tsconfig/#erasableSyntaxOnly
gabegorelick
force-pushed
the
property-params
branch
from
February 23, 2026 00:19
b3940c1 to
f77b90f
Compare
Contributor
Author
|
Claude claims this is the only place where non-erasable syntax is being used. So this may be the only blocker for cdktn consumers to run |
gabegorelick
marked this pull request as ready for review
February 23, 2026 15:16
jsteinich
approved these changes
Mar 3, 2026
jsteinich
added a commit
that referenced
this pull request
Mar 27, 2026
### feat - feat(gha): publish Maven artifacts to Maven Central [\#64](#64) - feat: restore NuGet.org publishing [\#50](#50) - feat(provider-generator): don't emit property params [\#43](#43) ### fix - fix(cli): Pin init template to TypesScript 5.x [\#74](#74) - fix(gha): fix Go releases and update git identity [\#65](#65) - fix(provider-generator): handle inline comments with brackets in variable type parsing [\#61](#61) - fix: DEP0044 in TerraformOutput [\#2](#2) ### chore - chore: Upgrade dependencies for all [\#69](#69) - chore(gha): Adding base14 Scout CI/CD observability workflow to instrument all the github actions. [\#52](#52) - chore(deps): Upgrade minimatch to 5.1.8 [\#49](#49) - chore: add cdktn keyword to all packages [\#46](#46) - chore: update links to point to cdktn.io [\#45](#45) - chore: update more references to cdktf [\#44](#44) - chore: fix typo in CONTRIBUTING.md [\#42](#42) - chore(deps): Upgrade validator to 13.15.22 [\#38](#38) - chore(deps): Upgrade glob to 10.5.0 [\#30](#30) - chore: Upgrade dependencies for all [\#22](#22) - chore: Upgrade dependencies for lib [\#18](#18) - chore(deps): bump the github-actions-backward-compatible group with 4 updates [\#15](#15) - chore(deps): bump the github-actions-breaking group with 11 updates [\#14](#14) ### refactor - refactor(hcl2cdk): global setup/teardown along with parallel tests to speed the b… [\#41](#41)
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript property parameters are not an erasable syntax [1]. As such, Typescript code emitted by cdktn cannot be run directly in Node.js.
This change removes one use of property parameters to get us closer to emitting Typescript that can be run directly by Node.js.
See hashicorp/terraform-cdk#3870
[1] https://www.typescriptlang.org/tsconfig/#erasableSyntaxOnly
Related issue
Should I re-file hashicorp/terraform-cdk#3870 here?
Description
Remove property parameters from
struct-emitter.ts.Checklist