Repository navigation
chore: restore NuGet.org publishing - #50
Merged
Merged
Conversation
so0k
approved these changes
Mar 19, 2026
so0k
left a comment
so0k
left a comment
Contributor
There was a problem hiding this comment.
looks reasonable, assuming this is reverting back to what it was before i moved it to gh pkgs
so0k
added a commit
that referenced
this pull request
Mar 22, 2026
Instead of adding a second Maven Central job alongside GitHub Packages, replace the existing job entirely — consistent with the NuGet.org restoration approach (PR #50). Fixes: - Use MAVEN_SERVER_ID=central-ossrh (publib PR #1667) instead of MAVEN_ENDPOINT - Remove unnecessary permissions: packages: write - Remove MAVEN_STAGING_PROFILE_ID (not needed for central-ossrh) - Fix inconsistent MAVEN_ENDPOINT between release.yml and release_next.yml (was https://central.sonatype.com vs https://hashicorp.oss.sonatype.org) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 22, 2026
so0k
added a commit
that referenced
this pull request
Mar 22, 2026
## Summary Builds on #63 by @krzema12 — replaces the GitHub Packages Maven job with Maven Central publishing instead of adding a second job alongside it (consistent with the NuGet.org restoration in #50). - **Replace** (not add alongside) the GitHub Packages Maven job - Use `MAVEN_SERVER_ID=central-ossrh` ([publib #1667](cdklabs/publib#1667)) instead of `MAVEN_ENDPOINT` - Remove unnecessary `permissions: packages: write` - Remove `MAVEN_STAGING_PROFILE_ID` (not needed for `central-ossrh`) - Fix inconsistent `MAVEN_ENDPOINT` between release.yml (`central.sonatype.com`) and release_next.yml (`hashicorp.oss.sonatype.org`) ### Required secrets All 4 secrets have been deployed via IaC: | Secret | Status | |--------|--------| | `MAVEN_USERNAME` | Deployed | | `MAVEN_PASSWORD` | Deployed | | `MAVEN_GPG_PRIVATE_KEY` | Deployed | | `MAVEN_GPG_PRIVATE_KEY_PASSPHRASE` | Deployed | Closes #13 ## Test plan - [x] Generate GPG key (RSA 4096), publish to `keyserver.ubuntu.com` - [x] Deploy all 4 secrets via terraform apply - [ ] Merge and verify first release publishes to `https://central.sonatype.com/artifact/io.cdktn/cdktn` 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Piotr Krzeminski <git@krzeminski.it> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsteinich
added a commit
that referenced
this pull request
Mar 27, 2026
### feat - feat(gha): publish Maven artifacts to Maven Central [\#64](#64) - feat: restore NuGet.org publishing [\#50](#50) - feat(provider-generator): don't emit property params [\#43](#43) ### fix - fix(cli): Pin init template to TypesScript 5.x [\#74](#74) - fix(gha): fix Go releases and update git identity [\#65](#65) - fix(provider-generator): handle inline comments with brackets in variable type parsing [\#61](#61) - fix: DEP0044 in TerraformOutput [\#2](#2) ### chore - chore: Upgrade dependencies for all [\#69](#69) - chore(gha): Adding base14 Scout CI/CD observability workflow to instrument all the github actions. [\#52](#52) - chore(deps): Upgrade minimatch to 5.1.8 [\#49](#49) - chore: add cdktn keyword to all packages [\#46](#46) - chore: update links to point to cdktn.io [\#45](#45) - chore: update more references to cdktf [\#44](#44) - chore: fix typo in CONTRIBUTING.md [\#42](#42) - chore(deps): Upgrade validator to 13.15.22 [\#38](#38) - chore(deps): Upgrade glob to 10.5.0 [\#30](#30) - chore: Upgrade dependencies for all [\#22](#22) - chore: Upgrade dependencies for lib [\#18](#18) - chore(deps): bump the github-actions-backward-compatible group with 4 updates [\#15](#15) - chore(deps): bump the github-actions-breaking group with 11 updates [\#14](#14) ### refactor - refactor(hcl2cdk): global setup/teardown along with parallel tests to speed the b… [\#41](#41)
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore publishing of NuGet packages back to the default location (NuGet.org) using a new api key secret.
https://github.com/open-constructs/cdk-terrain-iac/pull/4 needs to be merged first.
Checklist