Skip to content

fix(provider-generator): handle inline comments with brackets in variable type parsing - #61

Merged
so0k merged 2 commits into
mainfrom
fix/cli/cdktf-get-inline-comment-with-bracket
Mar 20, 2026
Merged

so0k merged 2 commits into
mainfrom
fix/cli/cdktf-get-inline-comment-with-bracket

Conversation

@so0k

@so0k so0k commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #60

Test plan

  • Snapshot generated locally with yarn test:update in packages/@cdktn/provider-schema
  • CI unit tests pass with the new snapshot

🤖 Generated with Claude Code

josh-hook and others added 2 commits March 20, 2026 10:18
@so0k
so0k requested a review from a team as a code owner March 20, 2026 04:36
@so0k
so0k enabled auto-merge (squash) March 20, 2026 07:41

@sheplu sheplu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a small comment the other part is fine

@sheplu sheplu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@so0k
so0k merged commit 3e6e0ac into main Mar 20, 2026
535 of 662 checks passed
@so0k
so0k deleted the fix/cli/cdktf-get-inline-comment-with-bracket branch March 20, 2026 08:54
jsteinich added a commit that referenced this pull request Mar 27, 2026
### feat
- feat(gha): publish Maven artifacts to Maven Central
[\#64](#64)
- feat: restore NuGet.org publishing
[\#50](#50)
- feat(provider-generator): don't emit property params
[\#43](#43)


### fix
- fix(cli): Pin init template to TypesScript 5.x
[\#74](#74)
- fix(gha): fix Go releases and update git identity
[\#65](#65)
- fix(provider-generator): handle inline comments with brackets in
variable type parsing
[\#61](#61)
- fix: DEP0044 in TerraformOutput
[\#2](#2)


### chore
- chore: Upgrade dependencies for all
[\#69](#69)
- chore(gha): Adding base14 Scout CI/CD observability workflow to
instrument all the github actions.
[\#52](#52)
- chore(deps): Upgrade minimatch to 5.1.8
[\#49](#49)
- chore: add cdktn keyword to all packages
[\#46](#46)
- chore: update links to point to cdktn.io
[\#45](#45)
- chore: update more references to cdktf
[\#44](#44)
- chore: fix typo in CONTRIBUTING.md
[\#42](#42)
- chore(deps): Upgrade validator to 13.15.22
[\#38](#38)
- chore(deps): Upgrade glob to 10.5.0
[\#30](#30)
- chore: Upgrade dependencies for all
[\#22](#22)
- chore: Upgrade dependencies for lib
[\#18](#18)
- chore(deps): bump the github-actions-backward-compatible group with 4
updates [\#15](#15)
- chore(deps): bump the github-actions-breaking group with 11 updates
[\#14](#14)


### refactor
- refactor(hcl2cdk): global setup/teardown along with parallel tests to
speed the b…
[\#41](#41)
@github-actions

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants