Repository navigation
Conversation
Lets operators set deviceProfile: sonic (or cisco-ios-xr) on a TargetConnectionProfile CR, with the K8s API enforcing the closed set at apply time, mirroring pkg/config.DeviceProfile in data-server so the value maps 1-to-1 through the gRPC DeviceProfile enum. Wiring the value through to CreateDataStore gRPC is tracked separately (ticket 07).
…tore gRPC Bumps sdc-protos to v0.0.55-0.20260828064538-40ed0bc26a71 (deviceprofile branch, DEVICE_PROFILE_SONIC = 2) and maps TargetConnectionProfileSpec.DeviceProfile onto sdcpb.Target.DeviceProfile in getCreateDataStoreRequest, so data-server can activate the sonic encoder for targets reconciled through the Kubernetes control plane. Ticket: .scratch/sonic-device-profile/issues/07-wire-deviceprofile-through-grpc.md
Ticket 06 was also re-landed here (cherry-picked cleanly onto this branch, cut from origin/main) instead of staying on config-server-cache-backend, so both tickets note why in their Comments sections.
Ticket 07 was almost implemented on config-server-cache-backend by mistake, since that's what the primary checkout happens to be on. Write down the worktree/branch this effort actually uses so that doesn't happen again.
Add example/sonic/{schema,connection-profile,sync-profile,discovery-rule}.yaml
plus a README covering apply order and prerequisites, so operators can
onboard a SONiC device end-to-end through the K8s control plane. Closes
ticket 08 (frontier of the sonic-device-profile effort); no code changes.
This was referenced Aug 28, 2026
Closed
steiler
changed the title
…AMLs Align IOS-XR discovery vendor profile and unit tests with install-oper gNMI paths from live 7.10.1 lab hardware; add schema, sync profile, and sample Config manifests under example/cisco-iosxr for end-to-end onboarding alongside device-profile-base (Pairs-with data-server #508 stack). Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Document data-server pairing and NOS PR preconditions for integration; add connection-profile example for cisco-ios-xr alongside sonic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on / related
DeviceProfilegRPC enum (sonic,cisco-ios-xr).deviceProfile: sonicend-to-end).deviceProfile: cisco-ios-xrend-to-end).See
docs/design/device-profile-paired-testing.mdfor CIPairs-with:guidance.Summary
Config-server side of the device-profile effort (KRM layer): typed
deviceProfileonTargetConnectionProfileSpec("",sonic,cisco-ios-xr), gRPC wiring throughCreateDataStore, and reference onboarding manifests for SONiC and Cisco IOS-XR.Branch name
sonic-device-profileis historical; this PR is the single combined config-serverline for all profile values.
apis/inv/v1alpha1):DeviceProfileNone/DeviceProfileSonic/DeviceProfileCiscoIOSXRonTargetConnectionProfileSpec, withDeviceProfile()defaultingabsent values to none.
pkg/reconcilers/targetdatastore):toProtoDeviceProfilemaps the CR fieldonto
sdcpb.DeviceProfile_*ingetCreateDataStoreRequest.example/sonic/— SONiC schema, connection/sync profiles, discovery rule.example/cisco-iosxr/— IOS-XR sync profile, sample configs, README (json_ietf).example/connection-profiles/— unit-tested connection-profile fixtures for both NOS values.example/schemas/(lab-validated gNMI paths).Ticket tracking:
.scratch/sonic-device-profile/issues/(06–08 done).Test plan
go test ./apis/inv/v1alpha1/...go test ./pkg/reconcilers/targetdatastore/...go test ./pkg/discovery/discoveryrule/...go build ./...