Repository navigation
Conversation
…OS stubs Introduce southbound Set materialization and plan types, wire gRPC/config device_profile with sdc-protos#120 pin, and reject sonic/cisco-ios-xr until their NOS PRs enable them. Retire TargetSource for Set; document seams in ADR 0002.
Track config-server device-profile-base branch for KRM deviceProfile wiring.
This was referenced Sep 24, 2026
1 task done
Clear errcheck/ineffassign/staticcheck findings so Go Checks lint passes.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
4 tasks
faebr
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shared southbound plumbing for device profiles (#504): materialization between intent apply and target Set, plan types,
device_profilein config/gRPC with both proto enum values known but not enabled, and dispatch arms for SONiC and Cisco that fail closed.Supersedes shared-plumbing portions of #442 / #480.
Parent: #504
Preconditions
Test plan
go test ./...with both NOS profiles disabledFollow-ups
sonic-device-profile→ this branch)cisco-ios-xr-gnmi→ this branch)