Repository navigation
Conversation
Lift base-layer rejection for sonic only, add JSON_IETF validation, parent-bound Set encoding and translib Get shaping, and materialize dispatch to the sonic encoder. Cisco IOS-XR remains fail-closed; netconf+sonic is rejected at config load.
5 tasks
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
1 task done
Clear errcheck/ineffassign/staticcheck findings so Go Checks lint passes.
4 tasks
faebr
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parallel SONiC NOS stack off #504 device-profile base: enables
soniconly, JSON_IETF validation, parent-bound Set encoding, materialize dispatch, and Get shaping for translib.Supersedes SONiC-specific scope from legacy #480 (not stacked on Cisco).
Parent: #504
Preconditions
main(rebase stack when fix(#504): land generic correctness fixes from legacy #442/#480 inventory #505 lands)Test plan