Skip to content

Correct Render web version floor preconditions - #755

Merged
thomasluizon merged 1 commit into
mainfrom
thomasluizon/ticket-1531-min-supported-version-1-3-38
Oct 18, 2026
Merged

thomasluizon merged 1 commit into
mainfrom
thomasluizon/ticket-1531-min-supported-version-1-3-38

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Refs thomasluizon/orbit-tickets#1531.

The minimum-version procedure still sent operators to Vercel. Update only that precondition in AGENTS.md to check APP_VERSION on Render's production web services orbit-web and orbit-web-redesign, and staging service orbit-web-staging. The remaining procedure stays intact, following the work order's final orchestrator decision to use guarded operational updates rather than an EF migration.

Service names were checked against infra/production.tf, infra/staging.tf, and orbit-ui-mobile/apps/web/DEPLOYMENT.md. This documentation change needs no deployment or environment change to take effect. The orchestrator owns recording the floor preconditions and performing database operations on the ticket.

Assumptions

  • Include both production web services because Terraform declares orbit-web and orbit-web-redesign; naming only orbit-web was rejected because it would omit the second production service from the precondition.

Test evidence

  • dotnet build Orbit.slnx: passed with zero errors; generated OpenAPI remained unchanged.
  • dotnet test tests/Orbit.Infrastructure.Tests --no-restore --filter FullyQualifiedName~MinimumVersionMiddlewareTests: 15 passed.
  • This change corrects an operational documentation reference, so there is no failing runtime regression test to strengthen. Existing middleware tests exercise runtime enforcement, which this change does not alter.
  • Pre-commit dash, timeless, root allowlist, and suppression allowlist checks passed. The diff adds no C# comments.
  • dotnet test: passed, 9,809 tests across the solution, zero failures.
  • dotnet test tests/Orbit.Domain.Tests --no-build --no-restore: 716 passed, exit 0.
  • dotnet test tests/Orbit.Application.Tests --no-build --no-restore: 5,520 passed, exit 0.
  • dotnet test tests/Orbit.Infrastructure.Tests --no-build --no-restore: 3,541 passed, exit 0.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: Reviewed the minimum-version operational checklist correction in AGENTS.md against Terraform, the sibling web deployment guide, and existing version-header enforcement.

  • Render service coverage: Replaces the obsolete Vercel reference with both production web services, orbit-web and orbit-web-redesign, and staging service orbit-web-staging; all three match the infrastructure definitions.
  • Preserved rollout safeguards: Leaves the guarded database update and version-floor prerequisites unchanged; the existing web header forwarding and API middleware support the retained fail-open guidance. Tests were inspected but not rerun for this documentation-only change; live environment readiness remains an operational prerequisite, not something this PR establishes.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@sonarqubecloud

Copy link
Copy Markdown

@thomasluizon
thomasluizon merged commit 21615aa into main Oct 18, 2026
20 checks passed
@thomasluizon
thomasluizon deleted the thomasluizon/ticket-1531-min-supported-version-1-3-38 branch October 18, 2026 20:02
thomasluizon added a commit that referenced this pull request Oct 19, 2026
…, slip contract and the Supabase sign-in removal (#768)

* Stop Stripe and Play renewals when account deletion is confirmed (#746)

* fix: stop subscription renewal when account deletion is confirmed

* fix: restrict renewal restoration to an unexpired paid period

* fix: keep free account deletion independent of billing services

* fix: bound billing cancellation delays during account erasure

* fix: preserve renewal intent during deletion reconciliation

(cherry picked from commit 85d8824)

* docs: name Render web services in version floor preconditions (#755)

(cherry picked from commit 21615aa)

* fix(infra): use Render for production database connections (#754)

(cherry picked from commit e2909b6)

* test(habits): cover end date reactivation allowance through handler (#759)

(cherry picked from commit 16203d9)

* test(mcp): verify Pro access for OAuth and API keys (#760)

(cherry picked from commit 0a90f67)

* Cover calendar auto-sync scheduling and import reconciliation (ORB-199) (#761)

* test(calendar): cover auto-sync scheduler eligibility and batching

* test(calendar): cover import suggestion reconciliation filters

* test(calendar): isolate free plan eligibility from expiry

(cherry picked from commit 664c756)

* Clarify controller action cross-references in the agent catalog (#762)

(cherry picked from commit d9cda52)

* refactor(calendar): share legacy match key for sync and suggestions (#763)

(cherry picked from commit 8e754c4)

* Contract habit log slip classification schema (#718) (#764)

(cherry picked from commit b0d3ff4)

* fix(calendar): gate recurring event reconciliation (#765)

(cherry picked from commit c900dba)

* Gate rolling schema contractions behind deployment barriers (#766)

* feat: require deployment barriers for rolling schema contractions

* fix: keep quoted SQL comment markers from hiding contractions

* test: record the deployed habit log contract barrier

* ci: run the rolling contract gate only when its inputs change

The gate builds the infrastructure test project, which costs minutes on every
pull request. It now runs only when a migration, the barrier file or the gate
itself changes; the step before it already reads the same diff.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: require barriers for unclassified ALTER TABLE actions

* test: isolate barrier unit coverage from checkout history

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 626c525)

* fix: require a session claim on access tokens (#767)

(cherry picked from commit 517ed1b)

* Deprecate legacy Google auth routes (#1528, part 1) (#753)

* Deprecate legacy Google auth routes for #1528

* Explain deprecated Google auth routes and annotate legacy tests

(cherry picked from commit 21f810f)

* Remove deleted Supabase sign-in path (#1528) (#752)

* Remove deleted Supabase sign-in path (#1528)

* Remove unused access-token validation catalog entries (#1528)

(cherry picked from commit 141a4a2)

* fix: bind carried schema barrier to the deployed redesign

Record the observed staging deployment and its drained predecessors without changing the migration gate. Regenerate the tracked gating matrix for the combined source. Refs thomasluizon/orbit-tickets#746.

* fix: retain deletion cancellation ownership across provider retries (#770)

* fix: persist deletion cancellation ownership before provider updates

* test: cover deletion intent commit and account changes

* fix: identify deletion-owned Stripe cancellations

Reconcile provider metadata before restoring renewal or retaining ownership, reject open cancellation transactions, and log skipped erasure rechecks.

Refs thomasluizon/orbit-tickets#1547

(cherry picked from commit a7d1cf2)

* test: drop the deprecation assertions the legacy Google route removal supersedes

The base merge brought #769's assertions that POST /api/Auth/google and
POST /api/Auth/operations/google stay available and deprecated. This carry
removes both routes (main's #1528 part 2), so those assertions no longer
have a subject.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant