Repository navigation
Carry the legacy Google route deprecation into redesign main (#746) - #769
Merged
thomasluizon merged 1 commit intoOct 19, 2026
Merged
Conversation
* Deprecate legacy Google auth routes for #1528 * Explain deprecated Google auth routes and annotate legacy tests (cherry picked from commit 21f810f)
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the complete deprecation carry into redesign/main, including the existing OpenAPI transformer and affected consumer references.
- Legacy routes preserved: Both Google token-based actions gain
[Obsolete]messages pointing to the existing authorization-code routes, without changing routing, protection, request contracts or responses. - Versioned documentation: Both OpenAPI documents mark the two legacy POST operations as deprecated and remain unchanged after regeneration.
- Regression coverage: Added route/deprecation assertions and retained legacy success/failure coverage; the focused
AuthControllerTestsandApiVersioningTestsrun passed all 136 tests. The full solution suite was not rerun.
gpt-6.1-sol ｜ 𝕏
|
thomasluizon
added a commit
that referenced
this pull request
Oct 19, 2026
… supersedes The base merge brought #769's assertions that POST /api/Auth/google and POST /api/Auth/operations/google stay available and deprecated. This carry removes both routes (main's #1528 part 2), so those assertions no longer have a subject. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thomasluizon
added a commit
that referenced
this pull request
Oct 19, 2026
…, slip contract and the Supabase sign-in removal (#768) * Stop Stripe and Play renewals when account deletion is confirmed (#746) * fix: stop subscription renewal when account deletion is confirmed * fix: restrict renewal restoration to an unexpired paid period * fix: keep free account deletion independent of billing services * fix: bound billing cancellation delays during account erasure * fix: preserve renewal intent during deletion reconciliation (cherry picked from commit 85d8824) * docs: name Render web services in version floor preconditions (#755) (cherry picked from commit 21615aa) * fix(infra): use Render for production database connections (#754) (cherry picked from commit e2909b6) * test(habits): cover end date reactivation allowance through handler (#759) (cherry picked from commit 16203d9) * test(mcp): verify Pro access for OAuth and API keys (#760) (cherry picked from commit 0a90f67) * Cover calendar auto-sync scheduling and import reconciliation (ORB-199) (#761) * test(calendar): cover auto-sync scheduler eligibility and batching * test(calendar): cover import suggestion reconciliation filters * test(calendar): isolate free plan eligibility from expiry (cherry picked from commit 664c756) * Clarify controller action cross-references in the agent catalog (#762) (cherry picked from commit d9cda52) * refactor(calendar): share legacy match key for sync and suggestions (#763) (cherry picked from commit 8e754c4) * Contract habit log slip classification schema (#718) (#764) (cherry picked from commit b0d3ff4) * fix(calendar): gate recurring event reconciliation (#765) (cherry picked from commit c900dba) * Gate rolling schema contractions behind deployment barriers (#766) * feat: require deployment barriers for rolling schema contractions * fix: keep quoted SQL comment markers from hiding contractions * test: record the deployed habit log contract barrier * ci: run the rolling contract gate only when its inputs change The gate builds the infrastructure test project, which costs minutes on every pull request. It now runs only when a migration, the barrier file or the gate itself changes; the step before it already reads the same diff. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: require barriers for unclassified ALTER TABLE actions * test: isolate barrier unit coverage from checkout history --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 626c525) * fix: require a session claim on access tokens (#767) (cherry picked from commit 517ed1b) * Deprecate legacy Google auth routes (#1528, part 1) (#753) * Deprecate legacy Google auth routes for #1528 * Explain deprecated Google auth routes and annotate legacy tests (cherry picked from commit 21f810f) * Remove deleted Supabase sign-in path (#1528) (#752) * Remove deleted Supabase sign-in path (#1528) * Remove unused access-token validation catalog entries (#1528) (cherry picked from commit 141a4a2) * fix: bind carried schema barrier to the deployed redesign Record the observed staging deployment and its drained predecessors without changing the migration gate. Regenerate the tracked gating matrix for the combined source. Refs thomasluizon/orbit-tickets#746. * fix: retain deletion cancellation ownership across provider retries (#770) * fix: persist deletion cancellation ownership before provider updates * test: cover deletion intent commit and account changes * fix: identify deletion-owned Stripe cancellations Reconcile provider metadata before restoring renewal or retaining ownership, reject open cancellation transactions, and log skipped erasure rechecks. Refs thomasluizon/orbit-tickets#1547 (cherry picked from commit a7d1cf2) * test: drop the deprecation assertions the legacy Google route removal supersedes The base merge brought #769's assertions that POST /api/Auth/google and POST /api/Auth/operations/google stay available and deprecated. This carry removes both routes (main's #1528 part 2), so those assertions no longer have a subject. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries one
maincommit intoredesign/mainahead of the rest of the#746carry (orbit-api#768), so the legacy Google auth routes are deprecated onredesign/mainbefore the carry removes them.Part of thomasluizon/orbit-tickets#746 (the
orbit-apimaintoredesign/mainsync).Why a separate pull request
orbit-api#768carries both21f810ff(#753, deprecatePOST /api/Auth/googleandPOST /api/Auth/operations/google) and#752(remove them) in one squash. ItsOpenAPI Breaking-Change Gatecompares againstredesign/main, where the routes are not deprecated yet, and fails withapi path removed without deprecationfor both routes.mainpassed the same gate because#753merged before#752. This pull request repeats that order onredesign/main;orbit-api#768then takes one base merge.Carried
21f810ffDeprecate legacy Google auth routes (thomasluizon/orbit-tickets#1528, part 1) (#753), cherry-picked with-x, applied cleanly. No other change.Test evidence
dotnet build Orbit.slnx: exit 0.dotnet test tests/Orbit.Domain.Tests: 744 passed, exit 0.dotnet test tests/Orbit.Application.Tests: 5,705 passed, exit 0.dotnet test tests/Orbit.Infrastructure.Tests: 3,678 passed, exit 0.Assumptions
Manual steps
deprecatedflag and the controller attribute change.🤖 Generated with Claude Code