[thomasluizon]

Closes thomasluizon/orbit-tickets#262 (ORB-256).

End-date reactivation had helper coverage without exercising the handler's allowance wiring. Add five cases in tests/Orbit.Application.Tests/Commands/Habits/UpdateHabitCommandHandlerTests.cs, using the real handler and domain entities with a stubbed allowance port:

• Clearing and extending the end date each return the exact refused result, preserve completion, end date, due date, title, description and update timestamp, and do not save.
• Both requests reactivate and save when allowance is granted, with exactly one allowance call.
• A title update without reactivation succeeds and records no allowance call, even with a refusing stub configured.

The fixture completes a recurring root habit through Habit.Log. Stubbing the port keeps these tests independent of account plans, configured ceilings and message copy. No production behavior changed, and no defect was exposed. The build regenerated src/Orbit.Api/openapi.json without a diff.

Contract confirmed

Read the production source at starting head e2909b6f: UpdateHabitCommandHandler.Handle uses HabitCeilingLock.ExecuteEntryAsync and HabitLiveRootEntry.FromUpdate. The allowance is Orbit.Domain.Interfaces.IPayGateService.CanCreateHabits(userId, 1, cancellationToken). PayGateService returns Result.Failure(ErrorMessages.HabitLimitReached.Format(maxHabits)); the error is backed by ErrorCodes.HabitLimitReached (HABIT_LIMIT_REACHED). The refusal assertions use that constant and do not assert message text.

PayGateServiceTests.EndDateReactivation_RequiresLiveRootAllowance already has the requested neutral name and arrangement, so that file needs no change. No new external interface fields are read.

Assumptions

• Follow the final verification-budget instruction to leave mutation testing to CI, rather than the earlier instruction to remove and restore the end-date branch locally.

Test evidence

All commands below exited with code 0:

dotnet build Orbit.slnx
19 warnings, 0 errors

dotnet test tests/Orbit.Application.Tests --no-build --filter 'FullyQualifiedName~UpdateHabitCommandHandlerTests|FullyQualifiedName~EndDateReactivation_RequiresLiveRootAllowance'
Passed: 44, failed: 0, skipped: 0

dotnet test tests/Orbit.Domain.Tests --no-build
Passed: 736, failed: 0, skipped: 0

dotnet test tests/Orbit.Application.Tests --no-build
Passed: 5569, failed: 0, skipped: 0

dotnet test tests/Orbit.Infrastructure.Tests --no-build
Passed: 3601, failed: 0, skipped: 0

dotnet test tests/Orbit.Analyzers.Tests --no-build
Passed: 32, failed: 0, skipped: 0

Build and focused tests passed before committing; the broader suites passed after the commit. The normal pre-commit formatting, dash, timelessness, root allowlist and suppression checks passed. The pre-push branch protection hook also passed.

Mutation verification is deferred to CI as required by the final work-order note. No local mutation was run, so there is no unchanged-test result with the branch removed, strengthened-test failure, or restored-branch output to report. The removed-gate regression has not been observed locally.

[thomasluizon]

Guard proof by the orchestrator (the removed-gate run the body says was deferred): at head 7cb806fa, replacing the reactivation predicate in UpdateHabitCommand.cs:47 (state => HabitLiveRootEntry.FromUpdate(state.Habit, state.Update)) with state => false and running dotnet test tests/Orbit.Application.Tests --filter 'FullyQualifiedName~UpdateHabitCommandHandlerTests' exits 1: 5 failed, 37 passed. The four new end-date cases (refused and granted, clear and extend) fail, plus the existing Handle_IsGeneralReactivationAtCeiling_IsRefusedWithoutMutation; the new title-only case passes as it should. The file was restored with git checkout and nothing was committed.

[pullfrog]

✅ No new issues found.

Reviewed changes Reviewed the handler-level end-date reactivation tests and traced their assertions through the allowance gate and domain completion rules.

• Refused reactivation: Clearing and extending the end date both preserve the completed habit's state, return the exact allowance refusal, and do not save.
• Granted reactivation: Both requests reactivate the habit, apply the requested edits, and call allowance and save exactly once.
• Non-reactivating edit: A title-only update succeeds without consulting the refusing allowance stub.
• Verification: All 44 focused handler and end-date allowance tests passed; no production code or API contracts changed. Full-solution and mutation testing were not run during this review.

  ^{｜ View workflow run ｜ Using gpt-6.1-sol ｜ 𝕏}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud