Skip to content

Deploy Checklist: New Expensify 2022-07-25 #10077

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2022-07-25#10077
Assignees
applausebot
Labels
DailyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Jul 25, 2022

Release Version: 1.1.86-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Jul 25, 2022
  2. OSBotify
    assigned
    applausebot
    on Jul 25, 2022
  3. luacmartins
    self-assigned this
    on Jul 25, 2022
  4. mvtglobally
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Jul 25, 2022

  5. OSBotify commented on Jul 25, 2022

    @OSBotify
    OSBotify
    on Jul 25, 2022
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.86-0 🚀

  6. jasperhuangg commented on Jul 25, 2022

    @jasperhuangg
    jasperhuangg
    on Jul 25, 2022
    Contributor

    I believe #10079 is related to a PR that I merged recently. I'm OOO today but will be able to take a look at this first thing tomorrow. Can we take this off the deploy checklist?

  7. luacmartins commented on Jul 25, 2022

    @luacmartins
    luacmartins
    on Jul 25, 2022
    Contributor

    @jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

  8. jasperhuangg commented on Jul 25, 2022

    @jasperhuangg
    jasperhuangg
    on Jul 25, 2022
    Contributor

    @jasperhuangg not sure on what you mean by "take this off the deploy checklist". This seems like a blocker to me. We should either revert the offending PR or find a fix in time for the deploy.

    @luacmartins sorry, that's actually exactly what I meant! Let's go ahead and revert it, I'll take a look into a fix tomorrow.

  9. luacmartins commented on Jul 25, 2022

    @luacmartins
    luacmartins
    on Jul 25, 2022
    Contributor

    Sure, wanna put up a revert? I can review it.

  10. marcaaron commented on Jul 26, 2022

    @marcaaron
    marcaaron
    on Jul 26, 2022
    Contributor

    Reverting #9294 because it is causing the issue here #10085

  11. marcaaron commented on Jul 26, 2022

    @marcaaron
    marcaaron
    on Jul 26, 2022
    Contributor

    #10094 seems related to removing the getBetas() call

  12. marcaaron commented on Jul 26, 2022

    @marcaaron
    marcaaron
    on Jul 26, 2022
    Contributor

    This one #10088 seems related to the same PR we are talking about reverting above (this one). Auto-revert option didn't work so it will need to be reverted and conflicts fixed.

  13. luacmartins commented on Jul 26, 2022

    @luacmartins
    luacmartins
    on Jul 26, 2022
    Contributor

    Thanks for the help @marcaaron!

  14. OSBotify commented on Jul 26, 2022

    @OSBotify
    OSBotify
    on Jul 26, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.86-1 🚀

  15. OSBotify commented on Jul 26, 2022

    @OSBotify
    OSBotify
    on Jul 26, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.86-1 has been deployed to staging 🎉

  16. 12 remaining items

  17. luacmartins commented on Jul 28, 2022

    @luacmartins
    luacmartins
    on Jul 28, 2022
    Contributor

    @mvtglobally

    PR #9677 Retested. Issue is still failing. Do we need to wait for push https://github.com/Expensify/Web-Expensify/pull/34424?

    I don't think we should wait for this, since it's a small UI issue and the Web-E deploy can take another day or two. I'm checking it off. Can we retest this next week?

    PR #9769 is failing due to #9769 (comment) - Any feedback if we can check it off? We are unable to verify.

    I tested this on staging and could see the expensifail.com room. Checking it off
    Screen Shot 2022-07-28 at 12 48 11 PM

  18. luacmartins commented on Jul 28, 2022

    @luacmartins
    luacmartins
    on Jul 28, 2022
    Contributor

    @mvtglobally any updates on the below?

    PR #10092 Android was failing due to #10083. We are double checking now
    and checking #10136 which just got added
    We are also re-testing 3 Blockers as per your steps

  19. luacmartins commented on Jul 29, 2022

    @luacmartins
    luacmartins
    on Jul 29, 2022
    Contributor

    @mvtglobally

    1. I shared the android APK with you on Slack.
    2. Removed the blocker from the issues below since we didn't manage to reproduce them and they only affect beta features:

    Let me know once QA finishes and we are ready to deploy!

  20. luacmartins
    added
    DailyKSv2
    on Jul 29, 2022

  21. mvtglobally commented on Jul 29, 2022

    @mvtglobally
    mvtglobally
    on Jul 29, 2022

    @luacmartins testers can still repro all issues on the build 1.1.86-5.

    Record_2022-07-29-14-33-44_4f9154176b47c00da84e32064abf1c48.mp4
    Image.from.iOS.7.mov
    Record_2022-07-29-14-25-16_4f9154176b47c00da84e32064abf1c48.mp4
    Record_2022-07-29-14-35-39_4f9154176b47c00da84e32064abf1c48.mp4
  22. melvin-bot
    added
    Overdue
    on Aug 1, 2022

  23. melvin-bot commented on Aug 1, 2022

    @melvin-bot
    melvin-botBot
    on Aug 1, 2022

    @luacmartins, @applausebot Whoops! This issue is 2 days overdue. Let's get this updated quick!

  24. luacmartins commented on Aug 1, 2022

    @luacmartins
    luacmartins
    on Aug 1, 2022
    Contributor

    @yuwenmemon here’s the latest checklist. I think QA is still able to reproduce a few issues and based on this thread, we have a potential regression in App performance - https://expensify.slack.com/archives/C01GTK53T8Q/p1659018169624599

  25. melvin-bot
    removed
    Overdue
    on Aug 1, 2022
  26. luacmartins
    removed their assignment
    on Aug 1, 2022

  27. yuwenmemon commented on Aug 1, 2022

    @yuwenmemon
    yuwenmemon
    on Aug 1, 2022
    Contributor

    Sounds good - it looks like we need to start a fire-room as the deploy has been going on for more than 4 days now.

  28. yuwenmemon commented on Aug 1, 2022

    @yuwenmemon
    yuwenmemon
    on Aug 1, 2022
    Contributor

    Localize decimal separator was reverted so I'm checking it off

  29. ctkochan22 commented on Aug 1, 2022

    @ctkochan22
    ctkochan22
    on Aug 1, 2022

    #9423 was mentioned in this comment as being retested, checking off #10077 (comment)

  30. yuwenmemon commented on Aug 1, 2022

    @yuwenmemon
    yuwenmemon
    on Aug 1, 2022
    Contributor

    :shipit:

  31. yuwenmemon
    closed this as completedon Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions