Repository navigation
Deploy Checklist: New Expensify 2023-06-12 #20640
Description
Release Version: 1.3.27-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Fix: 'Link sent!' message is not dynamically updated when changing language preference #19480
- Migrate SignInPage to functional component #19498
- Preventing from copying contents of the Mini Report Action Context Menu #19518
- fix: offline deleted heading styles and link padding #19545
- Fix: Composer crashing and not expanding to full-size on Android #19809
- Fix popover menu anchor alignment prop #19849
- Apply system emoji fonts to all font families #19874
- 17036 — migrate InitialSettingsPage to PressableWithFeedback #19882
- 17033 - migrated HeaderView to PressableWithoutFeedback #19958
- 17037 — migrate BaseAutoCompleteSuggestions to PressableWithFeedback #20003
- 20021 — migrate AddPayPalMePage #20045
- 20023 - migrated ReportActionItemMessageEdit to PressableWithFeedback #20082
- feat: use MenuItem instead of TaskSelectorLink on Task page #20145
- 17035 - migrated WorkspaceInitialPage to PressableWithoutFeedback #20156
- [No QA] Get rid of SetPasswordPage #20174
- Migrate PaymentMethodList from class to functional component #20217
- fix: remove onfido box-shadow when focus:visible is applied #20248
- 17049 - migrate RadioButton to PressableWithFeedback #20250
- refactor attachments carousel actions on web #20261
- Cloudpresser/user details tooltip #20276
- 17056 — migrate Banner to PressableWithFeedback #20290
- Migrate DisplayNamePage.js to function #20334
- fix: Add red border for admin in “Workspace > Members” #20337
- fix: 20214crash when opening the thread image #20338
- Feat: migrate report typing indicator to functional component #20339
- 17032 — migrate ReportHeaderSkeletonView to PressableWithFeedback #20344
- Fix for: Mweb - Workspace - the "Next" button overlaps the input field for specific phone modal (Huawei P10 lite) #20345
- Fix 19232: Use interactive prop inside Task Header #20372
- Update Everything-About-Chat.md #20386
- fix: render error before continue bank account setup button #20406
- Fix page loads infinitely #20407
- Merge tfa and abracadabra modals #20409
- [No QA] Cache node modules in GitHub Actions #20436
- [No QA] Fix pod caching logic #20439
- fix left part of conditional rendering not boolean on QRShare component #20444
- Update expensify-common to support italic style for @here mention #20445
- refactor MoneyRequestParticipantsPage const to function #20453
- Fix: Disable resend code button when offline #20458
- Fix native style warnings #20462
- Refactor BaseValidateCodeForm.js to functional component #20480
- Add a check for Concierge default avatar #20483
- Clean up custom status bar implementation #20487
- [No QA] Fix broken lint #20488
- fix room visibility description #20500
- Modal consistency fix for button colour and cancel text #20503
- Fix Avatar has no tooltip in thread report header and displaying "__fake__" text in WS chat #20504
- Make validate prop optional in Form #20526
- Limit PayPal.me link to 20 chars max #20527
- Use
withPolicyAndFullscreenLoadingin WorkspacesListPage #20543 - Fix user cannot remove the description #20544
- fix: show cursor pointer for option row where no press function is given #20553
- Fix the navigation to chat group member profiles #20612
- Fix App does not navigate to last opened public room in small screen devices after Sign in from a public room link #20654
- Revert "Migrate SignInPage to functional component" #20677
- Revert "fix: offline deleted heading styles and link padding" #20695
- Fix-mweb-chat-cancel-button-must-be-pressed-two-times #20704
Deploy Blockers:
- [$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] Web - New Group - Wrong user details page opens on clicking at display names #20583
- [HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Web - Chat - Cursor on staging link is not pointer #20669
- The first user tooltip is shown at the bottom on group chat #20670
- [HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$1000] profile pic does not update in tooltip in offline mode #20672
- [HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] Not able to sign up with a new account #20676
- [HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$1000] mWeb - Chat - Cancel button must be pressed two times #20682
- [HOLD for payment 2023-06-28] [Hold] Hovering on avatar and hovering on display name shows different pictures #20683
- Chat-After changing time zone, the user does not receive and cann't send messages #20700
- [HOLD https://github.com/Expensify/App/pull/20512 $1000] Web - New tooltip is not displayed over workspace direct chats and general workspace chat name #20716
- [$1000] Chat - Page not found for valid chat with access if clicking deeplink after invalid chat #20722
- [HOLD for payment 2023-06-30] [$1000] Workspace - Error message when trying to access workspace created with different default contact method. #20741
- [HOLD #20473] Web- Chat - No Concierge tooltip in staging public room #20751
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jun 13, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.27-2 🚀
isagoico commentedon Jun 13, 2023
PR #20217 is failing because of issue #12913
OSBotify commentedon Jun 13, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.27-5🚀OSBotify commentedon Jun 13, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.27-5 has been deployed to staging 🎉
OSBotify commentedon Jun 13, 2023
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.3.27-6🚀thienlnam commentedon Jun 13, 2023
Checking off #20682
OSBotify commentedon Jun 13, 2023
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.27-6 has been deployed to staging 🎉
isagoico commentedon Jun 14, 2023
PR #20409 is failing on mWeb because of this issue #20710
isagoico commentedon Jun 14, 2023
Checking off #20276 as #20716 was defined as not a blocker
mvtglobally commentedon Jun 14, 2023
Regression is near completed. We are down to 3%
PR #19545 pending validation on all platforms
PR #20217 is failing with old KI #12913. Repro in prod, so probably not a blocker
Are we ok to check it off? #20250 (comment) and PR #20290 (comment)?
PR #20344 pending validation on all platforms
PR #20406 pending validation on all platforms
PR #20407 is failing #20722. Repro in prod
PR #20409 #20409 (comment)
PR #20654 is failing. Adding issue in a bit
mvtglobally commentedon Jun 14, 2023
@AndrewGable Regression is completed
Pending Blockers:
#20672
#20722
#20741
Latest status
PR #19545 failing #20749. repro in Prod checking off
PR #20217 is failing with old KI #12913. Repro in prod, so probably not a blocker
Are we ok to check it off? #20250 (comment) and PR #20290 (comment)?
PR #20344 Is failing #20755 repro in PROD. Checking off
PR #20406 is failing #20741
PR #20407 is failing #20722. Repro in prod
PR #20409 #20409 (comment)
PR #20654 is failing. Adding issue in a bit
AndrewGable commentedon Jun 14, 2023
Agree 👍
Yes, we are OK to check off
AndrewGable commentedon Jun 14, 2023
#20406 - Seems OK to check off per: #20741 (comment)
AndrewGable commentedon Jun 14, 2023
Let me know when you have issue for #20654, is it reproducible on production?
mvtglobally commentedon Jun 14, 2023
@AndrewGable We did not log the issue a team was trying to get the final result. I posted Additional info here.
#20654 (comment)
pecanoro commentedon Jun 14, 2023
Checking off #20672 since it was tested after deploying a fix and now it's working.
AndrewGable commentedon Jun 14, 2023
Checked off #20654 per #20654 (comment)
AndrewGable commentedon Jun 14, 2023