Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.3.57-5
Compare Changes: production...staging
This release contains changes from the following pull requests:
- refactor: SelectionList multiple selection #22622
- Extract emojis from paste text #23153
- fix keyboard flashing while clicking "Add attachment" #23994
- [UI]-Dropdown Button #24034
- [No QA] Onyx type core data #24054
- migrate native AttachmentPicker to functional component #24364
- Fix: Edit composer moves focus to main composer after press LHN menu item #24481
- fix: popover without overlay changes #24515
- Create SaaStr Demo flow #24535
- Disable Drag & Drop by default #24536
- fix: sync draft and edit status of thread first chat #24544
- [No QA] Allow distance requests to be viewed #24556
- Remove policy expense chat beta #24579
- [No QA] Add details for distance requests in MoneyRequestView #24589
- Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624
- Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630
- Display single waypoint #25161
- [NoQA] Optimistically update receipt state to OPEN when the request is edited #25385
- Add Download Banner to mWeb #25418
- Display Route #25434
- Category MenuItem and CategoryPicker component #25470
- [No QA] Fix require cycle from subscribeToReportCommentPushNotifications #25544
- #25561: apply flex1 to MenuItems titleStyle in MoneyRequestConfirmationList #25593
- Fix "Copy URL to clipboard" not working by long tap #25599
- Remove navigating to assignee page from task header action button #25609
- App allows '÷×' symbols in legal name even though error states that 'Name can only include letters' #25615
- add show link back home on profile page #25642
- Implement backTo param for ProfilePage navigation #25658
- fix: hide the edit modal if request can not be edited #25666
- Show the delete option on transaction thread correctly #25669
- Create Card-Rev-Share-for-Approved-Partners.md #25677
- Edit merchant field of money requests #25702
- fix: allow decimal values without integer in reimbursement amount #25723
- Block emoji reaction on report actions of report with errors #25729
- [No QA][TS migration] Migrate 'NAVIGATORS.js' constant to TypeScript #25746
- Make the merchant field be populated #25794
- [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #25847
- show disabled cursor on checkbox and "Select All" if they are unclickable #25882
- [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921
- [CP Staging] fix(selection-list): scroll to top, cmd enter, tab key #25955
- [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055
Internal QA:
Deploy Blockers:
- [hold for payment 2023-08-30] [$1000] Google icon on sign in page shows overflow horizontal scrolling bars #25797
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [HOLD for payment 2023-08-25] Request money - App on recipient end crashes when receiving money request #25830
- Android - Request money - App crashes when editing Amount twice #25841
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] cursor should display as disabled on select all checkbox even if only non removable members are present #25859
- [HOLD for payment 2023-09-06] [$1000] No animation for Members and Invite Members page #25860
- Request money - Visual issue appear when change Merchant name #25870
- Android - IOU Distance - Map does not zoom in to the selected location on Start point #25871
- Report - App crashed when open a conversation with a specific account #25874
- [$1000] Android - Notifications - Inconsistent appearing of avatar on notification when app is backgrounded #25875
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Workspace- While inviting members, the contact selected is not shown #25877
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Workspace - CMD+ENTER does not work when inviting new members to WS #25878
- [HOLD for payment 2023-09-06] [$1000] There is no scroll bar on members page of a workspace #25879
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Invite member - Incorrect selection of member using Tab key #25883
- [HOLD for payment 2023-10-09] Member - Green highlight on member jumps to other member when selecting member #25884
- [HOLD #301281] [$1000] Web - Missing Default Merchant Statement in Split Bill Details #25885
- Unable to delete a workspace if owner leaves a workspace chat with one of the members #25887
- [HOLD for payment 2023-09-06] [$1000] skeleton ui does not show when contact are loading #25888
- [HOLD for payment 2023-09-20] [$1000] DEV: Share code avatar differs from profile avatar #25889
- [HOLD for payment 2023-09-06] [$1000] [HOLD for payment 2023-09-04] First member remains highlighted on members page #25890
- [HOLD for payment 2023-09-21] Web - Input field not focused on click of back button from Get assistance page #25893
- Workspace - Tooltip is miising on hover in invite members page #25895
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Workspaces - Name highlights on select member on invite page #25896
- IOU - Not able to remove the merchant #25898
- Workspace - There is no separating line for members #25966
- User is unable to authenticate with magic link #25979
- [$500] [HOLD for payment 2023-09-06] Dev - Unable to select a state #25998
- [HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027
- [HOLD for payment 2023-09-20] Web - Profile - Pronouns Displayed Without Performing Search #26074
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
roryabraham commentedon Aug 24, 2023
The following PRs should have been
[No QA], checking them off:These PRs are for ExpensifyHelp (already in production, production QA), checking them off:
OSBotify commentedon Aug 24, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.57-0 🚀
roryabraham commentedon Aug 24, 2023
#25860 is NAB, checking it off
mountiny commentedon Aug 24, 2023
Checking #25830 off, fixed in staging
roryabraham commentedon Aug 24, 2023
#25797 was fixed on staging for the last checklist, I just forgot to remove the deploy blocker label. Checking it off
luacmartins commentedon Aug 24, 2023
Checking off #25870. It's a dupe of #25784 and not a blocker since it's a minor UI thing
roryabraham commentedon Aug 24, 2023
#25871 is behind a beta so NAB, checking it off
roryabraham commentedon Aug 24, 2023
#25879 is NAB, checking it off
mvtglobally commentedon Aug 24, 2023
@roryabraham Can you check this one
#24034 (comment)
mvtglobally commentedon Aug 24, 2023
Also, is it possible to QA #24535 internally?
We are not sure how to pull account IDs in Staging and team is stuck
jasperhuangg commentedon Aug 24, 2023
Checking off #25890 as I don't think we need to be blocking deploy on it.
roryabraham commentedon Aug 24, 2023
So far three PRs have been CP'd:
20 remaining items
roryabraham commentedon Aug 25, 2023
#25979 is not reproducible on staging, checking it off
amyevans commentedon Aug 28, 2023
Demoted #26074 and checked it off
luacmartins commentedon Aug 28, 2023
Checking off #25998. That happened in dev only and we merged the fix - #26045
luacmartins commentedon Aug 28, 2023
Checking off #26027. Fix merged and being CPed. I'll test once it hits staging.
luacmartins commentedon Aug 28, 2023
Just waiting on QA for:
luacmartins commentedon Aug 28, 2023
Tested #26055 in staging. It's a pass. Checking off.
luacmartins commentedon Aug 28, 2023
Down to #25921
mvtglobally commentedon Aug 28, 2023
Checked off #25921
luacmartins commentedon Aug 28, 2023
Checklist is clear. Shipping it.
luacmartins commentedon Aug 28, 2023