Repository navigation
Deploy Checklist: New Expensify 2023-10-02 #28635
Description
Release Version: 1.3.76-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Blur Magic Code input when click outside #24012
- fix(#22204): Toggle label correctly #24199
- Remove unused attachment placeholder code #25557
- fix undo message after delete #25583
- Save queued updates to memory only #25614
- Fix: Wrong currency in request money page after login #25786
- Rewrite to functional component #26079
- Allow Editing Distance Requests #26141
- Chore: migrate index.js class to function component #26374
- Fix: User experienced big delay when posting the messages #26729
- Implement dedicated route for CountryPicker in AddressPage #26742
- Use initialValue in withOnyx and other optimizations for ReportScreen #26772
- [TS migration] Migrate 'EmojiPickerAction.js' lib to TypeScript #26795
- create the Expensify card page #26915
- Fix Sign in- Language preference doesn't persist when user Signs in with google #26948
- Fix: 26339 Workspace - Unable to remove error reported member #26975
- map not loading when online #26998
- [No QA] [TS Migration] Transaction lib #27138
- Bump reanimated to 3.5.4 #27193
- migrate PopoverReportActionContextMenu class to function component #27221
- Hoverable component refactored from class into functional approach #27223
- Highlight linked comment #27227
- fix(selection-list): highlight on lists with 1 section #27246
- Notifications for editing money requests #27299
- [No QA] [TS Migration] Migrate 'openReportActionComposeViewWhenClosingMessageEdit' lib to TypeScript #27312
- [NoQA] [TS migration] Migrate 'CloseAccount.js' lib to TypeScript #27355
- Fix money request header avatar border color does not match header background color #27413
- chore: migrate withKeyaboardState class to function component #27415
- RequestorStep.js: class to functional component refactor #27455
- Fix suggestion menu closes on typing @ at second line #27490
- [No QA] [TS migration] Migrate 'RenameExpensifyNewsStatus.js' lib to TypeScript #27501
- [TS migration] Migrate 'getPlaidLinkTokenParameters' lib to TypeScript #27527
- [No QA][TS migration] Migrate 'getOSAndName' lib to TypeScript #27534
- [No QA][TS migration] Migrate 'ErrorUtils.js' lib to TypeScript #27659
- Fix/26669 lhn logic for paid reports #27700
- Display smartscan errors BELOW the field #27735
- Prevent nested timezone setting #27745
- Move all header buttons to overflow menu #27748
- Fix: Chat - Loader is shown on top of image even after image is loaded in attachment carousel #27751
- fix: 27252 Profile pic gets removed in offline mode #27757
- Selection List refactor phase 3: base #27767
- [No QA] [TS migration] Migrate 'Chronos.js' lib to TypeScript #27770
- fix: prevent transparent suggestion list by using portal #27771
- [No QA][TS migration] Migrate 'UserUtils.js' lib to TypeScript #27778
- [No QA] [TS migration] Migrate 'PusherConnectionManager.js' lib to TypeScript #27781
- 26773-bug-user_is_able_to_delete_default_contact_method #27788
- [TS migration] Migrate 'ReceiptUtils.js' lib to TypeScript #27794
- Fix/27586: Extra spaces between text is not displayed #27822
- Fix/27383: Prevent request money if empty waypoint #27826
- Update Task Report System Messages and LHN Display for Consistency #27827
- Fix 25% opacity in MoneyRequestView and TaskView #27830
- Fixing incorrect message timing display when changing timezones #27838
- Docs: 404 page #27839
- [No QA] [TS migration] Migrate 'ValidationUtils.js' lib to TypeScript #27846
- [No QA] [TS migration] Migrate 'Accessibility' lib to TypeScript #27847
- Fix stacked avatar is transparent when long press on Android #27850
- [No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865
- Feat: Editable billable flag #27875
- Fix Copying Sent Money Report Action text copies a wrong text #27889
- Fix: Receipt scan request container corners are not rounded while it is in progress #27900
- Edit the route of new task page #27909
- Add billable field to Transaction #27910
- Fix duplicate participant name and avatar #27912
- fix: Web - green dot appears even if task is deleted #27915
- App displays waypoint address page briefly on click on Go back to… #27917
- refactor: migrated WalletStatementModal to function component #27934
- [No QA] [TS migration] Migrate 'ApiUtils.js' lib to TypeScript #27935
- Fix: Transition animation does not work for request money page #27947
- #26793: Edit a tag in a money request #27950
- use vertical padding for signInIconButton #27953
- Fix map view attribution text is not visible on hover #27954
- [NoQA] Fix test to prepare for onyx update #27958
- remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace #27983
- fix: Emoji suggestions is not displayed between '~~' & '__'. #27984
- Fix Save button is not at the bottom of the page #27987
- [HelpDot] Add styling for home page and hub page #27988
- The scale control is hidden on the map #28003
- Rate unit page accessed from url #28004
- [No QA] [TS migration] Migrate 'TransactionUtils.js' lib to TypeScript #28005
- [TS migration] Migrate 'ComposerUtils' lib to TypeScript #28008
- fix error for zip code in bank account step #28043
- update spilt regex to fix suggestions issue #28045
- Fix 26829 after logout unsubscribe keyboardshortcut's documented shortcuts #28053
- [HelpDot] Show a section's articles in new page #28100
- [No QA]Fix E2E Performance Regression Tests #28109
- bump expensify-common version to exclude double quote from url #28113
- fix new tab opens when downloading offline #28114
- chore: revert pull 27369 changes #28117
- Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120
- Status UI fixes #28122
- Fix/27165: Only display recent destination if search input is empty #28124
- update get contract method from url when open deep link #28125
- added browser check for setting line height #28126
- 23672-Fixing last word text disappearance on quote messages with links in android #28127
- Don't add optimistic replies to task assignee report #28128
- fix: prevent tab swipe glitches when attempting to select text on the Scan tab #28135
- Limit decimals in select currencies in Money request form #28137
- Fixed inconsistent back button behavior of NewChatSelectorPage #28138
- #26793: show selected tag even if all are disabled #28151
- fix: sync draft and edit status of thread first chat #28154
- Fix: email is not shown in authenticator app #28164
- Fix NotFound page for categories and tags #28165
- Use correct route for workspace invite form #28197
- Fix: App crashes when report ID is wrong bacause of the policy #28199
- Revert "Fix/27383: Prevent request money if empty waypoint" #28208
- Update pending action when we cancel task #28211
- Fix Green drag and drop area #28219
- fix: state gets cleared when selecting the same country #28220
- [Can only be tested after deployed to Staging/Production] Add
/get-assistance/*url to show Smart App Banner #28222 - Create Create-A-Report.md #28223
- [No QA] Improve formatting of routes file #28224
- add useFocus prop missing #28226
- Create Applying Tax to Expenses.md #28227
- Revert PR 27340 #28229
- Create Upload-Receipts for Help site.md #28230
- Ctreate Merge-Expenses.md for Help Site #28233
- Update Create-Expenses.md in Expensify Help #28235
- remove sms domain task preview #28243
- remove PressableWithFeedback wrap button choose file and give permission #28245
- include task status messages in last message text #28248
- fix: can edit private note of archived workspace using URL #28252
- Allow anonymous user to copy url #28261
- fix: prevent requesting for amounts larger than the allowed maximum #28266
- Fix Task shared in admin-only room can be marked done in chat, but not in the task report #28268
- Add Scrollview to page #28270
- fix: add proper fallback route for private notes pages #28273
- Split Bill - Number keeps on changing its initials #28274
- [HelpDot] Policy and domain settings fix subcategories #28275
- Create Indirect-Accounting-Integrations.md #28284
- Update Reimbursements.md #28286
- Adding call to clear key onyxUpdatesFromServer #28290
- Reattempt using OSBotify installation token in actions #28291
- Fix distance request next button while offline #28292
- Fix horizontal padding for lounge access #28293
- fix: save button is disabled in display name page in offline mode #28295
- Fix inconsistent spacing after typing an emoji #28297
- Update and rename Tax.md to Tax Tracking.md #28298
- Bump onyx #28299
- Update User-Roles.md #28300
- Update Vacation-Delegate.md #28303
- [No QA] Revert "Prevent nested timezone setting" #28307
- fixed getCommonSuffixLength compare value #28310
- Fix validation bug in FormProvider #28311
- fix console error on MenuItem #28314
- Fix crash when open currency selector page #28319
- Update Individual-Users.md #28351
- Prevent nested timezone setting #28355
- Update Rippling.md and Greenhouse.md #28356
- Add linking config for search #28360
- Fix/28007: City field is not clear when choosing new country #28362
- [NoQA] Add missing comma at the end of the line to fix lint #28367
- Update Merge-Expenses.md #28369
- Upgrade react-native-key-command version #28370
- Update Create-Expenses.md #28371
- Allow bubbling Enter key press event on Button #28374
- Fix: Status emoji is overlap in report action item #28392
- rerender country and state if visited via deep link #28404
- Update User-Roles.md #28405
- fix: status bar color when modal is visible #28407
- Fix: Regression - Infinite loading in request money page #28410
- Update and rename Account-Access.md to Account-Details.md #28415
- Refocus when clicking on add split button #28423
- Update Scheduled-Submit.md #28428
- Update Global-VaTax.md #28430
- Update Auto-Reconciliation.md #28436
- Update Currency.md #28437
- Update Report-Fields-And-Titles.md #28446
- Update Zenefits.md #28460
- Update Expenses.md #28506
- Fix readFileAsync to extract type also for file upload #28533
- [HelpDot] Redirect old article links to new articles #28556
- Remove unnecessary StatusBar code #28571
- update 'chooseFile' translation in en.ts #28578
- [NoQA] Add small comment about REPORT_METADATA onyx key #28581
- Remove
Mark as completemenu item from threeDotMenuItems for tasks #28582 - fix: Chat - App displays mention suggestion for sometime when we remove spaces before #28583
- Fix LHN display name ellipsis doesn't show tooltip when the text is updated #28598
- Revert "Reattempt using OSBotify installation token in actions" #28612
- [CP Staging] Revert "Hoverable component refactored from class into functional approach" #28642
- Use
Continuefor button copy for camera permissions #28655 - [CP Staging] Revert "Fix: User experienced big delay when posting the messages" #28673
- [CP Staging] fix: pass decimals parameter to validateAmount in MoneyRequestConfirmationList #28685
- [CP Staging] Fix LoginList types #28686
- [CP Staging] fix null coallescing logic #28706
Internal QA:
Deploy Blockers:
- [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - App crash on click of back button #28634
- [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$250] Settings - Green dot appears even though there is no Contact methods #28643
- Request money - Changing the currency crashes the app #28647
- [$500] Thread - "Reply in thread" crashes the app #28648
- [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Chat - New message sent is not showing immediatelly #28649
- [$500] Chat - Messages sent in offline mode appear above the chat history #28651
- Chat - The emoji picker is incorrectly appearing on the LHN side #28652
- Contact methods - Green dot appears on Contact methods row on Profile page #28653
- [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] Chat - No error mesage when trying to send a corrupted file, only red dot in LHN #28654
- [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Attachment-No comment appears with grey text "Uploading Attachment" when upload attachment #28656
- [$500] Task - Canceled task disappears from the conversation #28658
- [No QA]Remove check to only look for blockers when run via
workflow_call#28659 - [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Android- IOU-App crashes when saving the selected date & merchant/date field not shown #28690
- [$500] Android-IOU-In distance request, selecting category and tapping request amount shows error #28693
- [$250] Web - LHN - When you send a message, the conversation moves to LHN #28696
- [$250] Web - Unread marker - Green line does not appear when coming back online #28699
- [$250] Desktop - App Redirection - Blank page is displayed when opening a deep link for Account B profile #28717
- [$250] Distance IOU - 'Recent destination' disappears first then the list in the address field #28719
- [HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Distance - The error message for "Invalid amount" appear when the correct amount is selected #28721
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
mountiny commentedon Oct 2, 2023
checking off the PRs which already were in staging
OSBotify commentedon Oct 2, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.76-0 🚀
mountiny commentedon Oct 2, 2023
[TS migration] Migrate 'getPlaidLinkTokenParameters' lib to TypeScript #27527
[No QA][TS migration] Migrate 'getOSAndName' lib to TypeScript #27534
[No QA][TS migration] Migrate 'ErrorUtils.js' lib to TypeScript #27659
Fix/26669 lhn logic for paid reports #27700
Display smartscan errors BELOW the field #27735
Prevent nested timezone setting #27745
Move all header buttons to overflow menu #27748
Fix: Chat - Loader is shown on top of image even after image is loaded in attachment carousel #27751
fix: 27252 Profile pic gets removed in offline mode #27757
[No QA] [TS migration] Migrate 'Chronos.js' lib to TypeScript #27770
fix: prevent transparent suggestion list by using portal #27771
[No QA] [TS migration] Migrate 'PusherConnectionManager.js' lib to TypeScript #27781
[TS migration] Migrate 'ReceiptUtils.js' lib to TypeScript #27794
Fix/27586: Extra spaces between text is not displayed #27822
Fix/27383: Prevent request money if empty waypoint #27826
Update Task Report System Messages and LHN Display for Consistency #27827
Fix 25% opacity in MoneyRequestView and TaskView #27830
Fixing incorrect message timing display when changing timezones #27838
Docs: 404 page #27839
[No QA] [TS migration] Migrate 'ValidationUtils.js' lib to TypeScript #27846
[No QA] [TS migration] Migrate 'Accessibility' lib to TypeScript #27847
Fix stacked avatar is transparent when long press on Android #27850
[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865
Feat: Editable billable flag #27875
Fix Copying Sent Money Report Action text copies a wrong text #27889
Fix: Receipt scan request container corners are not rounded while it is in progress #27900
Edit the route of new task page #27909
Add billable field to Transaction #27910
Fix duplicate participant name and avatar #27912
fix: Web - green dot appears even if task is deleted #27915
App displays waypoint address page briefly on click on Go back to… #27917
refactor: migrated WalletStatementModal to function component #27934
Fix: Transition animation does not work for request money page #27947
#26793: Edit a tag in a money request #27950
use vertical padding for signInIconButton #27953
Fix map view attribution text is not visible on hover #27954
[NoQA] Fix test to prepare for onyx update #27958
remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace #27983
fix: Emoji suggestions is not displayed between '~~' & '__'. #27984
Fix Save button is not at the bottom of the page #27987
[HelpDot] Add styling for home page and hub page #27988
mountiny commentedon Oct 2, 2023
There is more to be checked off
mountiny commentedon Oct 2, 2023
I have checked off more, I think it should be all of them which were in previous deploys. Also I checked off the help site updates
mountiny commentedon Oct 2, 2023
Found a few more, I thin now it should be all
kavimuru commentedon Oct 3, 2023
@mountiny Regression TR is left with 3%. Team is working on CPs and on couple PRs
#25557 failing with #28654
#28165 failing with #28069
#28219 failing with #28014 ( not fixed in Desktop)
#28273 failing with #27598 (comment)
#28533 failing with #26940 which is a known issue, ok to checking it off?
#28686 This cp has no QA steps. Okay to check it off?
#28404 failing with #27814 (city not popoulated)
mountiny commentedon Oct 3, 2023
I believe this was a pass internally #28236
Checked off couple of the deploy blockers which were confirmed fixed in staging
mountiny commentedon Oct 3, 2023
Checking off:
shubham1206agra commentedon Oct 3, 2023
@kavimuru Can you recheck #28533
I have rechecked this against the latest main. Working fine for me
mountiny commentedon Oct 3, 2023
mountiny commentedon Oct 3, 2023
graphs good and no new crashes
mountiny commentedon Oct 3, 2023
OSBotify commentedon Oct 3, 2023
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
mountiny commentedon Oct 3, 2023