Repository navigation
Deploy Checklist: New Expensify 2021-09-15 #5279
Description
Release Version: 1.0.99-4
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Ensure accounts with a private domain secondary login can create a workspace #5037
- override default anchor style with parent style #5060
- Highlight all errors in VBA flow - Company step #5073
- Removed call option & timezone in report details page for automated accounts #5094
- Added bouncing[IOS]/overScroll Edge[Android] effect to the lists of the app #5136
- Corrected floating button in VBA flow. Now button shows at bottom of each step. #5208
- Update payments page to use Expensify logo for Expensify Card #5216
- Add new job to leave comment to new contributor #5229
- [Deploy Blocker] Changed max length to 11 for alignment issues #5243
- Skip showing create for new users if user already has a workspace #5244
- Redirect NewDot staging links in the same tab just like production links #5248
- Update validate page in VBA flow #5251
- Re-add internationalization beta #5256
- Update CONTRIBUTING.md #5257
- #4902 fix crash #5261
- Update
/requestorto/personal-informationwhen redirected #5264 - Revert PR #5037 #5288
- Add safety net for timezone in DateUtils #5307
- Check isOnfidoSetupComplete in the requestor step to prevent showing it again #5330
- Revert "Skip showing create for new users if user already has a workspace" #5360
Deploy Blockers:
- iOS / Android - Request money page breaks after using 14 digits #5241
- "Add email" button showing incorrectly on a private domain's workspace #5285
- Chat - After switching account from Spanish to English the app still shows in Spanish and no option to change language for gmail accounts #5286
- Chat - New Workspace isn't available for public domain account #5289
- Bank account - Blank validation page displayed #5290
- [HOLD for payment 2021-12-06] [Pay on Tuesday 23rd Nov] Chat - Unable to scroll PDF file more than 2 pages in Preview page before sending #5291
- Blank screen displayed after login #5305
cc @Expensify/applauseleads
Activity
mvtglobally commentedon Sep 15, 2021
starting QA
roryabraham commentedon Sep 15, 2021
Checking off #5229 because we were able to verify that it works as expected.
Julesssss commentedon Sep 16, 2021
Checking off #5291 as it only occurs on one platform and doesn't block the user from sharing PDF files.
francoisl commentedon Sep 16, 2021
I removed the deploy blocker label from #5286 because it's also happening in production, doesn't look like a new bug.
Julesssss commentedon Sep 16, 2021
In order to resolve #5290, I have raised a revert PR here. Once this is merged and on the deploy Checklist, I will mark #5290 off the list.
isagoico commentedon Sep 16, 2021
Regression is finished!
Issues found:
Comments added in PRs:
Thanks
isagoico commentedon Sep 17, 2021
Checking off #5216 (comment)
isagoico commentedon Sep 17, 2021
Checking off #5307 (comment) and #5305 since they were tested and it was a pass 🎉
Julesssss commentedon Sep 17, 2021
#5290 has been resolved as it was already occuring.
roryabraham commentedon Sep 17, 2021
@marcaaron Can you confirm if we are good to check #5330 off on the checklist? Judging by this comment it looks like we are good there?
marcaaron commentedon Sep 17, 2021
Yep tested fine for me.
roryabraham commentedon Sep 20, 2021
Is this checklist blocked on the verification code bug for switching between E.com and NewDot?
isagoico commentedon Sep 20, 2021
Yes, we were unable to complete QA for #5244
bondydaa commentedon Sep 20, 2021
checking off #5244 because we reverted it on #5360 so we could unblock this checklist
Jag96 commentedon Sep 20, 2021
#5244 has been reverted in #5360, CPing to staging. Once its on staging I'll check it off the list and move forward w/ the deploy.
Jag96 commentedon Sep 20, 2021
Staging deploy was a success, checking off #5360. Looks like there aren't any blockers left here so going to close and proceed w/ the prod deploy!
OSBotify commentedon Sep 20, 2021
This issue either has unchecked QA steps or has not yet been marked with the
:shipit:emoji of approval.Reopening!
Jag96 commentedon Sep 20, 2021