Repository navigation
Closed
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.0.75-6
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Contacts import #51018
- fix: distance - share with accountant #51517
- fix: loading indicator display when deleting vague distance Expense #51940
- Refactor IOU.categorizeTrackedExpense function #52221
- Allow invoices with multiple expenses #52556
- Add Chat with setup specialist to the accounting page. #52803
- fix: user lands on previous attachment #53111
- add header description to Concierge chat #53123
- add top padding to LHN wrapper #53296
- cleanup: split filtering & ordering in OptionsListUtils #53371
- Prevent going back to participant page when categorizing #53420
- The central page page is not rendered when resized to narrow and then to wide view again #53466
- fix: App crashes when clicking on search icon while app is loading #53521
- Remove reuseConnection from withPolicy #53597
- [No QA] Update and rename Export-expenses.md to Export-download-expenses.md #53619
- Add submit action #53641
- Fix decimal-pad keyboard input lag on android #53647
- Revert revert moving tasks to admins room for "Manage my team expenses" intent #53661
- [No QA] Update redirects.csv #53673
- Fix pay button after deleting expense #53722
- Fix IOU amount input flicking #53740
- Fix chat isn't scrolled down when deleting attachment #53743
- fix: Quick Action for Scan receipt giving not found page #53747
- fix: change horizontal padding for physical card form default renderer #53755
- add dismiss space for emoji picker when searching #53806
- Update Join-your-company's-workspace.md #53808
- fix: Wrong page when navigating back from access level page #53811
- Fix display not here page if card is deactivated #53835
- [No QA] Update workflow to build and publish to S3 ios adhoc hybrid app #53850
- Fix chunk load error refresh #53861
- [No QA] Add new images for tax exempt help articles #53868
- [NO QA] Revert "Contacts import" #53961
- [No QA] Update en.ts #53965
- Include period at the end of learn more link #53966
- [No QA] Update Export-download-expenses.md #53970
- [CP Staging] [No QA] Fix paths in deploy.yml #54028
- fix: Fully clear the form error #54039
- [CP Staging] Revert "Fix pay button after deleting expense" #54042
- [CP Staging] Fix submit action #54056
- Revert "Fix IOU amount input flicking" #54060
- [CP Staging] Revert "fix: distance - share with accountant" #54076
Internal QA:
- Fix screen briefly flashes Chase feed page after connecting Amex feed and back to expensify #53863 - @mountiny
Deploy Blockers:
- [HOLD for payment 2024-12-25] [HOLD for payment 2024-12-20] [$250] Search - Individual expenses displays "Submit"/"Approve" button when the expenses are grouped #53986
- [HOLD for payment 2024-12-25] Hybrid Android - App crashes on launching #53987
- [Due for payment 2025-02-19] [$250] Track - Amount on the expense preview does not update when track distance expense is submitted #53988
- [HOLD for payment 2024-12-20] Search - Submit button is not disabled in Search when "Prevent self-approvals" is enabled #53989
- [HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat #53990
- [HOLD for payment 2024-12-25] [HOLD for payment 2024-12-20] [$250] Expense - Merchant error message is not cleared after completing the field properly #53991
- [HOLD for payment 2024-12-20] [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes #53992
- [HOLD for payment 2024-12-20] [$250] Track distance - Not here page opens after submitting track distance expense to new workspace #53995
- QAB - No QAB after deleting workspace #54063
- [HOLD for payment 2024-12-20] Track distance - Selected rate is not preserved after returning to category list #54066
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Labels
DailyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
mvtglobally commentedon Dec 12, 2024
@luacmartins for some reason the following 2 PR links lead to 404. Do we need to QA them?
#53747
#51940
izarutskaya commentedon Dec 12, 2024
Regression is at 45% completed.
PRs:
#51018 - Blocked for now #51018 (comment)
#51517 - found issue #51517 (comment) Pending mWeb, Desktop, Android
#52221 - Pending validation mWeb, Android and iOS
#51940, #53747 - Blocked for now. PR links lead to 404 page
#52556 - Pending validation on Android
#52803 - pending validation on mWeb, Desktop, Android, iOs
#53661 - Failing with #53661 (comment)
DB:
#53986
#53987
#53988
#53989
#53990
#53991
#53992
#53995
isagoico commentedon Dec 12, 2024
The following PRs were deleted and are currently being investigated to check what happened:
Going to post in #qa to check if we should check them off or if we should wait till there's an answer from GH.
joekaufmanexpensify commentedon Dec 12, 2024
Checked off #53863
Julesssss commentedon Dec 12, 2024
Checked off #53987
mvtglobally commentedon Dec 12, 2024
Android build issue is resolved. Team is working on the Android slots now too.
Regression is at 80% completed.
luacmartins commentedon Dec 12, 2024
@mvtglobally are you still having issues loading these PRs?
@isagoico what do you mean they were deleted? #53978 (comment)
luacmartins commentedon Dec 12, 2024
Ah just saw the thread in Slack. It seems like GH fixed the issue
tgolen commentedon Dec 12, 2024
I closed #54063 because it sounds to me like it is expected behavior.
mvtglobally commentedon Dec 12, 2024
Regression is at 2% left
PRs:
#53111 - Is failing with #53111. Repro in PROD. Checking off
#53420 - Pending validation on mWeb and Android
#53661 - is failing with #53987, #53999
#53722 - is failing with KI #52999. Checking off
#53755 - Pending validation on Desktop
#53861 (comment)
DB:
#53995
#54066
marcaaron commentedon Dec 13, 2024
I'm going to check off #53861 because it doesn't seem like it can be reliably QA'd and is covering a fairly extreme edge case.
mvtglobally commentedon Dec 13, 2024
Regression is completed
Checking CP and last PR
Julesssss commentedon Dec 13, 2024
Checked off #53995 (comment) as a pass, and the associated CP.
luacmartins commentedon Dec 13, 2024