Deploy Checklist: New Expensify 2021-11-22 #6399

Activity

1. OSBotify

   added

   StagingDeployCash

   on Nov 22, 2021
2. OSBotify

   assigned

   applausebot

   on Nov 22, 2021
3. MelvinBot commented on Nov 22, 2021

   

   MelvinBot

   on Nov 22, 2021

   Contributor

   More actions

   📣 @applausebot You have been assigned to this job by @OSBotify!
   Please apply to this job in Upwork and let us know when we can expect a PR to be ready for review 🧑‍💻
   Keep in mind: Code of Conduct | Contributing 📖

   😄React with 😄4Reacted by parasharrajat, Mir Fahad Talpur, Chirag Chandrakant Salian and Rory Abraham
4. isagoico commented on Nov 22, 2021

   

   isagoico

   on Nov 22, 2021

   More actions

   Lol melvinbot is confused here 😆
   Starting QA 🚀
5. isagoico

   added

   🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging

   on Nov 22, 2021
6. roryabraham commented on Nov 23, 2021

   

   roryabraham

   on Nov 23, 2021

   Contributor

   More actions

   WOW that's a lot of deploy blockers.

   😄React with 😄1Reacted by Marc Glasser
7. isagoico commented on Nov 24, 2021

   

   isagoico

   on Nov 24, 2021

   Last edited by isagoico

   More actions

   Currently testing these CPs in all environments:

   • Revert "Merge pull request #6268 from azimgd/fix-inverted-list" #6441
   • fix: Secondary login page #6433
   • Fix IOU Modal styles. #6417
   • Deep link to add secondary login in OldDot #6319
8. isagoico commented on Nov 24, 2021

   

   isagoico

   on Nov 24, 2021

   Last edited by isagoico

   More actions

   Regression is almost finished! Summary of what we have found so far:

   • Revert "Merge pull request #4085 from Expensify/chirag-revert-3979" #4133 - Is failing because of Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422 and Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
   • Allow spaces and special chars in phone number username #6293 - Was failing because of Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414 (Being retested fix: Secondary login page #6433)
   • Deep link to add secondary login in OldDot #6319 was failing because of "Add work email address" button doesn't show up and text copy is not the correct one  #6439 (being retested atm)

   Comments:

   1. Update Plaid Link Component #6362 (comment) - Resolved

   List of issues found so far:

   • Chat - Empty chat will show a pronoun placeholder #6416
   • [$250] iOS - VBA - Unable to see dates clearly or missing altogether in company /personal info page #6438
   • "Add work email address" button doesn't show up and text copy is not the correct one  #6439
   • Profile - Messaging an account not created will display an unconfirmed time zone #6428
   • [HOLD for payment 2022-02-01] $1000 - IOU - Decimal separator not updated when set to Spanish on some screens #6427
   • Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
   • Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424
   • Chat - LHN does not show [Comment deleted] for the user after deleting the message #6422
   • Chat - Empty chat will show a pronoun placeholder #6416
   • [HOLD for payment 2021-12-13] [HOLD for payment 2021-12-06] IOU - "Request $xx" button appears at the top of the page #6415
   • Profile - Unable to add symbols or spaces when adding phone number as secondary login #6414

   CPs being tested at the moment #6399 (comment).

   Thanks!
9. isagoico commented on Nov 24, 2021

   

   isagoico

   on Nov 24, 2021

   More actions

   Checked off the Deploy blockers that have been fixed and retested. Only deploy blockers left to fix and retest are

   • Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424
   • Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426
   • Android - VBA - User could not add bank account using plaid option #6457
10. isagoico commented on Nov 24, 2021

    

    isagoico

    on Nov 24, 2021

    Last edited by isagoico

    More actions

    Testing these CP atm:

    • fix: newline via updating the count first before marking the messages as read #6459 (Fixes Chat - Green line does not appear when receiving a new message, but appears in the chat when sending a message #6424)
    • remove deleted comment message on new chats #6458 (Fixes Chat - LHN displayed as "comment deleted" for the new user when initiating chat and navigating to LHN  #6426)
11. isagoico commented on Nov 25, 2021

    

    isagoico

    on Nov 25, 2021

    Last edited by isagoico

    More actions

    We found a issue when executing QA for PR #6319 on iOS - #6475 (tagged @luacmartins on PR so he can give it a look)
12. luacmartins commented on Nov 25, 2021

    

    luacmartins

    on Nov 25, 2021

    Last edited by luacmartins

    Contributor

    More actions

    Fix for #6475 is up - #6479

    👀React with 👀1Reacted by Maria Ajmera
13. isagoico commented on Nov 26, 2021

    

    isagoico

    on Nov 26, 2021

    More actions

    Checking off #6479 (comment)! It was a pass 🎉

    🎉React with 🎉1Reacted by Carlos Martins
14. MelvinBot

    added

    MonthlyKSv2KSv2

    on Nov 26, 2021
15. roryabraham commented on Nov 29, 2021

    

    roryabraham

    on Nov 29, 2021

    Contributor

    More actions

    @yuwenmemon @tgolen I'm going to check off #6365, looks like it shouldn't block our deploy here.
16. roryabraham commented on Nov 29, 2021

    

    roryabraham

    on Nov 29, 2021

    Contributor

    More actions

    

    🎉React with 🎉1Reacted by parasharrajat

    ❤️React with ❤️1Reacted by parasharrajat

    🚀React with 🚀1Reacted by parasharrajat
17. roryabraham

    closed this as completedon Nov 29, 2021