Repository navigation
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d26984be66
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@linhvovan29546 I will review this PR since I reviewed the offending one. Thanks. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 120ffb69a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Same here #91932 (comment) 😅 |
|
@ZhenjaHorbach I think we need to add a guard for the 2026-05-28.17-03-06.mp4 |
I think it's better to just filter selfDM transactions inside getChildTransactions( as before main changes) |
|
@ZhenjaHorbach Here are some points where a guard can be added, which codex pointed out to me:
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…or-selfDM-splits [CP Staging] Add production guard for selfDM splits (cherry picked from commit f20b3d5) (cherry-picked to staging by lakchote)
…587539527-1 🍒 Cherry pick PR #91932 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.88-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review for PR #91932 No help site changes are required. This PR adds an The current article at If/when the Split-for-selfDM feature is rolled out to production, a separate docs update can be made at that time to describe the new flow. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.89-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed this PR and no help site changes are required. Summary of the change: This PR adds an Why no docs update is needed:
Once the unreported-expense splits feature is enabled in production (issue #72125), a follow-up PR should update @ZhenjaHorbach, please confirm this assessment — if you believe a help site update is still warranted (for example, to clarify the current selfDM behavior), let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.89-7 🚀
|




Explanation of Change
Fixed Issues
$ #72125
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-05-28.15.55.19.mov