Conversation
Add `visible` field to TableIndex domain model, read the `Visible` column from SHOW INDEXES in MySQL metadata, generate INVISIBLE keyword in index DDL, and add buildAlterIndexVisibility for ALTER INDEX syntax. Frontend: add a "Visible" column to the index editor with a VISIBLE/INVISIBLE toggle, disabled for primary keys, gated to MySQL only. Test fixtures: init.sql, grants.sql, cleanup.sql, README.md under script/test-fixtures/mysql/MYSQL-OBJ-006/. Closes OtterMind#2574
Replace hardcoded INVISIBLE, ALTER INDEX strings with constants SQL_INVISIBLE and SQL_ALTER_INDEX from MysqlSqlConstants.
…ABLE buildAlterIndexVisibility was dead code: a visibility-only change fell through to DROP+ADD, rebuilding the whole index. ALTER TABLE now emits ALTER INDEX ... VISIBLE/INVISIBLE when the modified index differs from the stored one only in visibility (and is not the primary key), and falls back to the rebuild path otherwise.
Add `visible` field to TableColumn domain model, detect "INVISIBLE" from the EXTRA column in information_schema, and generate the INVISIBLE keyword in column DDL via MysqlColumnTypeEnum. Frontend: add a "Visible" column to the column editor with a VISIBLE/INVISIBLE toggle, gated to MySQL only. Test fixtures: init.sql, grants.sql, cleanup.sql, README.md under script/test-fixtures/mysql/MYSQL-OBJ-003/. Closes OtterMind#2571
Replace hardcoded INVISIBLE string with SQL_INVISIBLE constant from MysqlMetaDataConstants in MysqlColumnTypeEnum.
MySQL column grammar requires VISIBLE/INVISIBLE before the COMMENT clause; the previous order produced ERROR 1064 for invisible columns that carry a comment.
Adds a read-only Active Transactions view for the datasource node: - Lists innodb_trx joined with processlist: transaction ID, state, start time, age, isolation level, rows locked/modified, thread ID, user, host, database, and current SQL. - Works on MySQL 5.7 and 8.0; SQL text is null without PROCESS and surfaced as an explicit unavailable state instead of a blank value. - New tree menu entry with a refreshable table dialog, i18n in all five locales, and MYSQL-OPS-002 fixtures (admin vs limited accounts).
…tolerant fallback 1. Add `resolveShellCandidates` method to return available shell candidates based on the operating system 2. Modify `create` method to sequentially try starting shells from the candidate list, automatically falling back to the next on failure 3. Add unit tests to verify shell candidate resolution and exception scenarios 4. Add compatibility handling for scenarios where enterprise security software blocks the default shell
…igurable default shell and improved shell candidate resolution - Introduce DEFAULT_SHELL_PROPERTY configuration property for setting the default shell - Add processFactory factory method to support custom process creation logic - Refactor create method to accept pre-resolved shell candidate list - Extract PtyProcess startup logic into a separate startProcess method - Add proper argument configuration for PowerShell and CMD commands (-NoLogo, -NoExit, -Command, etc.) - Improve shell candidate resolution order on Windows (pwsh → PowerShell → cmd) - Add support for zsh and bash colored prompts - Add test helper methods to reset factory and event publisher state - Add comprehensive unit tests covering shell configuration and failover scenarios - Change inner classes and enums to public to support external access - Add command parser interface to support custom command lookup logic
- route DM SQL through the DM command executor - add dedicated DM lexer and parser support - retrieve execution plans through DmdbConnection.getExplainInfo - preserve SQL type, metrics, streaming, and error behavior - cover explicit EXPLAIN, Explain actions, cancellation, and driver isolation Fixes OtterMind#2762
fix(dm): support EXPLAIN execution plans
…erformance perf(mysql): avoid full parse for ordinary completion scripts
refactor(terminal): refactor terminal shell startup logic with fault-tolerant fallback
…-column-2571 feat(mysql): invisible column management for MySQL 8.0.23+
…edit-actions fix(result): stabilize sorting and edit actions
…active-transaction-2595 # Conflicts: # chat2db-community-client/package.json
…-theme-accent fix(workspace): smooth panel resizing and restore theme accents
…ansaction-2595 feat(mysql): active InnoDB transaction inspection (OtterMind#2595)
HandSonic
force-pushed
the
fix/view-table-paging-settlement
branch
from
September 3, 2026 08:35
f9d6e59 to
262fa60
Compare
…-expiration fix(redis): persist no-expiration TTL updates
# Conflicts: # chat2db-community-client/package.json # chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.test.ts # chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.ts
…atest-request fix(frontend): ignore stale account grants
HandSonic
force-pushed
the
fix/view-table-paging-settlement
branch
from
September 3, 2026 21:08
262fa60 to
d5aac09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Table-browser paging treated a
success=falseresult as completed data and replaced the last confirmed page. Desktop cancellation resolved as success without republishing that confirmed page, leaving an optimistic page number beside old rows. This change keeps a confirmed result in the paging state, rejects failed Web/Desktop results through the existing error path, and republishes a clean confirmed clone on cancellation.Affected surfaces
Verification
Risk and compatibility
Reviewer map
viewTablePagingModel.reduceViewTablePagingEvent, thenuseViewTablePaging.executePage.d5aac0924f22cc422e25272dc2530ac97b05ea36; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.
Latest-main revalidation (2026-09-04)