Skip to content

Fix scheduler crash when the Kafka event producer plugin is enabled - #72138

Closed
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-kafka-event-producer-session-detach
Closed

FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-kafka-event-producer-session-detach

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • With [kafka_event_producer] dag_run_events_enabled = True, the scheduler crashes with sqlalchemy.orm.exc.DetachedInstanceError when more than one Dag run is queued.
  • The DagRun listeners run inside the scheduler's own transaction. It moves queued Dag runs to RUNNING.
  • Building the Kafka producer resolves the Kafka connection. On the scheduler that means MetastoreBackend.get_connection, which is decorated with @provide_session. create_session() is thread-scoped, so on the scheduler's thread it reuses the scheduler's own session and closes it on exit.
  • The first Dag run in _start_queued_dagruns passes. the second crashes on dag_run.dag_id.

How

  • Producer construction moves into _build_producer, which runs on a single-use ThreadPoolExecutor. settings.Session gives out one session per thread, so the connection lookup gets a session of its own and leaves the caller's transaction alone.

Verification

  • uv run --project providers/apache/kafka pytest providers/apache/kafka/tests/unit
  • breeze shell --integration kafka --backend postgres --db-reset, then pytest providers/apache/kafka/tests/integration/apache/kafka/plugins/test_event_producer.py --integration kafka.

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @FrankYang0529 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers closed because of open PR limit Closed as a one-time step of introducing the open pull request limit provider:apache-kafka

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants