Repository navigation
Support team-scoped secrets in LocalFilesystemBackend - #72626
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
530ff28 to
7343cc6
Compare
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
multi-team.rstsays the local filesystem secrets backend is team-aware. However,LocalFilesystemBackend.get_connection()andget_variable()acceptteam_namebut never use it, so every team gets the same global value and there is no way to define a team-scoped entry in the file.airflow/airflow-core/docs/core-concepts/multi-team.rst
Line 106 in 123b1be
How
<team>___<id>key in the connections or variables file holds that team's value. The lookup tries the team key first and falls back to the plain key.___is the separator the environment variables backend already uses.[core] multi_teamoff, nothing changes: the backend matches keys verbatim.Verification
uv run --frozen --project airflow-core pytest airflow-core/tests/unit/always/test_secrets_local_filesystem.pyWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.