Repository navigation
Fail Gemini batch job operators when the job does not succeed - #73029
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Why
JOB_STATE_FAILED,JOB_STATE_EXPIRED, orJOB_STATE_CANCELLED,GenAIGeminiCreateBatchJobOperatorandGenAIGeminiCreateEmbeddingsBatchJobOperatorhandle it differently depending on the mode:deferrable=True: the trigger sends an error event andexecute_completeraisesAirflowException. The task fails, and downstream tasks do not run.deferrable=Falsewithwait_until_complete=True:_wait_until_completeonly logs an error and returns the job.execute()then returns normally, so the task succeeds and downstream tasks run.How
_wait_until_completeraisesRuntimeErrorwith the job name and final state when the job did not succeed.Verification
uv run --frozen --project providers/google pytest providers/google/tests/unit/google/cloud/operators/test_gen_ai.pyWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.