Repository navigation
Fix flaky test_trigger_log in triggerer job tests - #72919
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
0dcb14b to
af016e6
Compare
|
Hello @FrankYang0529 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
|
I have put one question in #73759 (comment), before this is merged, if we can stop the nonstop logging at the source rather than working around the symptom? |
@subhramit Thanks for the suggestion. I reply in #73759. |
Andrushika
left a comment
There was a problem hiding this comment.
LGTM. Hi @shahar1 could we merge this please? The same failure keeps crashing CI. Thanks!
test_trigger_logfails intermittently on CI. The test calls_service_subprocess(0.1)30 times before checking stdout. The forked runner inherits the test'stime.monotonicpatch, so its watchdog logs nonstop ahead of the status lines. The supervisor reads at most 4096 bytes of runner logs per call. If the runner starts slowly, or the supervisor is briefly busy, the 30 calls run out before the status lines are read. Sample run:This fix changes the call 30 calls to 300 like #70941.
uv run --project airflow-core pytest airflow-core/tests/unit/jobs/test_triggerer_job.pyWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.