Skip to content

Fix flaky test_trigger_log in triggerer job tests - #72919

Merged
shahar1 merged 1 commit into
apache:mainfrom
FrankYang0529:fix-flaky-test_trigger_log
Sep 27, 2026
Merged

shahar1 merged 1 commit into
apache:mainfrom
FrankYang0529:fix-flaky-test_trigger_log

Conversation

@FrankYang0529

@FrankYang0529 FrankYang0529 commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

test_trigger_log fails intermittently on CI. The test calls _service_subprocess(0.1) 30 times before checking stdout. The forked runner inherits the test's time.monotonic patch, so its watchdog logs nonstop ahead of the status lines. The supervisor reads at most 4096 bytes of runner logs per call. If the runner starts slowly, or the supervisor is briefly busy, the 30 calls run out before the status lines are read. Sample run:

This fix changes the call 30 calls to 300 like #70941.

  • uv run --project airflow-core pytest airflow-core/tests/unit/jobs/test_triggerer_job.py

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 force-pushed the fix-flaky-test_trigger_log branch from 0dcb14b to af016e6 Compare September 11, 2026 13:53
@FrankYang0529
FrankYang0529 marked this pull request as ready for review September 11, 2026 14:47

@aaron-y-chen aaron-y-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @FrankYang0529 - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 30 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@subhramit

Copy link
Copy Markdown
Contributor

I have put one question in #73759 (comment), before this is merged, if we can stop the nonstop logging at the source rather than working around the symptom?

@FrankYang0529

Copy link
Copy Markdown
Member Author

I have put one question in #73759 (comment), before this is merged, if we can stop the nonstop logging at the source rather than working around the symptom?

@subhramit Thanks for the suggestion. I reply in #73759.

@ColtenOuO ColtenOuO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Andrushika Andrushika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hi @shahar1 could we merge this please? The same failure keeps crashing CI. Thanks!

@shahar1
shahar1 merged commit f2fae8c into apache:main Sep 27, 2026
222 checks passed
@FrankYang0529
FrankYang0529 deleted the fix-flaky-test_trigger_log branch September 27, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Triggerer closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants