Repository navigation
Forbid blind scope drop and re-arguing settled instructions - #197
Open
mikeangstadt wants to merge 7 commits into
Open
mikeangstadt wants to merge 7 commits into
mikeangstadt wants to merge 7 commits into
Conversation
Update to the latest model
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reviewers were producing feedback whose effect was to defer a change's own deliverable, and agents were treating already-settled operator decisions as open for re-argument. Adds to every reviewer surface: a settled instruction from the operator is not open for re-argument; review against it rather than reopening it. And never give feedback whose effect is to postpone the thing the change exists to do. Adds the blind-scope-drop rule: deferring or skipping work is not a viable alternative in the presence of contention. Contention gets resolved, not routed around by shrinking the work. Measured on symphony-alpha PR #7021: a lane computed the canonical ratio at both producers, declined to wire it into the production selectors, and filed a ticket. Both stated blockers were false — the cited PR had already merged and the other PR's file overlap was empty. It would have merged green without doing what its title said.
Collaborator
|
Beginning a code-review. Please allow time for me to finish before merging the PR |
shafty023
reviewed
Sep 11, 2026
shafty023
reviewed
Sep 11, 2026
shafty023
reviewed
Sep 11, 2026
shafty023
reviewed
Sep 11, 2026
Collaborator
|
Beginning a code-review. Please allow time for me to finish before merging the PR |
Collaborator
|
Code review complete. Approval was withheld because existing inline comments already cover the actionable concerns. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mikeangstadt
added a commit
that referenced
this pull request
Nov 3, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Review request: Lint, Type Check and Tests pass on the head, there are 0 unresolved threads, and the branch merges cleanly with |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applied to
code-reviewer,code-review-guidelines,code-review-worker, the GitHub review prompt, andpr-reviewer.Why
symphony-alpha PR #7021: a lane computed
canonicalLocPerDollarcorrectly at both producers, then declined to wire it into the production selectors — the PR's entire headline — and filed a follow-up ticket instead. Both stated blockers were false: the PR it cited as colliding had already merged, and the other PR's file overlap was empty. The copy rewrite it called a 'product decision' was a truthfulness requirement, since that sentence described the very denominator the PR changed. It would have merged green without doing what its title said.Test plan