Skip to content

Forbid blind scope drop and re-arguing settled instructions - #197

Open
mikeangstadt wants to merge 7 commits into
mainfrom
chore/forbid-blind-scope-drop
Open

mikeangstadt wants to merge 7 commits into
mainfrom
chore/forbid-blind-scope-drop

Conversation

@mikeangstadt

Copy link
Copy Markdown
Collaborator

Summary

  • Blind scope drop is never an option. Deferring or skipping work is not a viable alternative in the presence of contention — a file another change is editing, a merge conflict, a reviewer objection, an unclear owner. Contention gets resolved; the work does not get shrunk.
  • A settled instruction from the operator is not open for re-argument. Reviewers now review against a recorded decision rather than reopening it, and do not raise its absence as a finding. A genuinely new conflict is stated once, separately, and does not block the change.
  • No reviewer feedback may have the effect of deferring a change's own deliverable. Asking for work outside the change's purpose is legitimate; asking the author to postpone the thing the change exists to do is not.

Applied to code-reviewer, code-review-guidelines, code-review-worker, the GitHub review prompt, and pr-reviewer.

Why

symphony-alpha PR #7021: a lane computed canonicalLocPerDollar correctly at both producers, then declined to wire it into the production selectors — the PR's entire headline — and filed a follow-up ticket instead. Both stated blockers were false: the PR it cited as colliding had already merged, and the other PR's file overlap was empty. The copy rewrite it called a 'product decision' was a truthfulness requirement, since that sentence described the very denominator the PR changed. It would have merged green without doing what its title said.

Test plan

  • Documentation/prompt change only; no executable code path is touched.
  • Verified each target file carries the new section and that no pre-existing untracked files in the working tree were swept into the commit.
  • CI is the authoritative gate.

mikeangstadt and others added 3 commits May 18, 2026 08:49
Update to the latest model
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reviewers were producing feedback whose effect was to defer a change's own
deliverable, and agents were treating already-settled operator decisions as open
for re-argument.

Adds to every reviewer surface: a settled instruction from the operator is not
open for re-argument; review against it rather than reopening it. And never give
feedback whose effect is to postpone the thing the change exists to do.

Adds the blind-scope-drop rule: deferring or skipping work is not a viable
alternative in the presence of contention. Contention gets resolved, not routed
around by shrinking the work.

Measured on symphony-alpha PR #7021: a lane computed the canonical ratio at both
producers, declined to wire it into the production selectors, and filed a ticket.
Both stated blockers were false — the cited PR had already merged and the other
PR's file overlap was empty. It would have merged green without doing what its
title said.
@shafty023

Copy link
Copy Markdown
Collaborator

Beginning a code-review. Please allow time for me to finish before merging the PR

Comment thread plugins/code/agents/code-reviewer.md Resolved
@shafty023

Copy link
Copy Markdown
Collaborator

Beginning a code-review. Please allow time for me to finish before merging the PR

@shafty023

Copy link
Copy Markdown
Collaborator

Code review complete. Approval was withheld because existing inline comments already cover the actionable concerns.

mikeangstadt added a commit that referenced this pull request Nov 3, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mikeangstadt

Copy link
Copy Markdown
Collaborator Author

Review request: Lint, Type Check and Tests pass on the head, there are 0 unresolved threads, and the branch merges cleanly with main. The ruleset needs one approving review. Members of @closedloop-ai/engineering, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants