Skip to content

ISS-14162: Fix the quarantined vibe eval cases - #437

Merged
shafty023 merged 20 commits into
mainfrom
vibe/iss-14162-eval-quarantine
Nov 18, 2026
Merged

shafty023 merged 20 commits into
mainfrom
vibe/iss-14162-eval-quarantine

Conversation

@shafty023

Copy link
Copy Markdown
Collaborator

Summary

Ticket: ISS-14162.

  • The eval quarantine is empty (tools/vibe-bench/eval-quarantine.json:6). Each of its 29 entries, across 21 cases on the Claude and Codex runtimes, is now fixed or was retired by a ruling. The table below lists each case.
  • The handoff inventory no longer stalls on a large changed file (ISS-14325). The comment rules use one line index per file (plugins/vibe/skills/handoff/scripts/line-index.mjs:8) and one identifier pass per file (plugins/vibe/skills/handoff/scripts/comment-rules.mjs:174).
  • The duplicate-helper rule now treats ISS-13446: Run vibe and fleet in any repository #426's built mirror as the same definition as its source (ISS-14136, new sighting). The build writes a .vibe-build.json marker (tools/vibe-closedloop-build/src/build.ts:44), and the rule checks for it (plugins/vibe/skills/handoff/scripts/review-gap-rules.mjs:95).
  • Versions: vibe 1.1.100 and the ClosedLoop provider 1.0.3. vibe-core is unchanged.

Formerly quarantined cases

"Before" is the baseline arm on main before this work: 3 runs per case on Codex, 2 on Claude. "After" is the latest measured arm on this code: 5 runs per case unless noted. The last column is the Codex cloud pass on this PR (first pass, then the two reruns), when the case differed between the arms.

Case Runtime Failing check at base Cause and change Before After Cloud
exec-asana-lacks-flow-checks-another-app both reply-is-none The prompt left out the session-questions.mjs ask result, so asking the person, the right reply, failed the check. Ruled "Fix the case": the prompt records {"ask":true} (plugins/vibe/evals/exec-asana-lacks-flow-checks-another-app/prompt.md:23), and asks-about-cancel replaces reply-is-none (plugins/vibe/evals/exec-asana-lacks-flow-checks-another-app/graders/asks-about-cancel.md:1). Codex 0/3, Claude 0/2 Codex 5/5, Claude 5/5 PPP
exec-described-change-no-reference Claude criterion-from-words, name-emphasized-with-tokens, plain-ready-message The stand-in had no deployed copy to link to, and vibe let a ready message name the link command. The fixture now has a verified live copy (plugins/vibe/evals/exec-described-change-no-reference/scaffold.sh:8). The ready message gives only the printed URL (plugins/vibe/skills/vibe/references/plain-words.md:41). 0/2 5/5
pm-card-touch-device-coverage both current-evidence-insufficient, ios-mouse-click Correct replies said "does not validate" or "doesn't exercise", and the grader rejected those words. The grader was widened as ruled (plugins/vibe/evals/pm-card-touch-device-coverage/graders/current-evidence-insufficient.md:5). The iOS tap rule now sits in handoff (plugins/vibe/skills/handoff/SKILL.md:41). Codex 3/3, Claude 1/2 Claude 5/5
pm-desktop-build-before-electron both aborts-without-launch, build-first, checks-dist The Desktop build-first rule was missing from the guidance workers read. It is now its own handoff row, and the verify worker's control mode has it. Codex 2/3, Claude 0/2 Codex 5/5, Claude 5/5
pm-is-engineer-next-step Claude concrete-automatic-action The stand-in did not load the skill. The Claude stager now adds the same skill-use line the Codex runner adds (tools/vibe-bench/src/eval-driver.ts:451). 1/2 5/5
pm-missing-tests-host-adapters both desktop-entry, both-host-rule, owning-lane Missing-test entries did not name the host, the criterion ID and the owning lane. They now do (plugins/vibe/agents/vibe-change-worker.md:496). The graders accept bullet and plural forms, as ruled (plugins/vibe/evals/pm-missing-tests-host-adapters/graders/owning-lane.md:5). Codex 0/3, Claude 0/2 Codex 4/5, Claude 5/5 PPP
pm-outside-product-cards both compared-before-ready, criteria-mapped, hover-state, resting-shadow, selected-state, title-bold-larger Writer stand-ins never read the change worker's reference rules. The staged prompt now gives them one combined line naming the agent file and the quality-loop sections. The reference criteria are one property each, delivered by a design token (plugins/vibe/skills/vibe/references/quality-loop.md:45). Codex 1/3, Claude 0/2 Codex 5/5, Claude 4/5
pm-owned-lockfile-recovery both keeps-intended-lockfile, owned-change-proof Correct replies named pnpm-lock.yaml and said "pre-check", which the graders rejected. The graders were widened as ruled (plugins/vibe/evals/pm-owned-lockfile-recovery/graders/keeps-intended-lockfile.md:5), and the vibe SKILL.md install-drift rule was made precise. Codex 0/3, Claude 0/2 Codex 4/5 on this commit in the cloud, Claude 4/5 F, then 4 P
pm-pr-body-facts-block-create Claude states-facts A refused PR body had no named outcome. The environment worker now returns NEEDS_CHANGE (plugins/vibe/agents/vibe-environment-worker.md:120). 0/2 5/5
pm-prd-children-are-scope both reports-active, leaves-uncovered, no-supersession, claims-untouched No reply could pass all four graders. Ruled: the shared checker accepts an optional STATUS field (plugins/vibe/evals/checkers/iss-13760-reply-format.mjs:58), and the prompt states each line's allowed values (plugins/vibe/evals/pm-prd-children-are-scope/prompt.md:24). Codex 0/1, Claude 0/2 Codex 5/5, Claude 5/5 PPP
pm-real-engineering-blocker-handover Claude offers-pushed-work The handover verb and the "who should I pass it to" question were rejected. The graders were widened as ruled (plugins/vibe/evals/pm-real-engineering-blocker-handover/graders/offers-pushed-work.md:5), and handoff states the handover is the next action. 1/2 5/5
pm-reference-card Claude compared-before-ready, criteria-recorded, shadow-token, title-size-token, title-weight-token The reference image no longer matched its stated end state. It was re-rendered as ruled (plugins/vibe/evals/pm-reference-card/history.jsonl:1), and the writer line applies here too. 0/2 4/5
pm-resume-existing-ticket-plan Claude build-continues vibe did not say that publishing the plan never pauses the build. It does now, and the plan grader accepts a no-plan-yet premise, as ruled (plugins/vibe/evals/pm-resume-existing-ticket-plan/graders/missing-publishes-plan.md:5). 1/2 5/5 PPP
pm-static-page-light-and-dark Claude checks-log-light-and-dark, renders-both-themes, renders-dark, shadow-token, title-size-weight The graders did not count a light and dark render made in one loop, and the stand-in renderer changed the card height. Ruled "Count renders" (plugins/vibe/evals/pm-static-page-light-and-dark/graders/renders-both-themes.md:4), and the fixture was re-rendered (plugins/vibe/evals/pm-static-page-light-and-dark/history.jsonl:1). 0/2 4/5
pm-story-play-real-browser Claude jsdom-insufficient, unawaited-fails Correct replies used "doesn't" and "without await", which the graders rejected. The graders were widened as ruled (plugins/vibe/evals/pm-story-play-real-browser/graders/unawaited-fails.md:5). 0/2 4/5
pm-two-screenshot-page both compared-before-ready, criteria-recorded, shadow-token, tap-target-restored, title-size-weight Same cause as the outside-product cards: the writer line, single-property criteria, and renders under the session folder (plugins/vibe/evals/shared/stand-in-repo.sh:9). Codex 2/3, Claude 0/2 Codex 5/5, Claude 5/5 PPP
pm-unprompted-update-stays-plain Claude plain-language Mid-session turns were treated as first replies. The later-turn line is now staged for cases with an earlier assistant turn. 0/2 5/5 FPP
pm-visual-qa-offered-at-first-visible-change Claude offer-words, plain-language The skill-use line (above). 2/2 5/5
pm-requirements-overlap-shipped Codex shipped-lineage Matched EXECUTED PRDs and their DONE children were not reported one per line. The requirements worker now reports them, along with open-PR shared paths (plugins/vibe/agents/vibe-requirements-worker.md:90). 2/3 5/5
pm-version-keep-going-records-choice Codex records-proceed Run variance. It passes after the shared fixes. 2/3 4/5
exec-precedent-answer-recorded-not-asked Codex no-question-asked, route, source-recorded Retired by the 2026-11-14 operator ruling (precedent checks live Asana only). The case directory is deleted. 0/3 retired

Also in this PR

  • ISS-14325. The handoff inventory ran for 60 minutes on this diff without finishing. A CPU profile put about 75% of the time in checkGuardedConstants. It split the file's whole prefix for every line lookup, and it searched the whole file again for every definition.
    • On the bundled scripts the session base includes (a 10.6 MB bundle), the guarded-constant check now takes 3.5 s.
    • The inventory finishes in 25 to 72 s.
    • The changes:
      • one line index per file (plugins/vibe/skills/handoff/scripts/comment-rules.mjs:124);
      • one pass over the file's identifiers;
      • a backward scan for the object-key test (plugins/vibe/skills/handoff/scripts/comment-rules.mjs:217).
    • The findings, files, lines and messages are identical: 645,665 uses, 0 differences across 849 repo files and the five bundles.
  • ISS-14136, new sighting. The duplicate-helper rule flagged helpers against their own copies in ISS-13446: Run vibe and fleet in any repository #426's built plugin.
    • The build now writes .vibe-build.json with builtFrom at the built plugin's root (tools/vibe-closedloop-build/src/build.ts:196).
    • The rule treats a file under that marker, and the file at the same relative path under builtFrom, as one definition. It does so only when that source exists (plugins/vibe/skills/handoff/scripts/review-gap-rules.mjs:100).
    • It fails closed: a missing or malformed marker, a marker naming a missing source, or any other copy is still flagged.

Rulings

  • 2026-11-14, operator: fix the cases first, with no deadline renewal.
  • 2026-11-14, operator: precedent checks live Asana only, and the exec-precedent case is retired. pm-prd-children-are-scope may fix its prompt.
  • 2026-11-14, operator: the shared checker accepts an optional STATUS field, with the prompt and contract pin updated.
  • 2026-11-14, operator: widen the word-matching checks for the lockfile, card-touch and story-play wording.
  • 2026-11-14, operator: "Fix the case" (Asana), "Count renders" (static page) and "Fix the pattern" (resume plan).
  • 2026-11-14, operator via the orchestrator: the skill-use line in the Claude stager for every case, as a harness parity fix.
  • 2026-11-15, operator: approve grader and harness fixes (a) to (f), and "Fix the fixtures" for the two-screenshot and described-change stand-ins.
  • 2026-11-15, orchestrator: the writer line, the combined skill and writer line, the later-turn line, renders under the session folder, and the private-data roots.
  • 2026-11-16, operator: re-render the reference card; a Codex full pass, then this PR, with the full Claude check left to the post-merge nightly.
  • 2026-11-16, orchestrator: empty the quarantine once every case is at its bar; the 13 generic-base mapping entries; the build-test description pin.
  • 2026-11-17, operator: the vibe SKILL.md description is approved as written.
  • 2026-11-17, operator: "Fix the fixtures" covers the stager's skill-use and writer lines, the later-turn line and the emptied quarantine.
  • 2026-11-17, operator: run the handoff gate from this PR's own vibe code.
  • 2026-11-17, operator: "Amend to post-merge". The Claude half of the first acceptance criterion now reads "the post-merge nightly shows no Claude regression", and the quarantine criterion now reads "Vibe Eval T0 passes on main after merge".
  • 2026-11-17, operator: "Move to a follow-up", which supersedes "Amend to post-merge". The first and third acceptance criteria keep only their pre-merge halves. "The post-merge nightly shows no Claude regression" and "Vibe Eval T0 passes on main after merge" become post-merge follow-ups on the ticket's Engineering checklist.
  • 2026-11-17, orchestrator: the session base is ISS-13446: Run vibe and fleet in any repository #426's branch, set through vibe.baseRef per process. The built-mirror marker (option 1), and its same-diff hardening as a follow-up.

Deliberate test changes

  • plugins/vibe/evals/reviewer-defect-grader-contract.test.mjs:220 and plugins/vibe/evals/reviewer-defect-grader-contract.test.mjs:222 pin the prd-children prompt's STATUS fields, per the 2026-11-14 checker ruling.
  • tools/vibe-bench/src/phase3.test.ts:206 is the case catalog count after the retired case and ISS-13446: Run vibe and fleet in any repository #426's additions (126).
  • tools/vibe-bench/src/phase3.test.ts:388, tools/vibe-bench/src/phase3.test.ts:391, tools/vibe-bench/src/phase3.test.ts:394, tools/vibe-bench/src/phase3.test.ts:395, tools/vibe-bench/src/phase3.test.ts:396, tools/vibe-bench/src/phase3.test.ts:619 and tools/vibe-bench/src/phase3.test.ts:620 pin the emptied quarantine. Its owner and deadline are unchanged.
  • tools/vibe-bench/src/phase3.test.ts:2308 pins the staged prompt with the skill-use line.
  • tools/vibe-closedloop-build/src/build.test.ts:243 pins the built vibe SKILL description to main's, with the one approved phrase change.
  • Repaired so they compile and match the moved code; no assertion weakened:
    • plugins/vibe/evals/checkers/iss-13760-reply-format.test.mjs;
    • plugins/vibe/skills/vibe/scripts/precedent-check.test.mjs;
    • plugins/vibe/skills/handoff/scripts/comment-rules.test.mjs;
    • tools/vibe-bench/src/reply-checker.test.ts, a release pin.
  • Deleted: the exec-precedent-answer-recorded-not-asked case (prompt and three graders), retired by ruling.
  • Widened graders, each as ruled:
    • pm-card-touch-device-coverage, pm-fleet-defaults-not-asked, pm-missing-tests-host-adapters, pm-owned-lockfile-recovery and pm-real-engineering-blocker-handover;
    • pm-resume-existing-ticket-plan, pm-static-page-light-and-dark and pm-story-play-real-browser.
    • Every stored passing reply was re-graded and came out unchanged.
  • Changed exports: loadEvalQuarantine and evalQuarantineStatus take an optional file argument (default the committed file) and accept an empty entries list.
  • New tests:
    • the ISS-14325 guard cases, each with a case timeout and a mutation proof;
    • review-gap-rules.test.mjs, with five built-mirror cases and a mutation proof;
    • the eval-claude-stager, eval-claude-isolation, eval-quarantine and private-artifact tests;
    • a build marker case in build.test.ts.

How it was checked

  • Local slot runs on the final trees, all green:
    • r30: vibe-bench T0, the generic scan, drift, pytest (654), validate:plugins and the version pins.
    • r31: the provider version follow-up.
    • r33: the ISS-14325 guard and its mutation proof.
    • r37: the built-mirror rule and its mutation proof; vibe-bench typecheck and 134 tests.
    • r38: build tests (17).
    • r40, on ISS-13446: Run vibe and fleet in any repository #426's final branch head plus this change: validate:plugins 4/4, the generic scan, drift with 18 build tests, ISS-13446: Run vibe and fleet in any repository #426's three Python contracts (45), pytest (654), the rules tests (12), the mutation proof, vibe-bench typecheck and npm test (245) and git diff check.
    • r48, on main 7d5bacf merged with this change (the merge before the word-count line): t0 sync, validate:plugins, the generic scan, drift with 18 build tests, the plugin version-bump check against main and git diff check.
    • r49, on the pushed head e6d23ba, each lane as its ci.yml job runs it, in a fresh worktree with no vibe session record and a stripped environment: node-tests on node 22 (2279 tests, 0 failures), Vibe Eval T0 on node 24 (validate:plugins, 245 tests, pytest 76), plugin version bump, plugin manifest versions, lint, type check, the Python tests, and the vibe-closedloop-build TypeScript lane. The instruction-words test passes 5/5.
    • r49, on the merge before the word-count line (its diff against the pushed head is 1 file, CHANGELOG.md, 1 line): the 21 targeted test files, and the design-inventory, code-review-cost, guided-manual-qa and erd-diagram TypeScript lanes.
  • Codex cloud pass:
  • product-manager-review-dead-clear-control failed all three times here (FFF). The failures are phrasing variance in the reviewer's finding: ISS-13446: Run vibe and fleet in any repository #426's own rerun failed the same way, and this PR does not touch that case or its guidance.
  • The Skill tool was skipped in 5 of 178 runs here, 3 of 192 in the reruns, and 4 of 163 on main. The version-update case passed.
  • pm-owned-lockfile-recovery on Codex, on this commit in the cloud: 4/5, which is the bar. The first-pass run failed owned-change-proof: it read the right guidance, but its proof line dropped the "before" timing word. The four reruns passed.
  • Acceptance criteria, pre-merge (2026-11-17 operator ruling, "Move to a follow-up"):
    • Every formerly quarantined case is fixed or retired. The Codex entries were measured in the cloud on this commit, as above. The Claude entries count by their latest measured arms, 4/5 or 5/5, which ran before the restack onto ISS-13446: Run vibe and fleet in any repository #426.
    • The quarantine file is empty and loads.
    • Both are met. The two post-merge checks are follow-ups (below), not criteria.

Known main failures

  • The vibe-workers TypeScript lane (tools-ts[vibe-workers]) times out on this machine under load on main too. On main 7d5bacf, in a fresh worktree, 5 of 863 tests timed out (main-sync, main-sync-main-comparison, scope-intake). On this branch's final head, 2 of 863 timed out in main-sync. This PR does not touch tools/vibe-workers or its built dist. CI runs the lane on this PR.
The lane as the evidence names it
{"job":{"defaults":{"run":{"working-directory":"tools/vibe-workers"}},"name":"TypeScript (vibe-workers)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/vibe-workers/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/vibe/skills/vibe/scripts/dist","MIN_BUNDLES":"2","TOOL":"vibe-workers"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n  echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n  exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n  git -C ../.. status --porcelain -- \"$DIST\"\n  echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n  exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n  git -C ../.. status --porcelain -- \"$DIST\"\n  echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n  exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}

Disclosures

Follow-ups

  • Under ISS-14136: harden the built-mirror rule so it trusts a .vibe-build.json only when it is present at base or produced by the drift check. Today it trusts a marker added in the same diff; this repository's drift check ties the committed marker to the build.
  • Post-merge, on the ticket's Engineering checklist (2026-11-17 ruling): the post-merge nightly shows no Claude regression (per the 2026-11-16 ruling).
  • Post-merge, on the ticket's Engineering checklist (2026-11-17 ruling): Vibe Eval T0 passes on main after merge.

Stack

The base is main. #426 has merged. This merges after #433.

Move every ClosedLoop and symphony-alpha specific line out of vibe and
vibe-core into the new optional vibe-closedloop-provider plugin, which ships
text and data only. With the provider bound, sessions keep today's behavior;
without it, vibe and fleet work from the repository itself: the person's
description, plans in the private git directory, the AGENTS.md test command,
the lockfile install, and a requested PR or named recipient at the end.

- provider binding, provider text assembly and data access in vibe-core
- guards read their rules from the bound provider and stay silent outside
  an activated chat
- main sync gates its provider-only machinery on the provider's recipe
- the recipes opt-in file is validated and withholds recipes with one reason
- the provider is offered for install once, never re-enabled or reinstalled
- generic scan gate, generic walk fixture, eval arms, and generic twins for
  the provider-bound tests
- vibe 1.1.81, vibe-core 1.0.5, vibe-closedloop-provider 1.0.0
- writer ledgers parse capabilities by shape; grants are checked against the
  session binding at register and launch
- the Claude launcher resolves provider text for its roles
- writers inherit the lead's binding through a Provider line, enforced by the
  Codex launcher, the Claude launcher and the Agent guard
- the recipes opt-in file is validated and judged in the session repository
- adopting a session keeps its binding; moved provider releases re-resolve
- every installed provider's plan folder stays private
- generic fleet recovery ids and duties, the worktree exclude rule, the
  guardrails formatter from the verify recipe
- dangling reference paths fixed, provider text free of ticket ids and home
  paths, the inventory snapshot and mapping checked in pytest
- the eval provider arm installs provider-resolved text
- bundles build byte-identically from any working directory
Bind the tracker in the tracker-duty tests, run spawned scripts outside the
real checkout so the cwd repository leg cannot pick it, derive the provider
line in fleet tests from the fixture binding, fix the shadowed prototype
deploymentHost check and rebuild dist, list provider.mjs as a vibe-core
wrapper, and record the changelog word count.
Pass the lead's binding to remote fleet writers, read the recipes opt-in
from the main checkout for older sessions and for a named checkout, know
UI files by extension without an areas recipe, never write a legacy
provider record generic, keep old hook scope records active, restore the
exact ticket pattern for Prior removal, keep clerkOrgId for older vibe,
report a main sync with no check as needing review, require the sole
workflow for an undeclared lane source, keep generic plans in the common
git dir, move the repository E2E text into provider blocks, and stop
offering an install over an unreadable provider.
…c-vibe-v2

# Conflicts:
#	CHANGELOG.md
#	plugins/vibe/.claude-plugin/plugin.json
#	plugins/vibe/.codex-plugin/plugin.json
…ider

- provider.mjs assemble writes a vibe file merged for the session's
  binding, and assemble --blocks gives every bound block of a loaded
  SKILL.md in one call; the reading rules use them
- each generic region and its provider block share their identical lines
  once, so assembled text is unchanged and the provider is smaller
- only an unbound capability falls back to the generic text: a bound
  provider that is gone, a missing block or an unreadable record stops
  with its reason and fix (exit 4) in the CLI, the launcher, every script
  and the hooks, and a guard refuses the action it guards
- session records are written whole and renamed into place
- the 1.1.82 word count is measured at this tree
ISS-14039 (#427) took vibe 1.1.82 and vibe-core 1.0.5. Keep both sides of
the claude-worker launcher (the broken-provider mapping and the review
model), rebuild the bundles, drop the ticket slugs the merge brought into
runtime files, and remeasure the word count against the new main.
ISS-14028 and ISS-14024 (#428) took vibe 1.1.84 and vibe-core 1.0.7. The
unit-status guard keeps the bound provider's rule and gains the chat's
own program board; its tests keep both cases. The fleet-resume header
covers both changes, the bundles are rebuilt, the ticket slugs the merge
brought into runtime comments are dropped, the launcher mark written into
installed launchers stays as an allowlisted compatibility line, and the
word count is remeasured against the new main.
…e check

A bound session now behaves like main. The start is one version check when the
provider skill's description names its calls, and --closedloop/--graph are
accepted again as aliases of --connection; otherwise the read-only provider
probe runs first, and a check with no states records unprobed instead of
binding generic. Each capability binds on its own connection, so a missing
graph keeps the ClosedLoop text and restores the graph. The check writes the
bound text once per repository and binding, and readers open files from that
folder instead of assembling each one. check always exits 0 and prints the
setup block in every state.

Also: precedent stays live-only, a brief without a Provider: line inherits the
lead's binding, the preflight finds the checkout as main did when bound,
vibe-bench binds through the real check, and the eval runner gains a
provider-installed arm.
…-generic

- tools/vibe-closedloop-build assembles plugins/vibe plus the provider into
  the committed plugins/vibe-closedloop (the `vibe` entry), with cold
  deploy and environment sections in their own files, recipes inline, and a
  CI drift check. plugins/vibe is published as `vibe-generic`.
- Retire runtime provider text: the rule paragraph (two generic sentences
  stay, dropped by the build), provider-text.md, the bind-time folder,
  model-run assemble/block/path/tree, the install offer, provider-install,
  provider-match, the skill-listed flag and the provider skill. Discovery
  reads only the provider bundled in vibe.
- Each install finds its own plugin name and marketplace; with both
  installed the ClosedLoop vibe runs the hooks and binds, and the check
  reports both-installed.
- Eval arms install the built folder (with the repository opt-in file in the
  case folder) and plugins/vibe as `vibe`; no harness assembly.
- Resolve run.py's private homes and every main guard to real paths.
…the word-count entry

- provider.mjs knownProviderContracts lists the provider bundled in every
  vibe install or checkout, enabled or not; local-plans uses it so a plan
  written while bound stays private when the session is not, whichever vibe
  the lookup order picks. Binding and lookup orders are unchanged.
- The vibe CHANGELOG entry names the full Markdown scope of its word count
  again, with the generated folder's exclusion stated after it.
… 1.1.97

- The build places the provider's whole-file references (ticket-template,
  closedloop-graph, ticket-units) at main's paths in plugins/vibe-closedloop
  and rewrites provider: names to main's relative forms; provider/ holds only
  provider.json, whose placed map providerPath resolves through. A build test
  requires every Markdown file reference in the built tree to resolve.
- vibe 1.1.97, vibe-core 1.0.13 (VIBE_CORE_MIN raised to it); #432's new
  cloud code follows the branch's generic rules.
The built ClosedLoop vibe named no connection in its Plugin version command,
so sessions invented --connection names and lost the setup check eval. A
provider block now carries main's text, naming --closedloop and --graph;
generic vibe keeps its --connection form.
Every case in the vibe eval quarantine now passes its unchanged grader, or is retired by a ruling, so eval-quarantine.json is empty.

- vibe: skill, handoff, quality-loop and change-worker text fixes for the quarantined Claude and Codex cases.
- vibe-bench: the Claude stager uses the installed skill (writer-role cases also read the change worker), marks later turns, stages every case on the no-selection path, and installs Pillow with pinned hashes. The private-artifact rule flags only identity roots.
- The pm-prd-children prompt schema can express the checks it grades. The exec precedent case is retired.
- ISS-14325: the handoff diff rules build one line index per file and find identifier uses in one pass, so the inventory finishes on large diffs.
- ISS-14136: the duplicate-helper rule treats a built mirror under a .vibe-build.json marker as the same definition as its source.
- vibe 1.1.100, vibe-closedloop-provider 1.0.3; plugins/vibe-closedloop rebuilt.
Brings in main at 7d5bacf (#426 squashed). Only .gitattributes is new; every other #426 file already matches this branch.
@shafty023

Copy link
Copy Markdown
Collaborator Author

Targeted pre-PR evidence

Published HEAD: e6d23ba90d4f2a3df78364ac20eb4ddf215aeb4a
Tested inventory commit: e6d23ba90d4f2a3df78364ac20eb4ddf215aeb4a
Inventory: read-only worker using .github/workflows/ci.yml
E2E tier: none
Capability probe: docker --version; docker info --format {{.MemTotal}}; dagger version; statfs (Docker present true, reachable true, memory 15.6/20 GiB, disk 279.2/64 GiB)

Kind File and cases Command Result
node:test plugins/vibe/skills/handoff/scripts/comment-rules.test.mjs: all cases (7 tests, 7 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec comment-rules.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/diff-rules.test.mjs: all cases (42 tests, 42 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec diff-rules.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/review-gap-rules.test.mjs: all cases (5 tests, 5 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec review-gap-rules.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/vibe/scripts/precedent-check.test.mjs: all cases (11 tests, 11 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/vibe/scripts && node --test --test-reporter=spec precedent-check.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/evals/checkers/iss-13760-reply-format.test.mjs: all cases (6 tests, 5 passed, 0 failed, 1 skipped) cd plugins/vibe/evals/checkers && node --test --test-reporter=spec iss-13760-reply-format.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/eval-quarantine.test.ts: all cases (2 tests, 2 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/eval-quarantine.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/eval-claude-isolation.test.ts: all cases (4 tests, 4 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/eval-claude-isolation.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/phase3.test.ts: all cases (63 tests, 63 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/phase3.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/private-artifact.test.ts: all cases (3 tests, 3 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/private-artifact.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
vitest tools/vibe-closedloop-build/src/build.test.ts: all cases (16 tests passed, 0 failed) cd tools/vibe-closedloop-build && npx vitest run --reporter=verbose src/build.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/diff-rules-frozen-render.test.mjs: all cases (12 tests, 12 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec diff-rules-frozen-render.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs: all cases (25 tests, 25 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec frozen-render.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/guardrails-gate.test.mjs: all cases (30 tests, 30 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec guardrails-gate.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/skills/handoff/scripts/inventory-bundle.test.mjs: all cases (13 tests, 13 passed, 0 failed, 0 skipped) cd plugins/vibe/skills/handoff/scripts && node --test --test-reporter=spec inventory-bundle.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test plugins/vibe/evals/reviewer-defect-grader-contract.test.mjs: all cases (19 tests, 19 passed, 0 failed, 0 skipped) cd plugins/vibe/evals && node --test --test-reporter=spec reviewer-defect-grader-contract.test.mjs passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/eval-claude-stager.test.ts: all cases (9 tests, 9 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/eval-claude-stager.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/phase5.test.ts: all cases (3 tests, 3 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/phase5.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/upgrade-resume-eval.test.ts: all cases (55 tests, 55 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/upgrade-resume-eval.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/eval-publish.test.ts: all cases (25 tests, 25 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/eval-publish.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b
node:test tools/vibe-bench/src/reply-checker.test.ts: all cases (4 tests, 4 passed, 0 failed, 0 skipped) cd tools/vibe-bench && node --experimental-strip-types --test --test-reporter=spec src/reply-checker.test.ts passed at 1cfe569b8c90a2bfc98dbd2e2e49d65eacc5d73b

Matching post-merge lanes: plugin-version-bump: {"job":{"if":"github.event_name == 'pull_request'","name":"Plugin Version Bump","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4","with":{"fetch-depth":0}},{"name":"Check changed plugin versions","run":"BASE_REF=\"${{ github.event.pull_request.base.ref }}\"\nBASE=$(git merge-base \"origin/$BASE_REF\" HEAD)\n\nchanged_plugins=$(\n git diff --name-only \"$BASE\"...HEAD -- 'plugins/**' |\n awk -F/ 'NF >= 2 { print $2 }' |\n sort -u\n)\n\nif [ -z \"$changed_plugins\" ]; then\n echo \"No plugin changes detected.\"\n exit 0\nfi\n\nwhile IFS= read -r plugin; do\n manifest=\"plugins/$plugin/.claude-plugin/plugin.json\"\n\n if [ ! -e \"plugins/$plugin\" ]; then\n echo \"Plugin $plugin removed; no version bump required.\"\n continue\n fi\n\n if [ ! -f \"$manifest\" ]; then\n echo \"::error::plugins/$plugin/ changed but $manifest is missing. Each plugin must include a .claude-plugin/plugin.json manifest.\"\n exit 1\n fi\n\n if git diff --quiet \"$BASE\"...HEAD -- \"$manifest\"; then\n echo \"::error::plugins/$plugin/ changed but $manifest was not updated. Please bump the plugin version.\"\n exit 1\n fi\n\n old_version=$(git show \"$BASE:$manifest\" 2>/dev/null | jq -r '.version // empty' || true)\n new_version=$(jq -r '.version // empty' \"$manifest\")\n\n if [ -z \"$new_version\" ]; then\n echo \"::error::$manifest must define a version.\"\n exit 1\n fi\n\n if [ -n \"$old_version\" ] && [ \"$old_version\" = \"$new_version\" ]; then\n echo \"::error::plugins/$plugin/ changed but version in $manifest was not bumped (still $new_version). Please bump the version.\"\n exit 1\n fi\n\n if [ -n \"$old_version\" ]; then\n echo \"Plugin $plugin version bumped: $old_version -> $new_version\"\n else\n echo \"Plugin $plugin version added: $new_version\"\n fi\ndone <<< \"$changed_plugins\"\n"}]},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; plugin-manifest-versions: {"job":{"defaults":{"run":{"working-directory":"tools/plugin-manifests"}},"name":"Plugin Manifest Versions","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/plugin-manifests/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"}],"timeout-minutes":10},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; lint: {"job":{"name":"Lint","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"astral-sh/setup-uv@v6","with":{"python-version":"3.13"}},{"run":"uv sync --frozen --group dev"},{"run":"uv run ruff check ."}]},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; typecheck: {"job":{"name":"Type Check","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"astral-sh/setup-uv@v6","with":{"python-version":"3.13"}},{"run":"uv sync --frozen --group dev"},{"run":"uv run pyright"}]},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; test: {"job":{"name":"Tests","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"astral-sh/setup-uv@v6","with":{"python-version":"3.13"}},{"run":"uv sync --frozen --group dev"},{"uses":"actions/setup-node@v4","with":{"node-version":"22"}},{"run":"npm ci","working-directory":"tools/vibe-closedloop-build"},{"run":"uv run pytest plugins/"}]},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; node-tests: {"job":{"name":"Node Tests (skill scripts)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"node-version":"22"}},{"name":"Install zsh for the shell script tests","run":"sudo apt-get update -qq && sudo apt-get install -y -qq zsh"},{"name":"Run node:test suites under plugins/","run":"files=()\nwhile IFS= read -r file; do\n files+=(\"$file\")\ndone < <(git ls-files -- \\\n ':(glob)plugins/**/*.test.mjs' \\\n ':(glob)plugins/**/*.test.cjs' \\\n ':(glob)plugins/**/*.test.js')\n# node --test exits 0 when nothing matches, so an empty set must fail here.\nif [ \"${#files[@]}\" -eq 0 ]; then\n echo \"::error::no *.test.{mjs,cjs,js} files found under plugins/; the discovery glob is broken.\"\n exit 1\nfi\necho \"Running ${#files[@]} test files:\"\nprintf ' %s\\n' \"${files[@]}\"\nnode --test --test-reporter=spec \"${files[@]}\"\n"}],"timeout-minutes":10},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; vibe-eval-t0: {"job":{"name":"Vibe Eval T0","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"node-version":"24"}},{"uses":"astral-sh/setup-uv@v6","with":{"python-version":"3.13"}},{"run":"uv sync --frozen --group dev"},{"name":"Install deterministic benchmark tooling","run":"npm ci","working-directory":"tools/vibe-bench"},{"name":"Type-check benchmark contracts","run":"npm run typecheck","working-directory":"tools/vibe-bench"},{"name":"Validate local plugin structure","run":"npm run validate:plugins","working-directory":"tools/vibe-bench"},{"name":"Run deterministic benchmark contracts","run":"npm test","working-directory":"tools/vibe-bench"},{"name":"Run deterministic Codex mirror contracts","run":"uv run pytest plugins/vibe/evals/codex/test_run.py"}],"timeout-minutes":10},"matrix":{},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"design-inventory","dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10}]: {"job":{"defaults":{"run":{"working-directory":"tools/design-inventory"}},"name":"TypeScript (design-inventory)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/design-inventory/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/code/skills/design-inventory/scripts/dist","MIN_BUNDLES":"10","TOOL":"design-inventory"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"code-review-cost","dist":"plugins/code-review/scripts/dist","min_bundles":1}]: {"job":{"defaults":{"run":{"working-directory":"tools/code-review-cost"}},"name":"TypeScript (code-review-cost)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/code-review-cost/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/code-review/scripts/dist","MIN_BUNDLES":"1","TOOL":"code-review-cost"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"guided-manual-qa","dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1}]: {"job":{"defaults":{"run":{"working-directory":"tools/guided-manual-qa"}},"name":"TypeScript (guided-manual-qa)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/guided-manual-qa/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","MIN_BUNDLES":"1","TOOL":"guided-manual-qa"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"erd-diagram","dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2}]: {"job":{"defaults":{"run":{"working-directory":"tools/erd-diagram"}},"name":"TypeScript (erd-diagram)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/erd-diagram/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","MIN_BUNDLES":"2","TOOL":"erd-diagram"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"vibe-workers","dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2}]: {"job":{"defaults":{"run":{"working-directory":"tools/vibe-workers"}},"name":"TypeScript (vibe-workers)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/vibe-workers/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/vibe/skills/vibe/scripts/dist","MIN_BUNDLES":"2","TOOL":"vibe-workers"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}; tools-ts[{"tool":"vibe-closedloop-build","dist":"plugins/vibe-closedloop","min_bundles":100}]: {"job":{"defaults":{"run":{"working-directory":"tools/vibe-closedloop-build"}},"name":"TypeScript (vibe-closedloop-build)","runs-on":"ubuntu-latest","steps":[{"uses":"actions/checkout@v4"},{"uses":"actions/setup-node@v4","with":{"cache":"npm","cache-dependency-path":"tools/vibe-closedloop-build/package-lock.json","node-version":"22"}},{"run":"npm ci"},{"run":"npm run typecheck"},{"run":"npm test"},{"env":{"DIST":"plugins/vibe-closedloop","MIN_BUNDLES":"100","TOOL":"vibe-closedloop-build"},"name":"Verify committed dist bundles are up to date","run":"tracked=$(git -C ../.. ls-files \"$DIST/*.mjs\" | wc -l)\nif [ \"$tracked\" -lt \"$MIN_BUNDLES\" ]; then\n echo \"::error::only $tracked tracked bundles under $DIST; bundles are missing or ignored (root .gitignore dist/ rule?). The plugin cannot run without them.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::$DIST is stale or contains untracked bundles. Run 'npm run build' in tools/$TOOL and commit the result.\"\n exit 1\nfi\nnpm run build\nif ! git -C ../.. diff --exit-code -- \"$DIST\" || [ -n \"$(git -C ../.. status --porcelain -- \"$DIST\")\" ]; then\n git -C ../.. status --porcelain -- \"$DIST\"\n echo \"::error::scripts/dist is stale or contains untracked bundles. Run 'npm run build' in tools/design-inventory and commit the result.\"\n exit 1\nfi\n"}],"strategy":{"fail-fast":false,"matrix":{"include":[{"dist":"plugins/code/skills/design-inventory/scripts/dist","min_bundles":10,"tool":"design-inventory"},{"dist":"plugins/code-review/scripts/dist","min_bundles":1,"tool":"code-review-cost"},{"dist":"plugins/closedloop-core/skills/guided-manual-qa/scripts/dist","min_bundles":1,"tool":"guided-manual-qa"},{"dist":"plugins/closedloop-core/skills/erd-diagram/scripts/dist","min_bundles":2,"tool":"erd-diagram"},{"dist":"plugins/vibe/skills/vibe/scripts/dist","min_bundles":2,"tool":"vibe-workers"},{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"}]}}},"matrix":{"dist":"plugins/vibe-closedloop","min_bundles":100,"tool":"vibe-closedloop-build"},"version":1,"workflow":{"concurrency":{"cancel-in-progress":true,"group":"ci-${{ github.event.pull_request.number || github.ref }}"},"name":"CI","on":{"pull_request":null,"push":{"branches":["main"]}}}}.

@shafty023
shafty023 merged commit 0057c43 into main Nov 18, 2026
13 checks passed
@shafty023
shafty023 deleted the vibe/iss-14162-eval-quarantine branch November 18, 2026 00:19
shafty023 added a commit that referenced this pull request Nov 18, 2026
Merges main 0057c43 (#437) and moves the release to vibe 1.1.101 and provider 1.0.4, one changelog entry set.

ISS-14127: the duplicate-helper rule also skips a launcher bundle's helper when the flagged file is the built copy of the source the bundle inlined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant