Repository navigation
Prohibit agent-originated product behavior in code review - #201
Open
mikeangstadt wants to merge 8 commits into
Open
mikeangstadt wants to merge 8 commits into
mikeangstadt wants to merge 8 commits into
Conversation
Adds "Agent-originated product behavior — never ship it" to the four reviewer prompts that operate on symphony-alpha. The rule: an agent must not originate user-visible behavior. Refusing to show something is product behavior, as is a default, a threshold, a fallback, an ordering, or an empty-state sentence. Every such rule must cite a human source; if it cannot, that is the finding, reported at High. The review heuristic is the prose itself. A behavior a human specified cites that human. A behavior an agent invented argues for itself — and length correlates with invention. A thorough test suite around an uncited product rule is evidence of the defect, not of diligence, because it makes the invention permanent and makes the next reader assume intent. Includes the measured instance that motivated it: a Sessions LOC/$ card that refused to publish a ratio while both of its operands rendered beside it on the same row, behind a rule no human specified, carrying a justification paragraph, a canonical reason map, a feature flag and a nine-case suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The Plugin Version Bump check requires any plugin whose files changed to carry a version bump. This change edits reviewer prompts in both plugins/code and plugins/code-review. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
|
Beginning a code-review. Please allow time for me to finish before merging the PR |
shafty023
reviewed
Sep 15, 2026
shafty023
reviewed
Sep 15, 2026
shafty023
reviewed
Sep 15, 2026
Collaborator
|
Beginning a code-review. Please allow time for me to finish before merging the PR |
Collaborator
|
Code review complete. Approval was withheld because existing inline comments already cover the actionable concerns. |
…riginated-product-behavior
…hangelog Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…inated-product-behavior
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-agent-originated-product-behavior
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Review request: Lint, Type Check and Tests pass on the head, there are 0 unresolved threads, and the branch merges cleanly with |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds "Agent-originated product behavior — never ship it" to the four reviewer prompts that operate on
symphony-alpha:plugins/code/agents/code-review-guidelines.mdplugins/code/agents/code-reviewer.mdplugins/code-review/prompts/github-review.md.claude/agents/pr-reviewer.mdThe rule. An agent must not originate user-visible product behavior. Every rule deciding what a user sees — shown, withheld, refused, defaulted, thresholded, ranked, reworded — must cite a human source: ticket AC, PRD, or an operator instruction. If it cannot, that is the finding, reported at High.
Why it needs a reviewer rule and not just a repo doc. This class ships looking correct. The implementer reasons their way to a defensible position, writes a persuasive comment, and pins it with tests. Every downstream reader then treats it as intended. Nothing in the existing severity table catches it, because the code is well-formed, well-tested, and internally consistent — it is simply behavior nobody asked for.
The review heuristic is the prose itself. A behavior a human specified CITES that human. A behavior an agent invented ARGUES FOR ITSELF. Length correlates with invention. A thorough suite around an uncited product rule is evidence of the defect, not of diligence.
Sits beside "Blind scope drop — never an option" in
code-review-guidelines.mdand follows its shape: named prohibition, concrete tells, and a measured instance.The measured instance
symphony-alphaISS-10354, 2026-09-15. A Sessions LOC/$ card refused to publish its ratio whenever a coverage probe returned anything butComplete. No human specified that rule. It shipped with a paragraph of justification, a canonical state-to-copy map, a feature flag, and a nine-case suite pinning each refusal.In production it rendered
LOC / $ —on a row that simultaneously displayedTotal estimated cost $37,927andPRs shipped 362— both of its own operands, present and rendering. One refused state (MigrationPending, "still being rebuilt") described a rebuild that no job performs, so the blackout was permanent rather than transient.The code's own comment admitted what it was: "the coverage verdict is a refusal to publish a number that exists." It was caught by a human looking at a screenshot, after code-side analysis of the coverage state machine missed it twice.
Companion change in symphony-alpha: closedloop-ai/symphony-alpha#7356, which deletes the refusal and adds the matching sections to
AGENTS.md,.claude/review/soul.mdand.claude/logical/discipline-core.md.Test plan
Prose-only change to four reviewer prompt files; no code paths, no runtime behavior. Verified each file received the section exactly once and that the insert is idempotent (re-running skips a file that already carries it).
🤖 Generated with Claude Code