Skip to content

ISS-14116: Slim vibe-core and prevent the reported vibe bugs - #438

Merged
shafty023 merged 20 commits into
mainfrom
vibe/iss-14116-prevention-2
Nov 19, 2026
Merged

shafty023 merged 20 commits into
mainfrom
vibe/iss-14116-prevention-2

Conversation

@shafty023

@shafty023 shafty023 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Ticket: ISS-14116.

Complete in this push: ISS-14375, ISS-14163, ISS-14217, ISS-14128, ISS-14058, ISS-14171, ISS-14186, ISS-14221, ISS-14223, ISS-14222, ISS-14216, ISS-14193, ISS-14184, ISS-14172, ISS-14137, ISS-14192, ISS-14037, ISS-14252, ISS-14224, ISS-14258, ISS-14259, ISS-14304, ISS-14307, ISS-14117, ISS-14324, ISS-14336 and ISS-14325 (duplicate-helper indexing only).

Also in this push, under ISS-14116: the vibe-core slimming (Daniel ruled it ships in this PR; see "vibe-core slimming" below).

Linked, continuing in later pushes on this PR: ISS-14116 (item 12), ISS-14374 (items 17, 20, 22 to 25, 27 to 30), ISS-14366 (item 13), ISS-14387 (items 18 and 19), ISS-14394 (items 21 and 26), ISS-14355 (the post-fix Claude cloud eval probe) and ISS-14395 (frozen render, the next push).

Delivery placement: unrelated: gate-misfires (#433) delivers only ISS-14136, ISS-14127 and ISS-14112; fleet-home-binding and cloud-routines deliver ISS-14028, ISS-14024, ISS-13998 and ISS-14140; the ISS-14116 prevention work is one PR of its own (Daniel, 2026-11-16: all the bug fixes in a single PR).

  • One prevention change for the reported vibe defects: launcher refusals carry their own codes and the refused path or action instead of WRITER_BUSY or a bare WORKER_TURN_FAILED (tools/vibe-workers/src/claude-worker.ts:777); request queue, continuation and migration states always have a supported recovery; review and lane evidence carry only across a safe delta; gate, guard, fleet, remote, writer and review groups each get an instance fix, a sweep and a prevention rung with tests and mutation proofs.
  • Cloud validate runs named workflow lanes from the committed ci.yml, reports the RemoteTrigger result event, stderr and github_token_missing as a setup step, and treats an archived task as terminal (plugins/vibe/lib/vibe/scripts/cloud-worker.mjs:310, plugins/vibe/lib/vibe/scripts/cloud-worker.mjs:396).
  • Fold-by-default gate (ISS-14374): an ISSUE or new PR from an orchestrator or writer session needs a Delivery placement: line naming the open unit that takes the work, or why it is unrelated (plugins/vibe/lib/fleet-orchestrator/scripts/delivery-placement.mjs:88).
  • prevent-recurrence (closedloop-core 1.6.3, ISS-14375) checks where each harness loads a rule before adding one (plugins/closedloop-core/skills/prevent-recurrence/SKILL.md:49).
  • Takeover fixes on the merged tree: diff rules judge build output the base marks linguist-generated through its source (plugins/vibe/skills/handoff/scripts/diff-rules.mjs); the ISS-14252 input-set and ISS-14137 agent-decision rules no longer fire on unrelated lines; plugin-version.mjs adopt rebinds a session whose recorded provider folder a plugin update removed (plugins/vibe/skills/vibe/scripts/plugin-version.mjs:976); the decision-table gate holds a later Not aligned statement (plugins/vibe/lib/handoff/scripts/decision-table-gate.mjs:104); fleet.sh again puts prompt evidence and rulings at the stable remote path briefs name (plugins/vibe/skills/fleet-orchestrator/scripts/fleet.sh:63).
  • vibe-core slimming: vibe-core keeps only the hook registrations and a loader; the guards, lib and process-identity live in vibe. Details and the version-skew behavior are in "vibe-core slimming" below.
  • Versions (plugins/vibe/.claude-plugin/plugin.json:4): vibe 1.1.103, vibe-closedloop 1.1.103 (generated), vibe-closedloop-provider 1.0.6, vibe-core 1.0.15 (the first slim version, which is also VIBE_CORE_MIN at plugins/vibe/shared/vibe-core.mjs:12) and closedloop-core 1.6.3. The main merged in is 0673f59 (ISS-14136, ISS-14127, ISS-14112: No-surface criteria, gpt-6.2 #433).

vibe-core slimming

Why: vibe-core held every guard and module the hooks run (148 files, 1.79 MB), and 12 of its releases in 8 days each made every Codex user re-approve its hooks. Codex's trust hash covers every file under the plugin root, so any change to a guard re-triggered approval.

What it is now:

  • vibe-core keeps hooks.json (byte-identical), five thin entry files, the loader hooks/vibe-runtime.mjs, plugin-roots.mjs, vibe-install.mjs, README and manifests, plus 77 frozen stubs at the old module paths. 76 stubs print "vibe-core is newer than your vibe." with the fix sentence and exit 1. The protected-write-guard stub exits 0, because a pre-slim headless launcher runs it as a hook that blocks on failure.
  • lib/**, the hook guards and process-identity moved to plugins/vibe at the same relative paths. vibeCore() and runVibeCoreMain() load from vibe's own root, so no call site changed and vibe no longer needs vibe-core to run its scripts.
  • Each event, the loader finds the vibe the session uses (found, absent or unresolved), imports its hooks/runtime.mjs and prints the result. Absent, disabled, or a vibe with its own hooks.json: silent stand-down. Unresolved or unusable: nothing is refused and work continues.
  • The degraded notice goes out only on UserPromptSubmit; every other event is silent (Daniel, decision 22). The notice text, its fix sentence and three reasons are the ones Daniel approved verbatim.
  • vibe's own vibe-install.mjs keeps the per-cwd first-enabled lookup (orchestrator decision 24). It keeps the pinned capability that skill freshness and the version guard judge the vibe a worktree's project uses.
  • A bundle guard test (tools/plugin-manifests/src/vibe-core-bundle.test.ts) pins the file allowlist, the import closure, a 900-line budget and the Codex codex-plugin-bundle-v1 fingerprint. The fingerprint port is checked against the real trusted_content_hash for installed vibe-core 1.0.13 and code 2.0.2.
  • Remote staging ships vibe only. The dist bundles runtime-load lib and hooks from vibe's own root. The launcher's protected-write-guard path now resolves inside vibe.

Cost of the shim, re-measured after the runtime switched to lazy imports (load 32, median of 11 runs, milliseconds; through vibe-core versus vibe's entry run directly; bare node is 60):

  • PreToolUse: 198 through vibe-core, 304 directly.
  • PostToolUse: 170 through vibe-core, 138 directly.
  • UserPromptSubmit: 156 through vibe-core, 161 directly.
  • SessionStart: 78 through vibe-core, 72 directly.
  • PreCompact: 77 through vibe-core, 74 directly.

The two columns are within noise of each other under that load (the PreToolUse direct run was the slower one), so the shim's extra cost is not distinguishable from noise.

Codex users re-approve vibe-core's hooks once for this release, and afterwards only when its thin set changes.

Matrix tests: plugins/vibe/shared/vibe-core-skew.test.mjs (24 cases), vibe-core-skew-static.test.mjs (8) and vibe-state-skew.test.mjs (5) run the skew matrix against the frozen stubs and the loader; the notice test asserts presence on UserPromptSubmit and absence on PreToolUse, PostToolUse, SessionStart and PreCompact. Each passes in the final-head run under How it was checked.

Two further fixes in this push: gh pr create on an override path (head ownership or session record overridden) takes VISUAL_QA_FINDINGS=<findings.json> inline and checks it for the PR head as merge-guard does (ADV-R16-3, DT-S14); a remote or no-worktree ready row whose binding declares no UI paths now needs findings for its head (ADV-R16-4, DT-S15).

Known edges, recorded and not built, for the next push:

  • a gh pr merge from a checkout with no binding;
  • pre-release ready rows reading VISUAL-QA-MISSING until declared again;
  • an exported ELECTRON_RUN_AS_NODE later reassigned;
  • round 18a (ADV-R18A-5, non-blocking): on a remote host the staged scripts carry no vibe-core, so the HOOK-APPROVAL line there names vibe-core's entry generically instead of its Codex display name;
  • item 76 (predates this branch, found while proving the bash 3.2 SIGTERM tests): stopping a capture slot signals only the command's top process, so under macOS /bin/bash its children can outlive the freed slot and hold fleet.sh's output open; a process-group stop is a product change;
  • the launcher refuses a brief that names a branch-only skills/*/scripts file (queued by the orchestrator); a brief names such a file by an absolute path in the meantime.

Rulings

  • Daniel, 2026-11-18: "change the policy. keep the lines", then "we don't update claude.md. every claude.md file just says to load AGENTS.md". The Codex cloud eval rule lives in root AGENTS.md only; CLAUDE.md equals main; the handoff path policy admits root AGENTS.md only.
  • Daniel, 2026-11-18: "Open early, keep stacking" and "keep stacking things in our PR until we have it right and fast". Remaining items land as later pushes on this PR.
  • Daniel, 2026-11-18: push as vibe/iss-14116-prevention-2; the old remote branch stays.
  • Daniel, 2026-11-18 (decisions 22 and 26, plan rulings D1 to D5 and the fix sentence): stubs at the moved paths; the guards never refuse when vibe cannot load; the degraded notice only on UserPromptSubmit; the notice and manifest text verbatim; hooks.json kept as is.
  • Daniel, 2026-11-18, instruction words: "Shrink more, then accept". The leftover is disclosed below.
  • Daniel, 2026-11-18, bare-word baseline: "Add both, cite ISS-14137" (ONE_READER_CLAIM and PRODUCT_DECISION).
  • The CI workflow is main's exact blob (the Node Tests timeout change had no ruling and was restored).

Deliberate test changes

Every changed assertion below is tied to a contract this PR changes. The first group is the slimming and the round 16 rulings, taken from the diff between the pre-move tree (cca21870) and the final tree. The second group is the earlier changes against main (0673f59), with line numbers checked on the final tree.

Slimming and round 16 (cca21870 to the final tree)

Moves with no change to a case (rename similarity 100%): the hook and lib tests that moved from plugins/vibe-core to plugins/vibe at the same relative paths, the files git reports as 100% renames. plugins/vibe-core/hooks/activation-test-support.mjs became a stub and its helper moved to plugins/vibe/hooks/activation-test-support.mjs. The capture cases of fleet.test.mjs moved unchanged to plugins/vibe/skills/fleet-orchestrator/scripts/fleet-capture.test.mjs (the usage assertion is at fleet-capture.test.mjs). The SIGTERM capture tests await the process exit, as main's do.

Changed assertions, by contract:

  • Moved paths (the modules and hooks now live in plugins/vibe; the expected strings follow): plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:26 to :29; plugins/vibe/skills/vibe/scripts/generic-walk.test.mjs:66 and :70; plugins/vibe/skills/fleet-orchestrator/scripts/fleet-atomic-install.test.mjs:12; plugins/vibe/evals/codex/test_run.py:202, :212 and :216; plugins/vibe/tools/python/test_vibe_1078_lessons_contract.py:74, test_vibe_1081_lessons_contract.py and test_vibe_iss_14228_contract.py; plugins/vibe/tools/python/test_vibe_generic_scan.py:57; tools/vibe-workers/src/claude-worker.test.ts:7, tools/vibe-workers/src/main-sync-producer-read.test.ts:5, :16 and :17, and tools/vibe-workers/src/runtime-contract.test.ts:5; tools/vibe-bench/src/phase2.test.ts:48 and phase3.test.ts; plugins/vibe/lib/vibe/scripts/cloud-worker.test.mjs:21 (the lane command path); plugins/vibe/skills/codex-fleet-monitor/scripts/snapshot.test.mjs:114 and :127 to :134 (the remote watcher ships vibe's lib files).

  • vibe-core is no longer staged remotely, and a remote host carries vibe alone: plugins/vibe/skills/fleet-orchestrator/scripts/fleet-plugin-preflight.test.mjs:15 to :28 (the shipment holds only plugins/vibe, and the staged-plugin check no longer takes a vibe-core minimum); plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:495 to :509 (the shipped tree is vibe laid out as a checkout) and :586 onward (a remote slot stages vibe's root and nothing from vibe-core; the tar collision fixture names the vibe path).

  • Moved commands run without vibe-core: plugins/vibe/skills/vibe/scripts/plugin-version-bootstrap.test.mjs:26 and :106 to :112 (a moved command such as fleet-home.mjs resume now exits 0 and prints NO-ACTIVE-PROGRAM from vibe's own lib instead of the vibe-core-is-not-installed refusal, and nothing installs vibe-core); plugins/vibe/shared/vibe-core.test.mjs:1 to :162 (vibeCore() loads from vibe's own root with no vibe-core beside it, an old vibe-core never stops vibe's modules loading, the setup check still names a missing or too old vibe-core, each lib module has one home in vibe, the bundles load lib and hooks from vibe at run time); plugins/vibe/lib/vibe/scripts/provider.test.mjs:314 to :317 (the cache fixture copies vibe's lib and shared); plugins/vibe/skills/vibe/scripts/plugin-version.test.mjs:669 (the cached release carries lib, hooks and shared); plugins/vibe/hooks/guard-install.test.mjs (the guards resolve from the copy of vibe the session uses, with no vibe-core copy installed); tools/vibe-closedloop-build/src/build.test.ts:2, :92, :94 and :291 (the built vibe ships lib, hooks and process-identity and excludes *-test-support.mjs; the provider module is read from the built vibe).

  • The protected-write-guard stub exits 0, and the guard lives in vibe's hooks folder: tools/vibe-workers/src/claude-worker.test.ts:63 to :71 and :294 (a missing guard reads "missing or unreadable"; the symlinked guard sits in vibe/hooks); the stub exit codes are pinned in tools/plugin-manifests/src/vibe-core-bundle.test.ts (new).

  • The notice goes out only on UserPromptSubmit: pinned by the new matrix tests (presence on UserPromptSubmit; absence on PreToolUse, PostToolUse, SessionStart and PreCompact). plugins/vibe/hooks/pre-tool-use.test.mjs:20, :168, :188 and :191 read vibe-core's hooks.json, now the only registration, and still check one command per event and a matcher naming exactly the routed tools.

  • vibe-core's own tests became tools/plugin-manifests tests: plugins/vibe-core/shared/plugin-roots.test.mjs (a byte-identity test) became the layout fixture test tools/plugin-manifests/src/vibe-core-plugin-roots.test.ts, and plugins/vibe-core/shared/vibe-install.test.mjs became tools/plugin-manifests/src/vibe-core-install.test.ts. tools/vibe-bench/src/vibe-change-scope.test.ts:92 to :97 follows the move: vibe's moved hooks and lib are vibe behavior, their tests are not, and vibe-core's plugin-roots stays vibe-core runtime.

  • The scans now cover the moved files: plugins/vibe/tools/python/test_vibe_session_friction_contract.py:37 to :55 (three reviewed timeout strings in app-binary-guard.test.mjs, which is data fed to the guard, each with a reason and a check that the line still exists); plugins/vibe/tools/python/test_vibe_signal_safety_contract.py:34 to :39 and :149 to :154 (the reviewed child-gate kill(-process.pid) in e2e-lock.mjs, with a reason and a check that it is still present); plugins/vibe/tools/python/test_vibe_generic_scan.py:163 to :166 (the variable-name lookup in vibe-core's vibe-install.mjs is allowed beside the resolver and the startup probe, because its names come from VIBE_PLUGIN_NAMES and it finds vibe, never the provider).

  • The routine ledger now exists twice (source and the generated copy in plugins/vibe-closedloop): plugins/vibe/lib/vibe/scripts/cloud-worker.test.mjs:863 to :889 exempts both paths, expects both, and asserts they are byte-identical.

  • ADV-R16-3 (inline findings on an override path): plugins/vibe/skills/handoff/scripts/handoff-gate-visual-qa.test.mjs:64 and :130 to :143 (the create helper takes a command prefix; the new case needs findings named inline for the PR head, refuses another head, and refuses a value the guard cannot read).

  • ADV-R16-4 (no-worktree rows): plugins/vibe/skills/fleet-orchestrator/scripts/board.test.mjs:383 to :398 (a ready row with no worktree and no declared UI paths is refused with "no visual QA findings file" until findings for its head are given; the board then shows the full head).

  • The admission test runs under the pinned macOS /bin/bash 3.2 as well as the default bash (fleet.test.mjs, with the fleet-test-support.mjs helpers startFleet, pinMacBash and HAS_MAC_BASH32); the empty-array failure it caught under set -u is fixed in fleet-admission.sh.

  • plugins/vibe/lib/vibe/scripts/e2e-lock.test.mjs:38: the child cleanup checks gate.pgid > 1 where it checked gate.pid > 1; the line already requires gate.pgid === gate.pid, so behavior is unchanged, and the signal-safety contract can now verify the guard itself instead of carrying an exemption.

  • plugins/vibe/lib/fleet-orchestrator/scripts/fleet-handoff.test.mjs:39 and :45: the handover notes fixture and its regex say "the operator" where they named a person, for the no-person-names contract the moved file now falls under; the handover contract is unchanged.

  • plugins/vibe/skills/vibe/scripts/push-ready-contract.test.mjs: main's ISS-14136, ISS-14127, ISS-14112: No-surface criteria, gpt-6.2 #433 asserted /working-tree/ in the assembled verifier text; this branch moved that evidence field guide into pr-evidence-schema.mjs --example (orchestrator decision 17), so the test now requires the verifier to name that command and the tool's output to carry working-tree, as runtime-contract.test.ts does since round 16 (accepted as a deliberate change, orchestrator decision 32).

  • plugins/vibe/hooks/pre-tool-use.test.mjs: the UserPromptSubmit payload in "tools with no guard" now carries the sandbox cwd, so the test never reads a live session record (fixture repair; no expectation changed).

  • tools/plugin-manifests/src/vibe-core-plugin-roots.test.ts: one long regex built from two shorter strings so the test runner prints a code frame for its absence proof (same pattern).

New test files (additions, not changes): plugins/vibe/hooks/activation-test-support.mjs (moved helper); plugins/vibe/shared/vibe-core-skew.test.mjs, vibe-core-skew-static.test.mjs, vibe-core-skew-test-support.mjs and vibe-state-skew.test.mjs; plugins/vibe/skills/fleet-orchestrator/scripts/fleet-capture.test.mjs (moved cases); tools/plugin-manifests/src/vibe-core-bundle.test.ts, vibe-core-install.test.ts, vibe-core-plugin-roots.test.ts and vibe-core-runtime.test.ts.

Earlier changes against main (0673f59)

  • plugins/vibe/hooks/program-change.test.mjs:36, plugins/vibe/hooks/program-change.test.mjs:39, plugins/vibe/hooks/program-change.test.mjs:48, plugins/vibe/hooks/program-change.test.mjs:61, plugins/vibe/hooks/program-change.test.mjs:62: the hook reads the session from the event cwd now (test isolation, ISS-14374 item 9); the cases pass a private cwd instead of the live one, same expected results.
  • plugins/vibe/hooks/unit-status-guard.test.mjs:69: the PreToolUse MCP route gained issue-placement-guard (ISS-14374 item 5, fold-by-default gate).
  • plugins/vibe/lib/handoff/scripts/codex-review-runtime.test.mjs:28: the reader now returns the raw App Server turn items, which the receipt gate observes directly.
  • plugins/vibe/lib/handoff/scripts/review-receipts.test.mjs:212: the gate check now reads the PR body file it binds (decision-table and placement checks need it).
  • plugins/vibe/lib/vibe/scripts/cloud-environment.test.mjs:134, plugins/vibe/lib/vibe/scripts/cloud-environment.test.mjs:135, plugins/vibe/lib/vibe/scripts/cloud-environment.test.mjs:136, plugins/vibe/lib/vibe/scripts/cloud-environment.test.mjs:268: cloud check adds an environment-setup row that reports "not exercised" instead of a pass (ISS-14259), so the later rows shift by one.
  • plugins/vibe/lib/vibe/scripts/e2e-lock.test.mjs:98, plugins/vibe/lib/vibe/scripts/e2e-lock.test.mjs:779: the e2e-lock hang fix (ISS-14374 item 8): waits are bounded and name the step that timed out.
  • plugins/vibe/skills/codex-fleet-monitor/scripts/recover.test.mjs:403: the supervisor-lock test is bounded under load (ISS-14374 item 9); the assertion message moved to its own line.
  • plugins/vibe/skills/fleet-orchestrator/scripts/fleet-capture.test.mjs: fleet.sh usage gained the full-corpus option (ISS-14258, overlapping full-corpus runs).
  • plugins/vibe/skills/fleet-orchestrator/scripts/instruction-words.test.mjs:72: the word count now includes top-level Markdown, so the fixture counts one more file.
  • plugins/vibe/skills/handoff/scripts/criteria-audit.test.mjs:164: a criterion waiting on another ticket, on a requested pull request, now names the missing passing-on mode and both supported actions; the case at :189 to :199 adds the no-provider run. The earlier text of this line cited ISS-14307, which the hunk does not show; the writer confirms the ticket.
  • plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:134 (removed), plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:153, plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:154: member tickets fit in the body without consuming the PR title (ISS-14374, Daniel 2026-11-17 fold-by-default); the refusal of a lead-only title is removed.
  • plugins/vibe/skills/handoff/scripts/pr-facts.test.mjs:892, plugins/vibe/skills/handoff/scripts/pr-facts.test.mjs:894: known main failures accept the lane name for workflow-lane rows (ISS-14387 item 19).
  • plugins/vibe/skills/handoff/scripts/storybook-rules.test.mjs:79, plugins/vibe/skills/handoff/scripts/storybook-rules.test.mjs:80: removing story states is a minor Storybook version change, not a major one (ISS-14171).
  • plugins/vibe/skills/handoff/scripts/test-integrity.test.mjs:164, plugins/vibe/skills/handoff/scripts/test-integrity.test.mjs:826 (skip-added): a truthful test-stand-in owner boundary is accepted beside production; the skip-added line is the fixture for a test.only spec, which the integrity scan must catch.
  • plugins/vibe/skills/vibe/scripts/push-ready-contract.test.mjs: remote heavy runs go through fleet.sh remote slot heavy, not the external e2e-slot.sh (ISS-14117).
  • plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:381 (removed), plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:898 (removed), plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:900, plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:904: an overdue cloud poll returns its status instead of throwing, so the receipt survives (ISS-14259); member tickets no longer have to be in the PR title (as above).
  • tools/vibe-workers/src/claude-worker.test.ts:391, tools/vibe-workers/src/claude-worker.test.ts:420, tools/vibe-workers/src/claude-worker.test.ts:421, tools/vibe-workers/src/claude-worker.test.ts:422, tools/vibe-workers/src/claude-worker.test.ts:423, tools/vibe-workers/src/claude-worker.test.ts:474, tools/vibe-workers/src/claude-worker.test.ts:545, tools/vibe-workers/src/claude-worker.test.ts:1009, tools/vibe-workers/src/claude-worker.test.ts:1011, tools/vibe-workers/src/claude-worker.test.ts:1183: launcher refusals name the action and code instead of a generic failure (ISS-14116 items 1, 5, 7; ISS-14374 item 7).
  • tools/vibe-workers/src/ledger.test.ts:302: the active-request refusal names the requestId and says to send a continuation (ISS-14374 item 7).
  • tools/vibe-workers/src/scope-intake.test.ts:54: the fixture names the outside path by role instead of by index.
  • tools/vibe-workers/src/writer-migration.test.ts:685: same refusal wording as ledger.test.ts (ISS-14374 item 7).

Other test edits this diff makes (not assertion flips the facts list):

  • plugins/vibe/tools/python/test_vibe_codex_budget_contract.py: the cloud-eval rule is checked in root AGENTS.md only, per the CLAUDE.md ruling above.
  • plugins/vibe/tools/python/test_vibe_review_consolidation_contract.py: pins the new untargeted-pass condition in missingLanes.
  • plugins/vibe/skills/handoff/scripts/flag-retirement.test.mjs: the regex names "dispositions" so the story-link scanner does not read it as a story path.
  • The ISS-14184 fixed-timeout test in e2e-lock.test.mjs is deleted: its contract (Node Tests timeout 15) was retired when ci.yml was restored to main's blob.
  • Gate tests seed the session decision table, cloud-import tests add a placement line, a GitHub-shaped origin and an empty fleet home, and the shell-safety-guard tests run from a neutral cwd so a session worktree's own record never leaks in.

Changed and removed exports

MCP_ROUTE, TERMINAL, TEST_SELECTORS, VIBE_CORE_MIN, changeWriter, e2eSlotProblem, knownLocalPlanPrefixes, localPlanPaths, localPlanPrefix, prEvidenceShapeProblems, readInput, readMainSyncInput, readTestSelection, reviewReceiptProblems, safeFailure, selectionProblems, specExecutionLimitation, targetedEvidenceProblems, workflowLaneDefinitions: changed or removed by the launcher, receipt, lane-evidence, plan-path and placement work above. localPlanPrefix, knownLocalPlanPrefixes and localPlanPaths live in plugins/vibe/lib/vibe/scripts/session-artifact-paths.mjs; workflowLaneDefinitions moved to its own module; VIBE_CORE_MIN now names the first vibe-core whose hooks hand over to this vibe's guards; the plugins/vibe-closedloop copies are generated.

Contract and assertion listing

The gate lists every export and assertion the diff changes. Most entries below exist only because of the vibe-core slimming: each module moved from plugins/vibe-core/ to plugins/vibe/ with its exports and tests unchanged, and the old vibe-core path now holds a frozen stub that exports nothing (or the test file is gone from vibe-core), so the old path reads as removed.

Exports at the old vibe-core paths (each now at the same path under plugins/vibe):

  • plugins/vibe-core/hooks/activation-test-support.mjs: ACTIVATED_SESSION, activatedChat
  • plugins/vibe-core/hooks/activation.mjs: activated, activationBasis
  • plugins/vibe-core/hooks/agent-guard.mjs: agentGuard, agentLaunchProblem, writerBindingProblem
  • plugins/vibe-core/hooks/away-protocol.mjs: AWAY_CHECKLIST, BACK_CHECKLIST, awayProtocol, checklistFor
  • plugins/vibe-core/hooks/command-calls.mjs: UNKNOWN_VALUE, commandCalls, ghPrAt
  • plugins/vibe-core/hooks/command-segments.mjs: commandPrefix, commandSegments
  • plugins/vibe-core/hooks/context-guard.mjs: compactionInstructions, contextGuard, latestContextTokens
  • plugins/vibe-core/hooks/fleet-resume.mjs: fleetResume, reinvokeLine
  • plugins/vibe-core/hooks/foreground-guard.mjs: MAX_FOREGROUND_MS, foregroundGuard, foregroundProblem, inVibeSession
  • plugins/vibe-core/hooks/hook-dispatch.mjs: DECISION_PRECEDENCE, deny, eventCwd, mergeResults, runGuards, runHookScript
  • plugins/vibe-core/hooks/hook-session-scope.mjs: conversationSkill, hookActivated, hookRuntime, hookStatePath, isVibePluginSkill, readHookSkill, readHookSkillRecord, recordHookSkill
  • plugins/vibe-core/hooks/kill-guard.mjs: killGuard, killProblems, ledgerFile, recordedOwn, startTimeOf
  • plugins/vibe-core/hooks/merge-guard.mjs: mergeCalls, mergeGuard, mergeProblem
  • plugins/vibe-core/hooks/pause-guard.mjs: HOLD_PATTERNS, TASKSTOP_REMINDER, holdReminder, pauseGuard
  • plugins/vibe-core/hooks/plugin-version-guard.mjs: inVibeConversation, launchesWorker, launchesWriterAgent, pluginVersionGuard, pluginVersionPromptStart, pluginVersionSkillStart, versionProblem
  • plugins/vibe-core/hooks/post-tool-use.mjs: POST_TOOL_USE_GUARDS
  • plugins/vibe-core/hooks/pr-create-guard.mjs: createsPullRequest, prCreateCalls, prCreateGuard, vibeWorktree
  • plugins/vibe-core/hooks/pre-tool-use.mjs: MCP_ROUTE, PRE_TOOL_USE_ROUTES, preToolUse, scratchCreationProblem
  • plugins/vibe-core/hooks/program-change.mjs: PROGRAM_CHANGE_REMINDER, programChange
  • plugins/vibe-core/hooks/protected-write-guard.mjs: protectedWriteDecision
  • plugins/vibe-core/hooks/question-guard.mjs: QUESTION_TOOLS, codeCitationProblem, isVersionQuestion, questionGuard, questionTexts
  • plugins/vibe-core/hooks/session-start.mjs: SESSION_START_GUARDS, sessionStart
  • plugins/vibe-core/hooks/shell-safety-guard.mjs: credentialProblem, e2eSlotProblem, equalsWordProblem, forcePushProblem, runsE2eScript, shellSafetyGuard, watcherLaunchProblem, wordSplitProblem
  • plugins/vibe-core/hooks/skill-transcript.mjs: TRANSCRIPT_LIMIT_BYTES, latestSkill, loadsSkill, readTranscript
  • plugins/vibe-core/hooks/unit-status-guard.mjs: unitStatusGuard, unitStatusProblem, unitStatusRule
  • plugins/vibe-core/hooks/user-prompt-submit.mjs: USER_PROMPT_SUBMIT_GUARDS, userPromptSubmit
  • plugins/vibe-core/lib/codex-fleet-monitor/scripts/liveness.mjs: AppServerClient, Failure, LineClient, assistantTail, classifyTurnError, connectDirect, connectStdio, connectViaProxy, daemonSocket, decodeFrames, encodeFrame, exitAfterTotalTimeout, modelDrift, needsReply, parseSession, readSessions, readThreadState, summarize
  • plugins/vibe-core/lib/codex-fleet-monitor/scripts/work-dir.mjs: PER_PROGRAM_KEYS, parseConfig, readConfig, resolveWorkDir, shellLines
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/chat-binding.mjs: ambiguousHome, bindChat, boundPrograms, canonicalHome, canonicalProgram, captureBinding, chatBinding, chatHome, commandChat, currentProgram, programChats, programFor, reclaimStaleLock, refuseHeld, releaseLeftoverClaims, restoreBinding, takenOver, unbindChat, unboundLine, validChat
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/cloud-placement.mjs: decideCloudPlacement
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/fleet-home.mjs: COMPACT_WINDOW_RANGE, FLEET_HOME_SCRIPT, PROGRAM_READING, REUSABLE, Shape, chatProgramDir, closeProgram, contextGuardConfig, defaultHome, homeProblems, launcherLines, launcherScript, programShape, resumeLines, setShape, startProgram
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/fleet-migrate.mjs: migrate, migrationPlan
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/helpers.mjs: acquireLedgerLock, completionEventProblem, endProcesses, finalMarker, finalReportProblem, helperEntries, isAlive, orphans, ownedDuties, parsePids, pendingE2eCleanups, pendingRecordedProcess, probe, read, readGroupId, readIdentity, reconcileTerminalHelpers, safePid, stopCandidates, write
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/scratch-cleanup.mjs: captureScratchLease, reconcileExpiredScratchHelpers, registerScratchProgram, runScratchStack, scratchLeaseTerminal, scratchOverlay, sweepScratchHelpers
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/skill-freshness.mjs: promptProblems, skillFreshnessProblem
  • plugins/vibe-core/lib/handoff/scripts/codex-review-runtime.mjs: observedCodexTurn, readCodexReviewTurn
  • plugins/vibe-core/lib/handoff/scripts/handoff-evidence.mjs: MAX_EVIDENCE_BYTES, evidenceFingerprint
  • plugins/vibe-core/lib/handoff/scripts/handoff-gate-check.mjs: EVIDENCE_KEYS, checkedMergeProblem, gatePath, handoffGateProblem, memberNameProblems, mergeTargets, mergeabilityProblem, readReviewReceipts, resolvePrBase, reviewFindingProblems, sessionMembers
  • plugins/vibe-core/lib/handoff/scripts/mcp-tool-names.mjs: graphAliases, mcpToolAliases, mcpToolIdentity
  • plugins/vibe-core/lib/handoff/scripts/review-premises.mjs: premiseProblems
  • plugins/vibe-core/lib/handoff/scripts/review-receipts.mjs: REVIEW_ROLES, captureNativeReviewReceipt, captureReviewReceipt, reviewReceiptProblems, reviewTraceFacts, verifiedReviewModel
  • plugins/vibe-core/lib/handoff/scripts/ticket-names.mjs: missingTicketNames
  • plugins/vibe-core/lib/handoff/scripts/unit-review-record.mjs: openBoardUnits, readUnitReview, unitReviewFile, unitReviewProblem
  • plugins/vibe-core/lib/vibe/scripts/cloud-environment.mjs: CLAUDE_ENV_CONFIG_KEY, CLAUDE_ENV_VAR, CloudSetupError, checkCloudSetup, cloudSetupError, createRefusal, resolveClaudeEnvironment, runNotCreated
  • plugins/vibe-core/lib/vibe/scripts/cloud-receipts.mjs: RECEIPT_NAME, TERMINAL, dispatchReceiptName, legacyRoutineName, validationReceiptName
  • plugins/vibe-core/lib/vibe/scripts/cloud-repository.mjs: CloudRepoError, INSTALL_RULES, PROVENANCE_COMMAND, codexEnvironment, installInstruction, installScript, provenanceProblem, resolveRepository
  • plugins/vibe-core/lib/vibe/scripts/cloud-routines.mjs: NO_EXECUTOR, ROUTINE_NAME, adoptStanding, chromeRemoval, hasIntent, ledgerPath, markRun, pendingCount, pendingLine, readLedger, retireRoutine, routineLockDir, runOnStanding, sweepRemovals
  • plugins/vibe-core/lib/vibe/scripts/cloud-worker.mjs: LANE_DISCIPLINE, abandonDispatch, abandonValidation, cloudPrProblem, cloudRules, codexStatus, followupClaude, generateBrief, hydrateCloudRequest, importAndSweep, importResult, parseValidationResult, pollTask, readyForPr, recordCloudEvidence, refreshImportWitness, remoteTrigger, routinesCommand, runCommand, startClaude, startCodex, validateCommit, validateRequest, validateValidationRequest, validationBrief, verifyAuthor
  • plugins/vibe-core/lib/vibe/scripts/docker-disk-admission.mjs: isContainerizedBuild, measureDockerDisk, requireDockerDisk
  • plugins/vibe-core/lib/vibe/scripts/e2e-lock.mjs: BUSY_EXIT, DUPLICATE_EXIT, ESCALATION_JUSTIFICATION, acquire, composeProjectFor, defaultLockDir, readHolder, release, runningForeignCompose, sameWorktreeEntry, tryAcquire
  • plugins/vibe-core/lib/vibe/scripts/github-remote.mjs: githubRepository
  • plugins/vibe-core/lib/vibe/scripts/harness-identity.mjs: Harness, harnessActor, harnessOfCommand, processAncestry
  • plugins/vibe-core/lib/vibe/scripts/image-head.mjs: ESCALATION_JUSTIFICATION, defaultRecordsDir, imageProblem, imageRecordFile, recordImages, reusesImages
  • plugins/vibe-core/lib/vibe/scripts/loaded-skill.mjs: LoadBasis, SKILL_RELOAD, compareSkillVersions, isSkillReload, loadedSkillEvidence, loadedSkillEvidenceProblem, loadedSkillRequired, reloadableSkill, skillReloadPage
  • plugins/vibe-core/lib/vibe/scripts/owned-builder.mjs: BUILDER_CACHE_CAP, installOwnedBuildShim, ownedBuildEnvironment, prepareRunOwnedBuild, pruneOwnedBuilder, recordBuiltTags, removeOwnedRunState, verifiedBuilder, verifyOwnedRunState
  • plugins/vibe-core/lib/vibe/scripts/owned-cleanup.mjs: hasPendingOwnedCleanups, pendingOwnedCleanups, registerFleetWriterRetirements, registerWorktreeRetirement, remainingCleanupBudget, repositoryGenerated, sweepOwnedCleanups
  • plugins/vibe-core/lib/vibe/scripts/owned-docker.mjs: captureOwnedDockerResources, plannedLocalTags, reconcileGeneratedE2E, recordE2EChild, removeOwnedDockerResources, reserveGeneratedE2E
  • plugins/vibe-core/lib/vibe/scripts/owned-state.mjs: OWNERSHIP_VERSION, canonicalWorktree, cleanupDir, dockerResult, dockerRun, e2eLockDir, e2eWaitersDir, ensureReloadFence, machineSlotLockDir, markPending, readE2eWaiters, refreshMarker, regularJson, releaseReloadFence, reloadFenceStatus, waitForReloadFence, waitsForReloadFence, writeAtomic
  • plugins/vibe-core/lib/vibe/scripts/plugin-script-references.mjs: installedPluginVersion, isVibePluginRoot, pluginScriptProblems, pluginScriptReferences
  • plugins/vibe-core/lib/vibe/scripts/provider-brief.mjs: WRITER_BRIEF, briefProviderLine, briefProviderProblem, briefWithProviderLine, providerLine
  • plugins/vibe-core/lib/vibe/scripts/provider.mjs: BUNDLED_PROVIDER_DIR, CONTRACT_FILE, Capability, PROVIDER_PROTOCOL, ProviderBroken, ProviderState, ProviderUnavailable, UNPROBED_REFUSAL, assembleProviderText, bindForRepository, boundWith, connectionLabel, exitOnProviderBroken, failScript, installedProviders, isProviderBroken, knownProviderContracts, optInProblem, parseLeadBinding, probeProvider, providerBlock, providerCandidate, providerData, providerDataOr, providerGuardRule, providerPath, providerStubs, readContract, recordedBinding, requireProvider, scriptExitCode, sessionBinding, ticketReference, unprobedBinding, useLeadBinding, useSessionWorktree
  • plugins/vibe-core/lib/vibe/scripts/repository-commands.mjs: LOCKFILE_INSTALLS, agentsTestCommand
  • plugins/vibe-core/lib/vibe/scripts/review-models.mjs: FABLE_REVIEW_MODELS
  • plugins/vibe-core/lib/vibe/scripts/sandbox-refusal.mjs: escalation, isSandboxRefusal
  • plugins/vibe-core/lib/vibe/scripts/session-record.mjs: assertVibeCreatedWorktree, git, readSessionRecord, sessionLiveTicket, sessionRecordPath, writeSessionRecord
  • plugins/vibe-core/lib/vibe/scripts/startup-record.mjs: CONVERSATION_ID, RELEASE_VERSION, VersionStatus, blockingProblem, compareVersions, installedVibeVersion, loadedSkillProblem, markPending, readJson, readStartupRecord, startupDir, startupFile, writeJson
  • plugins/vibe-core/lib/vibe/scripts/tested-head.mjs: committedFile, committedSourceIdentity, copySourceTree, sameSource, snapshotPlugins, sourceIdentity, testedHead, testedSource, treeIdentity, validSourceIdentity, withStableSource
  • plugins/vibe-core/lib/vibe/scripts/worker-scope.mjs: launcherWorker, recordWorkerScope
  • plugins/vibe-core/shared/process-identity.mjs: processIdentityStatus, readProcessIdentity, readProcessStart
  • plugins/vibe-core/shared/vibe-install.mjs: vibeEnabled, vibeInstall, vibeRoot, vibeRootOrNull, vibeScriptPath, vibeSkill

Other removed exports (each also in the generated plugins/vibe-closedloop copy where it lives under plugins/vibe):

  • dispositionProblems: plugins/vibe/skills/fleet-orchestrator/scripts/finding-brief.mjs no longer re-exports it; the one disposition rule is lib/vibe/scripts/required-visual-qa.mjs (item 58)
  • localPlanPrefix: moved to lib/vibe/scripts/session-artifact-paths.mjs
  • knownLocalPlanPrefixes: moved to lib/vibe/scripts/session-artifact-paths.mjs
  • localPlanPaths: moved to lib/vibe/scripts/session-artifact-paths.mjs
  • workflowLaneDefinitions: tools/vibe-workers/src/main-sync-ci.ts imports it from lib/vibe/scripts/workflow-lane-definitions.mjs instead of declaring it

Changed exports (each also in the generated plugins/vibe-closedloop copy where it lives under plugins/vibe):

  • shippedFiles: plugins/vibe/shared/ship-plugins.mjs: takes one vibe root and stages vibe alone (the slimming)
  • VIBE_CORE_MIN: plugins/vibe/shared/vibe-core.mjs: now the oldest vibe-core whose hooks hand over to this vibe's hooks/runtime.mjs (the slimming)
  • evaluateDiff: plugins/vibe/skills/handoff/scripts/diff-rules.mjs: changed by the earlier work of this pull request described in the Summary
  • specExecutionLimitation: plugins/vibe/skills/handoff/scripts/e2e-tier.mjs: changed by the earlier work of this pull request described in the Summary
  • rebuildStatic: plugins/vibe/skills/handoff/scripts/frozen-render.mjs: changed by the earlier work of this pull request described in the Summary
  • TEST_SELECTORS: plugins/vibe/skills/handoff/scripts/pr-evidence-schema.mjs: changed by the earlier work of this pull request described in the Summary
  • readTestSelection: plugins/vibe/skills/handoff/scripts/pr-evidence-schema.mjs: changed by the earlier work of this pull request described in the Summary
  • prEvidenceShapeProblems: plugins/vibe/skills/handoff/scripts/pr-evidence-schema.mjs: changed by the earlier work of this pull request described in the Summary
  • selectionProblems: plugins/vibe/skills/handoff/scripts/pr-facts.mjs: changed by the earlier work of this pull request described in the Summary
  • targetedEvidenceProblems: plugins/vibe/skills/handoff/scripts/pr-facts.mjs: changed by the earlier work of this pull request described in the Summary
  • APPROVE_HOOKS: plugins/vibe/skills/vibe/scripts/vibe-core-hooks.mjs: changed by the earlier work of this pull request described in the Summary
  • hookStandDown: plugins/vibe-core/shared/vibe-install.mjs: takes the install found by vibeLookup; absence is now the lookup's own state (the slimming)
  • writePrivateReply: tools/vibe-bench/src/private-artifact.ts: changed by the earlier work of this pull request described in the Summary
  • safeFailure: tools/vibe-workers/src/claude-worker.ts: changed by the earlier work of this pull request described in the Summary
  • readInput: tools/vibe-workers/src/contracts.ts: changed by the earlier work of this pull request described in the Summary
  • changeWriter: tools/vibe-workers/src/ledger.ts: changed by the earlier work of this pull request described in the Summary
  • readMainSyncInput: tools/vibe-workers/src/main-sync.ts: changed by the earlier work of this pull request described in the Summary

Test files gone from vibe-core (each moved, unchanged or as listed above, to the same path under plugins/vibe):

  • plugins/vibe-core/hooks/activation.test.mjs
  • plugins/vibe-core/hooks/agent-guard.test.mjs
  • plugins/vibe-core/hooks/away-protocol.test.mjs
  • plugins/vibe-core/hooks/context-guard.test.mjs
  • plugins/vibe-core/hooks/fleet-resume.test.mjs
  • plugins/vibe-core/hooks/foreground-guard.test.mjs
  • plugins/vibe-core/hooks/guard-install.test.mjs
  • plugins/vibe-core/hooks/kill-guard.test.mjs
  • plugins/vibe-core/hooks/merge-guard.test.mjs
  • plugins/vibe-core/hooks/pause-guard.test.mjs
  • plugins/vibe-core/hooks/plugin-version-guard.test.mjs
  • plugins/vibe-core/hooks/pr-create-guard.test.mjs
  • plugins/vibe-core/hooks/pre-tool-use.test.mjs
  • plugins/vibe-core/hooks/program-change.test.mjs
  • plugins/vibe-core/hooks/protected-write-guard.test.mjs
  • plugins/vibe-core/hooks/question-guard.test.mjs
  • plugins/vibe-core/hooks/shell-safety-guard.test.mjs
  • plugins/vibe-core/hooks/skill-transcript.test.mjs
  • plugins/vibe-core/hooks/unit-status-guard.test.mjs
  • plugins/vibe-core/lib/codex-fleet-monitor/scripts/liveness.test.mjs
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/fleet-home.test.mjs
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/helpers.test.mjs
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/scratch-stack.test.mjs
  • plugins/vibe-core/lib/fleet-orchestrator/scripts/skill-freshness.test.mjs
  • plugins/vibe-core/lib/handoff/scripts/codex-review-runtime.test.mjs
  • plugins/vibe-core/lib/handoff/scripts/handoff-evidence.test.mjs
  • plugins/vibe-core/lib/handoff/scripts/review-premises.test.mjs
  • plugins/vibe-core/lib/handoff/scripts/review-receipts.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/cloud-environment.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/cloud-repository.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/cloud-worker.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/docker-disk-admission.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/e2e-lock.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/harness-identity.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/image-head.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/owned-builder.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/owned-cleanup.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/owned-docker.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/provider.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/sandbox-refusal.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/startup-record.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/tested-head.test.mjs
  • plugins/vibe-core/lib/vibe/scripts/worker-scope.test.mjs
  • plugins/vibe-core/shared/plugin-roots.test.mjs
  • plugins/vibe-core/shared/vibe-install.test.mjs

Assertion lines changed, by file (the reason is in Deliberate test changes above unless given here):

  • plugins/vibe/shared/vibe-core.test.mjs:44, plugins/vibe/shared/vibe-core.test.mjs:93, plugins/vibe/shared/vibe-core.test.mjs:121, plugins/vibe/shared/vibe-core.test.mjs:126, plugins/vibe/shared/vibe-core.test.mjs:162
  • plugins/vibe/skills/codex-fleet-monitor/scripts/hook-approval.test.mjs:67, plugins/vibe/skills/codex-fleet-monitor/scripts/hook-approval.test.mjs:75 (the hook approval step text is APPROVE_HOOKS now (item 67, DT-S12); the test reads the constant)
  • plugins/vibe/skills/codex-fleet-monitor/scripts/recover.test.mjs:403
  • plugins/vibe/skills/codex-fleet-monitor/scripts/snapshot.test.mjs:114
  • plugins/vibe/skills/fleet-orchestrator/scripts/board.test.mjs:391, plugins/vibe/skills/fleet-orchestrator/scripts/board.test.mjs:398
  • plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:509, plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:755, plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:776, plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:780, plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:781, plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:782 (the --capture tests moved byte-for-byte to fleet-capture.test.mjs (file-length ceiling), and the earlier changes this body describes)
  • plugins/vibe/skills/fleet-orchestrator/scripts/instruction-words.test.mjs:72
  • plugins/vibe/skills/fleet-orchestrator/scripts/ticket-units.test.mjs:107 (the run passes a body with its Delivers line (the fold-by-default delivery placement, ISS-14374))
  • plugins/vibe/skills/handoff/scripts/diff-rules.test.mjs:187 (the fix now names frozen-render-gate.mjs (ISS-14395))
  • plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs:200, plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs:263, plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs:270, plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs:314, plugins/vibe/skills/handoff/scripts/frozen-render.test.mjs:315 (the base story renders once, so the second base render and its visits are gone (ISS-14395))
  • plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:134, plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:153, plugins/vibe/skills/handoff/scripts/handoff-gate-members.test.mjs:154
  • plugins/vibe/skills/handoff/scripts/pr-facts.test.mjs:892
  • plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:26, plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:27, plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:28, plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:29
  • plugins/vibe/skills/handoff/scripts/storybook-rules.test.mjs:79, plugins/vibe/skills/handoff/scripts/storybook-rules.test.mjs:80
  • plugins/vibe/skills/handoff/scripts/test-integrity.test.mjs:164, plugins/vibe/skills/handoff/scripts/test-integrity.test.mjs:826
  • plugins/vibe/skills/vibe/scripts/plugin-version-bootstrap.test.mjs:109, plugins/vibe/skills/vibe/scripts/plugin-version-bootstrap.test.mjs:110, plugins/vibe/skills/vibe/scripts/plugin-version-bootstrap.test.mjs:111
  • plugins/vibe/skills/vibe/scripts/push-ready-contract.test.mjs:84, plugins/vibe/skills/vibe/scripts/push-ready-contract.test.mjs:88
  • plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:381, plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:898, plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:904, plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:906, plugins/vibe/skills/vibe/scripts/vibe-triage.test.mjs:911
  • tools/vibe-bench/src/phase3.test.ts:122, tools/vibe-bench/src/phase3.test.ts:400, tools/vibe-bench/src/phase3.test.ts:404, tools/vibe-bench/src/phase3.test.ts:629, tools/vibe-bench/src/phase3.test.ts:1573
  • tools/vibe-closedloop-build/src/build.test.ts:92, tools/vibe-closedloop-build/src/build.test.ts:94
  • tools/vibe-workers/src/claude-worker.test.ts:63, tools/vibe-workers/src/claude-worker.test.ts:391, tools/vibe-workers/src/claude-worker.test.ts:420, tools/vibe-workers/src/claude-worker.test.ts:421, tools/vibe-workers/src/claude-worker.test.ts:422, tools/vibe-workers/src/claude-worker.test.ts:423, tools/vibe-workers/src/claude-worker.test.ts:545, tools/vibe-workers/src/claude-worker.test.ts:1009, tools/vibe-workers/src/claude-worker.test.ts:1011, tools/vibe-workers/src/claude-worker.test.ts:1183
  • tools/vibe-workers/src/ledger.test.ts:302
  • tools/vibe-workers/src/runtime-contract.test.ts:162, tools/vibe-workers/src/runtime-contract.test.ts:165
  • tools/vibe-workers/src/scope-intake.test.ts:54
  • tools/vibe-workers/src/writer-migration.test.ts:685

Overlap with open pull requests

How it was checked

  • Targeted runs at the final head 7a7d393 under Daniel's R-TARGETED-TESTS (programs/vibe-bugs/rulings.md; orchestrator decisions 29 and 30): every changed JS/TS test file (147) and every unchanged test that imports changed code (79), 226 files and 3,398 cases, one file per process, all passing; plus the Python contracts (676/676), the evals runner (79/79), tsc for vibe-workers, vibe-bench and vibe-closedloop-build, and fleet.test.mjs and fleet-capture.test.mjs under both macOS /bin/bash 3.2 and bash 5. Every ci.yml lane is recorded not-run, covered by PR CI. The plugin-manifest-versions job was reproduced from a clean export (typecheck, 62/62).
  • The bundle guard test checks the vibe-core allowlist, import closure, 900-line budget and the Codex fingerprint against the real trusted_content_hash for installed vibe-core 1.0.13 and code 2.0.2: 62/62 with the digest pinned last.
  • The vibe-closedloop build was rebuilt after the last source change; a second rebuild produced no diff.
  • Handoff reviews through the Claude launcher, round 18 (adversarial, guardrails, Storybook decomposer, verifier):
    • 18a (frozen tree 8fa36c7f): adversarial found 6 (4 blocking: names, and generic-scan and contract failures that went to two helper fixes; ADV-5 became a known edge; ADV-6 was fixed). Guardrails and verify did not launch because a brief named a branch-only plugin script by a relative path, which the installed launcher's script check refuses; later briefs use absolute frozen paths.
    • 18b (snapshot a81534c8): guardrails 0 blocking (advisory: as casts in plugin-manifests TypeScript), verify 0 blocking, Storybook decomposer done, adversarial 2 low (test-support shipped in the build, fixed; a stale stub text, fixed). The adversarial receipt was marked WORKER_TURN_FAILED because the live tree was edited during its run, so the final rounds ran with no edits.
    • 18c (frozen tree 26b154c3): adversarial, verify and decomposer clean; guardrails blocked fleet.test.mjs at 1070 lines (over the 1000-line ceiling), fixed by a split by responsibility into fleet.test.mjs and fleet-capture.test.mjs with byte-identical test bodies, plus a bash 3.2 variant of the admission refusal test.
    • 18d (tree 56011313): all four roles clean (0 findings).
    • Running every changed test at the committed merge then found three reds the merge produced (the 1.1.103 changelog word line, main's push-ready-contract assertion on moved prose, and the hook test's missing cwd) and one review-class-guard red in a related test (an unchecked spawn status); each was fixed and reviewed: 18e and 18f, all four roles, 0 blocking. The inventory then flagged two duplicate helpers on new lines in core vibe-install.mjs; core plugin-roots.mjs now exports them (orchestrator decision 34), reviewed in 18g: all four roles, 0 findings.
    • The receipts the gate reads are bound to 7a7d393.
  • Eight absence proofs (four in tools/vibe-workers/src/claude-worker.test.ts, four in the new plugin-manifests tests) were run at 7a7d393 in a clean export: each mutation failed at its assertion and each restore passed.
  • Environment-only reds earned on the final tree (not product failures): the owned-cleanup tests under env -i (the same 9 fail on main 0673f59 under env -i; all 24 pass with the normal environment), and the question-guard and pre-tool-use relative-path tests, which depend on the working directory (run question-guard from the repository root and pre-tool-use from a neutral directory). Hook tests run with CLAUDE_CODE_SESSION_ID unset.
  • The handoff inventory at 7a7d393 against main 0673f59: PR evidence clean, no forbidden paths, decision tables current; the remaining diff-rule findings are the ones the override line below names.

Known main failures

  • None this push: no ci.yml lane ran locally (R-TARGETED-TESTS); the owned-cleanup env -i reds above match main under the same env.

Disclosures

  • The Codex writer stopped when Codex vibe moved 1.1.97 to 1.1.100 and removed its recorded definition; the writer moved to Claude with vibe's supported writer-state.mjs migrate harness switch.
  • The installed Claude vibe here is 1.1.97, older than this PR's 1.1.103. The inventory, gate and lane records ran from this PR's own code (as with ISS-14162: Fix the quarantined vibe eval cases #437 under the 2026-11-17 "run the worktree's gate" ruling); the reviewers ran through the installed 1.1.97 launcher.
  • The session's provider binding pointed at the removed Codex 1.1.97 folder, so every handoff script threw ProviderBroken. This PR's adopt fix (above) rebound it to the installed provider.
  • Claude cloud validate did not finish from the local machine: its local claude -p RemoteTrigger calls timed out under load (spawnSync ETIMEDOUT), and one completed run was refused because a lane reported no exit code. No lane ran locally this push; see How it was checked.
  • The DT-N03 post-fix Claude cloud eval probe (ISS-14355) is still open and lands with the next push on this PR.
  • The verifier evidence file was assembled by the writer from the lane logs, the qa-impact result, the E2E probe and the mutation receipts (builder and inputs kept in the session's git directory); the final verifier review checked it read-only.
  • Instruction words: ISS-14137's criterion says the plugin's instruction length does not grow. Daniel ruled "Shrink more, then accept"; prose was compressed and how-to moved into the tools' messages. The leftover ships disclosed: Against main 0673f59, vibe is about 1065 words longer, vibe-closedloop-provider about 65 longer and closedloop-core about 16 longer, and vibe-core about 126 shorter; the instruction-words changelog check passes and matches the CHANGELOG word line. By file, net growth against main (instruction-words counter, per file): plugins/vibe/agents/vibe-change-worker.md +322, plugins/vibe/skills/fleet-orchestrator/references/templates.md +225, plugins/vibe/skills/vibe/SKILL.md +140, plugins/vibe/skills/vibe/references/quality-loop.md +114, plugins/vibe/skills/handoff/SKILL.md +100, plugins/vibe/skills/vibe/references/review-premises.md +99, plugins/vibe/skills/vibe/references/guardrails.md +98, the provider's vibe-ticket-worker.md +93, plugins/vibe/skills/fleet-orchestrator/SKILL.md +90, the provider's vibe-environment-worker.md +72, fleet-codex-sessions.md +68, vibe-guardrails-reviewer.md +60; the largest cuts are vibe-storybook-decomposer.md -379, the provider's vibe-verify-worker.md -276 (its evidence guide moved into pr-evidence-schema.mjs --example), vibe-harness-claude.md -168 and the vibe-core README -126. The growth in each listed file is rule text for the defects this PR prevents that no check enforces (orchestrator decision 16), after the compression Daniel's ruling asked for.
  • The shim's per-event cost is the re-measurement above, taken at load 32; the differences between the two columns are within noise and no speedup or slowdown is claimed.
  • An earlier proof run on a second machine failed for reasons this PR fixes, plus two harness settings of that run (umask 077 and an exported VITEST_MAX_WORKERS=8) that CI does not use.

Vibe gate override: ISS-14476: handoff gate: diff rules read 139 pure moves as new code because each old vibe-core path now holds a stub (ISS-14476 item 78); the cross-plugin enabled-check copy in vibe/shared/vibe-install.mjs and vibe-core/shared/vibe-install.mjs is intended (neither plugin may import the other); the Codex fingerprint comparator sorts unique directory entry names, matching Codex.

Orchestrator decisions (operator may override)

These were decided by the orchestrator or proceeded on a stated default; each carries its source.

  • Diff rules skip generated build output through the shared predicate: a generator-header signal applies to every diff rule except duplicate-helper, which keeps its bundle-aware check and a linguist-only skip (orchestrator decisions 7 and 13). The predicate is plugins/vibe/skills/handoff/scripts/generated-files.mjs (a base linguist-generated attribute, a minified path, or a generator comment in the first five lines that the base already had), and duplicate-helper calls it with header: false (plugins/vibe/skills/handoff/scripts/diff-rules.mjs:215).
  • The inventory, gate and lane records ran from this PR's own vibe code, as under the 2026-11-17 ruling for ISS-14162: Fix the quarantined vibe eval cases #437 (Daniel, 2026-11-17: run the worktree's gate).
  • vibe's own vibe-install.mjs keeps the per-cwd first-enabled lookup (orchestrator decision 24).
  • The protected-write-guard stub exits 0 and the other 76 stubs exit 1 (orchestrator decision 28, applying Daniel's D2 "never refuse").
  • Overlapping PR ISS-13724: Admit an e2e suite's support modules #439 is left alone (orchestrator decision 25).
  • The DT-N03 post-fix cloud probe (ISS-14355) lands with a later push (orchestrator decision 8 sequencing).
  • The ISS-14137 agent-decision rule stays blocking; its remaining regex edges are fixed in later pushes (orchestrator, earlier push).
  • tools-ts[vibe-workers] is recorded main-preexisting for the main-sync timeouts (orchestrator decision 20 evidence rule; see Known main failures).

Follow-ups on this PR (next pushes)

  • ISS-14395 integration (frozen-render), then items 12 and 17 to 30 of the prevention list.
  • The known edges listed under vibe-core slimming, including item 76 and the launcher's branch-only script refusal; item 40 (PR body claims cite the diff) and bounding the node-tests hang (item 9) per orchestrator decisions 10 and 20.
  • Placement checked when the gate records the body (adversarial F3), and one member-ticket title rule for the gate and fleet ticket-units (adversarial F4).

Stack

The base is main.

Move every ClosedLoop and symphony-alpha specific line out of vibe and
vibe-core into the new optional vibe-closedloop-provider plugin, which ships
text and data only. With the provider bound, sessions keep today's behavior;
without it, vibe and fleet work from the repository itself: the person's
description, plans in the private git directory, the AGENTS.md test command,
the lockfile install, and a requested PR or named recipient at the end.

- provider binding, provider text assembly and data access in vibe-core
- guards read their rules from the bound provider and stay silent outside
  an activated chat
- main sync gates its provider-only machinery on the provider's recipe
- the recipes opt-in file is validated and withholds recipes with one reason
- the provider is offered for install once, never re-enabled or reinstalled
- generic scan gate, generic walk fixture, eval arms, and generic twins for
  the provider-bound tests
- vibe 1.1.81, vibe-core 1.0.5, vibe-closedloop-provider 1.0.0
- writer ledgers parse capabilities by shape; grants are checked against the
  session binding at register and launch
- the Claude launcher resolves provider text for its roles
- writers inherit the lead's binding through a Provider line, enforced by the
  Codex launcher, the Claude launcher and the Agent guard
- the recipes opt-in file is validated and judged in the session repository
- adopting a session keeps its binding; moved provider releases re-resolve
- every installed provider's plan folder stays private
- generic fleet recovery ids and duties, the worktree exclude rule, the
  guardrails formatter from the verify recipe
- dangling reference paths fixed, provider text free of ticket ids and home
  paths, the inventory snapshot and mapping checked in pytest
- the eval provider arm installs provider-resolved text
- bundles build byte-identically from any working directory
Bind the tracker in the tracker-duty tests, run spawned scripts outside the
real checkout so the cwd repository leg cannot pick it, derive the provider
line in fleet tests from the fixture binding, fix the shadowed prototype
deploymentHost check and rebuild dist, list provider.mjs as a vibe-core
wrapper, and record the changelog word count.
Pass the lead's binding to remote fleet writers, read the recipes opt-in
from the main checkout for older sessions and for a named checkout, know
UI files by extension without an areas recipe, never write a legacy
provider record generic, keep old hook scope records active, restore the
exact ticket pattern for Prior removal, keep clerkOrgId for older vibe,
report a main sync with no check as needing review, require the sole
workflow for an undeclared lane source, keep generic plans in the common
git dir, move the repository E2E text into provider blocks, and stop
offering an install over an unreadable provider.
…c-vibe-v2

# Conflicts:
#	CHANGELOG.md
#	plugins/vibe/.claude-plugin/plugin.json
#	plugins/vibe/.codex-plugin/plugin.json
…ider

- provider.mjs assemble writes a vibe file merged for the session's
  binding, and assemble --blocks gives every bound block of a loaded
  SKILL.md in one call; the reading rules use them
- each generic region and its provider block share their identical lines
  once, so assembled text is unchanged and the provider is smaller
- only an unbound capability falls back to the generic text: a bound
  provider that is gone, a missing block or an unreadable record stops
  with its reason and fix (exit 4) in the CLI, the launcher, every script
  and the hooks, and a guard refuses the action it guards
- session records are written whole and renamed into place
- the 1.1.82 word count is measured at this tree
ISS-14039 (#427) took vibe 1.1.82 and vibe-core 1.0.5. Keep both sides of
the claude-worker launcher (the broken-provider mapping and the review
model), rebuild the bundles, drop the ticket slugs the merge brought into
runtime files, and remeasure the word count against the new main.
ISS-14028 and ISS-14024 (#428) took vibe 1.1.84 and vibe-core 1.0.7. The
unit-status guard keeps the bound provider's rule and gains the chat's
own program board; its tests keep both cases. The fleet-resume header
covers both changes, the bundles are rebuilt, the ticket slugs the merge
brought into runtime comments are dropped, the launcher mark written into
installed launchers stays as an allowlisted compatibility line, and the
word count is remeasured against the new main.
…e check

A bound session now behaves like main. The start is one version check when the
provider skill's description names its calls, and --closedloop/--graph are
accepted again as aliases of --connection; otherwise the read-only provider
probe runs first, and a check with no states records unprobed instead of
binding generic. Each capability binds on its own connection, so a missing
graph keeps the ClosedLoop text and restores the graph. The check writes the
bound text once per repository and binding, and readers open files from that
folder instead of assembling each one. check always exits 0 and prints the
setup block in every state.

Also: precedent stays live-only, a brief without a Provider: line inherits the
lead's binding, the preflight finds the checkout as main did when bound,
vibe-bench binds through the real check, and the eval runner gains a
provider-installed arm.
…-generic

- tools/vibe-closedloop-build assembles plugins/vibe plus the provider into
  the committed plugins/vibe-closedloop (the `vibe` entry), with cold
  deploy and environment sections in their own files, recipes inline, and a
  CI drift check. plugins/vibe is published as `vibe-generic`.
- Retire runtime provider text: the rule paragraph (two generic sentences
  stay, dropped by the build), provider-text.md, the bind-time folder,
  model-run assemble/block/path/tree, the install offer, provider-install,
  provider-match, the skill-listed flag and the provider skill. Discovery
  reads only the provider bundled in vibe.
- Each install finds its own plugin name and marketplace; with both
  installed the ClosedLoop vibe runs the hooks and binds, and the check
  reports both-installed.
- Eval arms install the built folder (with the repository opt-in file in the
  case folder) and plugins/vibe as `vibe`; no harness assembly.
- Resolve run.py's private homes and every main guard to real paths.
…the word-count entry

- provider.mjs knownProviderContracts lists the provider bundled in every
  vibe install or checkout, enabled or not; local-plans uses it so a plan
  written while bound stays private when the session is not, whichever vibe
  the lookup order picks. Binding and lookup orders are unchanged.
- The vibe CHANGELOG entry names the full Markdown scope of its word count
  again, with the generated folder's exclusion stated after it.
… 1.1.97

- The build places the provider's whole-file references (ticket-template,
  closedloop-graph, ticket-units) at main's paths in plugins/vibe-closedloop
  and rewrites provider: names to main's relative forms; provider/ holds only
  provider.json, whose placed map providerPath resolves through. A build test
  requires every Markdown file reference in the built tree to resolve.
- vibe 1.1.97, vibe-core 1.0.13 (VIBE_CORE_MIN raised to it); #432's new
  cloud code follows the branch's generic rules.
- Bind responsive proofs to exact assertions and viewport-width mutations
- Resolve test-only constant-null helpers with the bundled TypeScript AST
- Fail closed on partial importer evidence and stale decision-table records
- Mirror the verified cloud-eval route and precise continuation guidance
- Prevent shared-consumer, story, premise, grant and reviewer-relaunch misses

Testing: Ran focused handoff, worker, provider and Python contract tests,
worker/provider typechecks, provider build tests, generic scan, and diff checks

Risks: Strict proof validation may require regenerating incomplete private receipts
Folds ISS-14366, ISS-14374, ISS-14375 and the ISS-14116 groups into one prevention change, merged with main 0057c43 (#437).
vibe-core now holds only the hook registrations, five entry files and a loader that runs hooks/runtime.mjs from the vibe a session uses; the guards and modules move back to vibe at the same paths. Merges main 0673f59 (#433).
@shafty023 shafty023 changed the title ISS-14116: Prevent the reported vibe bugs and merge main ISS-14116: Slim vibe-core and prevent the reported vibe bugs Nov 19, 2026
@shafty023
shafty023 merged commit 123c0d9 into main Nov 19, 2026
13 checks passed
@shafty023
shafty023 deleted the vibe/iss-14116-prevention-2 branch November 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant