Repository navigation
ISS-14116: Slim vibe-core and prevent the reported vibe bugs - #438
Merged
Merged
Conversation
Move every ClosedLoop and symphony-alpha specific line out of vibe and vibe-core into the new optional vibe-closedloop-provider plugin, which ships text and data only. With the provider bound, sessions keep today's behavior; without it, vibe and fleet work from the repository itself: the person's description, plans in the private git directory, the AGENTS.md test command, the lockfile install, and a requested PR or named recipient at the end. - provider binding, provider text assembly and data access in vibe-core - guards read their rules from the bound provider and stay silent outside an activated chat - main sync gates its provider-only machinery on the provider's recipe - the recipes opt-in file is validated and withholds recipes with one reason - the provider is offered for install once, never re-enabled or reinstalled - generic scan gate, generic walk fixture, eval arms, and generic twins for the provider-bound tests - vibe 1.1.81, vibe-core 1.0.5, vibe-closedloop-provider 1.0.0
- writer ledgers parse capabilities by shape; grants are checked against the session binding at register and launch - the Claude launcher resolves provider text for its roles - writers inherit the lead's binding through a Provider line, enforced by the Codex launcher, the Claude launcher and the Agent guard - the recipes opt-in file is validated and judged in the session repository - adopting a session keeps its binding; moved provider releases re-resolve - every installed provider's plan folder stays private - generic fleet recovery ids and duties, the worktree exclude rule, the guardrails formatter from the verify recipe - dangling reference paths fixed, provider text free of ticket ids and home paths, the inventory snapshot and mapping checked in pytest - the eval provider arm installs provider-resolved text - bundles build byte-identically from any working directory
Bind the tracker in the tracker-duty tests, run spawned scripts outside the real checkout so the cwd repository leg cannot pick it, derive the provider line in fleet tests from the fixture binding, fix the shadowed prototype deploymentHost check and rebuild dist, list provider.mjs as a vibe-core wrapper, and record the changelog word count.
Pass the lead's binding to remote fleet writers, read the recipes opt-in from the main checkout for older sessions and for a named checkout, know UI files by extension without an areas recipe, never write a legacy provider record generic, keep old hook scope records active, restore the exact ticket pattern for Prior removal, keep clerkOrgId for older vibe, report a main sync with no check as needing review, require the sole workflow for an undeclared lane source, keep generic plans in the common git dir, move the repository E2E text into provider blocks, and stop offering an install over an unreadable provider.
…c-vibe-v2 # Conflicts: # CHANGELOG.md # plugins/vibe/.claude-plugin/plugin.json # plugins/vibe/.codex-plugin/plugin.json
…ider - provider.mjs assemble writes a vibe file merged for the session's binding, and assemble --blocks gives every bound block of a loaded SKILL.md in one call; the reading rules use them - each generic region and its provider block share their identical lines once, so assembled text is unchanged and the provider is smaller - only an unbound capability falls back to the generic text: a bound provider that is gone, a missing block or an unreadable record stops with its reason and fix (exit 4) in the CLI, the launcher, every script and the hooks, and a guard refuses the action it guards - session records are written whole and renamed into place - the 1.1.82 word count is measured at this tree
ISS-14039 (#427) took vibe 1.1.82 and vibe-core 1.0.5. Keep both sides of the claude-worker launcher (the broken-provider mapping and the review model), rebuild the bundles, drop the ticket slugs the merge brought into runtime files, and remeasure the word count against the new main.
ISS-14028 and ISS-14024 (#428) took vibe 1.1.84 and vibe-core 1.0.7. The unit-status guard keeps the bound provider's rule and gains the chat's own program board; its tests keep both cases. The fleet-resume header covers both changes, the bundles are rebuilt, the ticket slugs the merge brought into runtime comments are dropped, the launcher mark written into installed launchers stays as an allowlisted compatibility line, and the word count is remeasured against the new main.
…e check A bound session now behaves like main. The start is one version check when the provider skill's description names its calls, and --closedloop/--graph are accepted again as aliases of --connection; otherwise the read-only provider probe runs first, and a check with no states records unprobed instead of binding generic. Each capability binds on its own connection, so a missing graph keeps the ClosedLoop text and restores the graph. The check writes the bound text once per repository and binding, and readers open files from that folder instead of assembling each one. check always exits 0 and prints the setup block in every state. Also: precedent stays live-only, a brief without a Provider: line inherits the lead's binding, the preflight finds the checkout as main did when bound, vibe-bench binds through the real check, and the eval runner gains a provider-installed arm.
…-generic - tools/vibe-closedloop-build assembles plugins/vibe plus the provider into the committed plugins/vibe-closedloop (the `vibe` entry), with cold deploy and environment sections in their own files, recipes inline, and a CI drift check. plugins/vibe is published as `vibe-generic`. - Retire runtime provider text: the rule paragraph (two generic sentences stay, dropped by the build), provider-text.md, the bind-time folder, model-run assemble/block/path/tree, the install offer, provider-install, provider-match, the skill-listed flag and the provider skill. Discovery reads only the provider bundled in vibe. - Each install finds its own plugin name and marketplace; with both installed the ClosedLoop vibe runs the hooks and binds, and the check reports both-installed. - Eval arms install the built folder (with the repository opt-in file in the case folder) and plugins/vibe as `vibe`; no harness assembly. - Resolve run.py's private homes and every main guard to real paths.
…the word-count entry - provider.mjs knownProviderContracts lists the provider bundled in every vibe install or checkout, enabled or not; local-plans uses it so a plan written while bound stays private when the session is not, whichever vibe the lookup order picks. Binding and lookup orders are unchanged. - The vibe CHANGELOG entry names the full Markdown scope of its word count again, with the generated folder's exclusion stated after it.
… 1.1.97 - The build places the provider's whole-file references (ticket-template, closedloop-graph, ticket-units) at main's paths in plugins/vibe-closedloop and rewrites provider: names to main's relative forms; provider/ holds only provider.json, whose placed map providerPath resolves through. A build test requires every Markdown file reference in the built tree to resolve. - vibe 1.1.97, vibe-core 1.0.13 (VIBE_CORE_MIN raised to it); #432's new cloud code follows the branch's generic rules.
- Bind responsive proofs to exact assertions and viewport-width mutations - Resolve test-only constant-null helpers with the bundled TypeScript AST - Fail closed on partial importer evidence and stale decision-table records - Mirror the verified cloud-eval route and precise continuation guidance - Prevent shared-consumer, story, premise, grant and reviewer-relaunch misses Testing: Ran focused handoff, worker, provider and Python contract tests, worker/provider typechecks, provider build tests, generic scan, and diff checks Risks: Strict proof validation may require regenerating incomplete private receipts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: ISS-14116.
Complete in this push: ISS-14375, ISS-14163, ISS-14217, ISS-14128, ISS-14058, ISS-14171, ISS-14186, ISS-14221, ISS-14223, ISS-14222, ISS-14216, ISS-14193, ISS-14184, ISS-14172, ISS-14137, ISS-14192, ISS-14037, ISS-14252, ISS-14224, ISS-14258, ISS-14259, ISS-14304, ISS-14307, ISS-14117, ISS-14324, ISS-14336 and ISS-14325 (duplicate-helper indexing only).
Also in this push, under ISS-14116: the vibe-core slimming (Daniel ruled it ships in this PR; see "vibe-core slimming" below).
Linked, continuing in later pushes on this PR: ISS-14116 (item 12), ISS-14374 (items 17, 20, 22 to 25, 27 to 30), ISS-14366 (item 13), ISS-14387 (items 18 and 19), ISS-14394 (items 21 and 26), ISS-14355 (the post-fix Claude cloud eval probe) and ISS-14395 (frozen render, the next push).
Delivery placement: unrelated: gate-misfires (#433) delivers only ISS-14136, ISS-14127 and ISS-14112; fleet-home-binding and cloud-routines deliver ISS-14028, ISS-14024, ISS-13998 and ISS-14140; the ISS-14116 prevention work is one PR of its own (Daniel, 2026-11-16: all the bug fixes in a single PR).
github_token_missingas a setup step, and treats an archived task as terminal (plugins/vibe/lib/vibe/scripts/cloud-worker.mjs:310, plugins/vibe/lib/vibe/scripts/cloud-worker.mjs:396).Delivery placement:line naming the open unit that takes the work, or why it is unrelated (plugins/vibe/lib/fleet-orchestrator/scripts/delivery-placement.mjs:88).linguist-generatedthrough its source (plugins/vibe/skills/handoff/scripts/diff-rules.mjs); the ISS-14252 input-set and ISS-14137 agent-decision rules no longer fire on unrelated lines;plugin-version.mjs adoptrebinds a session whose recorded provider folder a plugin update removed (plugins/vibe/skills/vibe/scripts/plugin-version.mjs:976); the decision-table gate holds a later Not aligned statement (plugins/vibe/lib/handoff/scripts/decision-table-gate.mjs:104); fleet.sh again puts prompt evidence and rulings at the stable remote path briefs name (plugins/vibe/skills/fleet-orchestrator/scripts/fleet.sh:63).vibe-core slimming
Why: vibe-core held every guard and module the hooks run (148 files, 1.79 MB), and 12 of its releases in 8 days each made every Codex user re-approve its hooks. Codex's trust hash covers every file under the plugin root, so any change to a guard re-triggered approval.
What it is now:
Cost of the shim, re-measured after the runtime switched to lazy imports (load 32, median of 11 runs, milliseconds; through vibe-core versus vibe's entry run directly; bare node is 60):
The two columns are within noise of each other under that load (the PreToolUse direct run was the slower one), so the shim's extra cost is not distinguishable from noise.
Codex users re-approve vibe-core's hooks once for this release, and afterwards only when its thin set changes.
Matrix tests: plugins/vibe/shared/vibe-core-skew.test.mjs (24 cases), vibe-core-skew-static.test.mjs (8) and vibe-state-skew.test.mjs (5) run the skew matrix against the frozen stubs and the loader; the notice test asserts presence on UserPromptSubmit and absence on PreToolUse, PostToolUse, SessionStart and PreCompact. Each passes in the final-head run under How it was checked.
Two further fixes in this push: gh pr create on an override path (head ownership or session record overridden) takes
VISUAL_QA_FINDINGS=<findings.json>inline and checks it for the PR head as merge-guard does (ADV-R16-3, DT-S14); a remote or no-worktree ready row whose binding declares no UI paths now needs findings for its head (ADV-R16-4, DT-S15).Known edges, recorded and not built, for the next push:
Rulings
vibe/iss-14116-prevention-2; the old remote branch stays.Deliberate test changes
Every changed assertion below is tied to a contract this PR changes. The first group is the slimming and the round 16 rulings, taken from the diff between the pre-move tree (cca21870) and the final tree. The second group is the earlier changes against main (0673f59), with line numbers checked on the final tree.
Slimming and round 16 (cca21870 to the final tree)
Moves with no change to a case (rename similarity 100%): the hook and lib tests that moved from plugins/vibe-core to plugins/vibe at the same relative paths, the files git reports as 100% renames. plugins/vibe-core/hooks/activation-test-support.mjs became a stub and its helper moved to plugins/vibe/hooks/activation-test-support.mjs. The capture cases of fleet.test.mjs moved unchanged to plugins/vibe/skills/fleet-orchestrator/scripts/fleet-capture.test.mjs (the usage assertion is at fleet-capture.test.mjs). The SIGTERM capture tests await the process exit, as main's do.
Changed assertions, by contract:
Moved paths (the modules and hooks now live in plugins/vibe; the expected strings follow): plugins/vibe/skills/handoff/scripts/review-premises-contract.test.mjs:26 to :29; plugins/vibe/skills/vibe/scripts/generic-walk.test.mjs:66 and :70; plugins/vibe/skills/fleet-orchestrator/scripts/fleet-atomic-install.test.mjs:12; plugins/vibe/evals/codex/test_run.py:202, :212 and :216; plugins/vibe/tools/python/test_vibe_1078_lessons_contract.py:74, test_vibe_1081_lessons_contract.py and test_vibe_iss_14228_contract.py; plugins/vibe/tools/python/test_vibe_generic_scan.py:57; tools/vibe-workers/src/claude-worker.test.ts:7, tools/vibe-workers/src/main-sync-producer-read.test.ts:5, :16 and :17, and tools/vibe-workers/src/runtime-contract.test.ts:5; tools/vibe-bench/src/phase2.test.ts:48 and phase3.test.ts; plugins/vibe/lib/vibe/scripts/cloud-worker.test.mjs:21 (the lane command path); plugins/vibe/skills/codex-fleet-monitor/scripts/snapshot.test.mjs:114 and :127 to :134 (the remote watcher ships vibe's lib files).
vibe-core is no longer staged remotely, and a remote host carries vibe alone: plugins/vibe/skills/fleet-orchestrator/scripts/fleet-plugin-preflight.test.mjs:15 to :28 (the shipment holds only plugins/vibe, and the staged-plugin check no longer takes a vibe-core minimum); plugins/vibe/skills/fleet-orchestrator/scripts/fleet.test.mjs:495 to :509 (the shipped tree is vibe laid out as a checkout) and :586 onward (a remote slot stages vibe's root and nothing from vibe-core; the tar collision fixture names the vibe path).
Moved commands run without vibe-core: plugins/vibe/skills/vibe/scripts/plugin-version-bootstrap.test.mjs:26 and :106 to :112 (a moved command such as fleet-home.mjs resume now exits 0 and prints NO-ACTIVE-PROGRAM from vibe's own lib instead of the vibe-core-is-not-installed refusal, and nothing installs vibe-core); plugins/vibe/shared/vibe-core.test.mjs:1 to :162 (vibeCore() loads from vibe's own root with no vibe-core beside it, an old vibe-core never stops vibe's modules loading, the setup check still names a missing or too old vibe-core, each lib module has one home in vibe, the bundles load lib and hooks from vibe at run time); plugins/vibe/lib/vibe/scripts/provider.test.mjs:314 to :317 (the cache fixture copies vibe's lib and shared); plugins/vibe/skills/vibe/scripts/plugin-version.test.mjs:669 (the cached release carries lib, hooks and shared); plugins/vibe/hooks/guard-install.test.mjs (the guards resolve from the copy of vibe the session uses, with no vibe-core copy installed); tools/vibe-closedloop-build/src/build.test.ts:2, :92, :94 and :291 (the built vibe ships lib, hooks and process-identity and excludes
*-test-support.mjs; the provider module is read from the built vibe).The protected-write-guard stub exits 0, and the guard lives in vibe's hooks folder: tools/vibe-workers/src/claude-worker.test.ts:63 to :71 and :294 (a missing guard reads "missing or unreadable"; the symlinked guard sits in vibe/hooks); the stub exit codes are pinned in tools/plugin-manifests/src/vibe-core-bundle.test.ts (new).
The notice goes out only on UserPromptSubmit: pinned by the new matrix tests (presence on UserPromptSubmit; absence on PreToolUse, PostToolUse, SessionStart and PreCompact). plugins/vibe/hooks/pre-tool-use.test.mjs:20, :168, :188 and :191 read vibe-core's hooks.json, now the only registration, and still check one command per event and a matcher naming exactly the routed tools.
vibe-core's own tests became tools/plugin-manifests tests: plugins/vibe-core/shared/plugin-roots.test.mjs (a byte-identity test) became the layout fixture test tools/plugin-manifests/src/vibe-core-plugin-roots.test.ts, and plugins/vibe-core/shared/vibe-install.test.mjs became tools/plugin-manifests/src/vibe-core-install.test.ts. tools/vibe-bench/src/vibe-change-scope.test.ts:92 to :97 follows the move: vibe's moved hooks and lib are vibe behavior, their tests are not, and vibe-core's plugin-roots stays vibe-core runtime.
The scans now cover the moved files: plugins/vibe/tools/python/test_vibe_session_friction_contract.py:37 to :55 (three reviewed
timeoutstrings in app-binary-guard.test.mjs, which is data fed to the guard, each with a reason and a check that the line still exists); plugins/vibe/tools/python/test_vibe_signal_safety_contract.py:34 to :39 and :149 to :154 (the reviewed child-gatekill(-process.pid)in e2e-lock.mjs, with a reason and a check that it is still present); plugins/vibe/tools/python/test_vibe_generic_scan.py:163 to :166 (the variable-name lookup in vibe-core's vibe-install.mjs is allowed beside the resolver and the startup probe, because its names come from VIBE_PLUGIN_NAMES and it finds vibe, never the provider).The routine ledger now exists twice (source and the generated copy in plugins/vibe-closedloop): plugins/vibe/lib/vibe/scripts/cloud-worker.test.mjs:863 to :889 exempts both paths, expects both, and asserts they are byte-identical.
ADV-R16-3 (inline findings on an override path): plugins/vibe/skills/handoff/scripts/handoff-gate-visual-qa.test.mjs:64 and :130 to :143 (the create helper takes a command prefix; the new case needs findings named inline for the PR head, refuses another head, and refuses a value the guard cannot read).
ADV-R16-4 (no-worktree rows): plugins/vibe/skills/fleet-orchestrator/scripts/board.test.mjs:383 to :398 (a ready row with no worktree and no declared UI paths is refused with "no visual QA findings file" until findings for its head are given; the board then shows the full head).
The admission test runs under the pinned macOS /bin/bash 3.2 as well as the default bash (fleet.test.mjs, with the fleet-test-support.mjs helpers startFleet, pinMacBash and HAS_MAC_BASH32); the empty-array failure it caught under set -u is fixed in fleet-admission.sh.
plugins/vibe/lib/vibe/scripts/e2e-lock.test.mjs:38: the child cleanup checks
gate.pgid > 1where it checkedgate.pid > 1; the line already requiresgate.pgid === gate.pid, so behavior is unchanged, and the signal-safety contract can now verify the guard itself instead of carrying an exemption.plugins/vibe/lib/fleet-orchestrator/scripts/fleet-handoff.test.mjs:39 and :45: the handover notes fixture and its regex say "the operator" where they named a person, for the no-person-names contract the moved file now falls under; the handover contract is unchanged.
plugins/vibe/skills/vibe/scripts/push-ready-contract.test.mjs: main's ISS-14136, ISS-14127, ISS-14112: No-surface criteria, gpt-6.2 #433 asserted /working-tree/ in the assembled verifier text; this branch moved that evidence field guide into
pr-evidence-schema.mjs --example(orchestrator decision 17), so the test now requires the verifier to name that command and the tool's output to carry working-tree, as runtime-contract.test.ts does since round 16 (accepted as a deliberate change, orchestrator decision 32).plugins/vibe/hooks/pre-tool-use.test.mjs: the UserPromptSubmit payload in "tools with no guard" now carries the sandbox cwd, so the test never reads a live session record (fixture repair; no expectation changed).
tools/plugin-manifests/src/vibe-core-plugin-roots.test.ts: one long regex built from two shorter strings so the test runner prints a code frame for its absence proof (same pattern).
New test files (additions, not changes): plugins/vibe/hooks/activation-test-support.mjs (moved helper); plugins/vibe/shared/vibe-core-skew.test.mjs, vibe-core-skew-static.test.mjs, vibe-core-skew-test-support.mjs and vibe-state-skew.test.mjs; plugins/vibe/skills/fleet-orchestrator/scripts/fleet-capture.test.mjs (moved cases); tools/plugin-manifests/src/vibe-core-bundle.test.ts, vibe-core-install.test.ts, vibe-core-plugin-roots.test.ts and vibe-core-runtime.test.ts.
Earlier changes against main (0673f59)
Other test edits this diff makes (not assertion flips the facts list):
Changed and removed exports
MCP_ROUTE, TERMINAL, TEST_SELECTORS, VIBE_CORE_MIN, changeWriter, e2eSlotProblem, knownLocalPlanPrefixes, localPlanPaths, localPlanPrefix, prEvidenceShapeProblems, readInput, readMainSyncInput, readTestSelection, reviewReceiptProblems, safeFailure, selectionProblems, specExecutionLimitation, targetedEvidenceProblems, workflowLaneDefinitions: changed or removed by the launcher, receipt, lane-evidence, plan-path and placement work above.
localPlanPrefix,knownLocalPlanPrefixesandlocalPlanPathslive inplugins/vibe/lib/vibe/scripts/session-artifact-paths.mjs;workflowLaneDefinitionsmoved to its own module; VIBE_CORE_MIN now names the first vibe-core whose hooks hand over to this vibe's guards; the plugins/vibe-closedloop copies are generated.Contract and assertion listing
The gate lists every export and assertion the diff changes. Most entries below exist only because of the vibe-core slimming: each module moved from plugins/vibe-core/ to plugins/vibe/ with its exports and tests unchanged, and the old vibe-core path now holds a frozen stub that exports nothing (or the test file is gone from vibe-core), so the old path reads as removed.
Exports at the old vibe-core paths (each now at the same path under plugins/vibe):
Other removed exports (each also in the generated plugins/vibe-closedloop copy where it lives under plugins/vibe):
Changed exports (each also in the generated plugins/vibe-closedloop copy where it lives under plugins/vibe):
Test files gone from vibe-core (each moved, unchanged or as listed above, to the same path under plugins/vibe):
Assertion lines changed, by file (the reason is in Deliberate test changes above unless given here):
Overlap with open pull requests
How it was checked
ascasts in plugin-manifests TypeScript), verify 0 blocking, Storybook decomposer done, adversarial 2 low (test-support shipped in the build, fixed; a stale stub text, fixed). The adversarial receipt was marked WORKER_TURN_FAILED because the live tree was edited during its run, so the final rounds ran with no edits.Known main failures
Disclosures
writer-state.mjs migrateharness switch.claude -pRemoteTrigger calls timed out under load (spawnSync ETIMEDOUT), and one completed run was refused because a lane reported no exit code. No lane ran locally this push; see How it was checked.Vibe gate override: ISS-14476: handoff gate: diff rules read 139 pure moves as new code because each old vibe-core path now holds a stub (ISS-14476 item 78); the cross-plugin enabled-check copy in vibe/shared/vibe-install.mjs and vibe-core/shared/vibe-install.mjs is intended (neither plugin may import the other); the Codex fingerprint comparator sorts unique directory entry names, matching Codex.
Orchestrator decisions (operator may override)
These were decided by the orchestrator or proceeded on a stated default; each carries its source.
linguist-generatedattribute, a minified path, or a generator comment in the first five lines that the base already had), and duplicate-helper calls it withheader: false(plugins/vibe/skills/handoff/scripts/diff-rules.mjs:215).Follow-ups on this PR (next pushes)
Stack
The base is main.