Skip to content

ISS-14552: add managed Codex reviewer launcher - #440

Merged
shafty023 merged 3 commits into
mainfrom
vibe/iss-14552-codex-reviewer
Nov 20, 2026
Merged

shafty023 merged 3 commits into
mainfrom
vibe/iss-14552-codex-reviewer

Conversation

@shafty023

@shafty023 shafty023 commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Delivers ISS-14552 with one supported entry point for a Claude-hosted vibe or fleet session to launch and accept a managed Codex App Server reviewer.
  • Reuses the existing App Server client and native receipt path, requires an explicit model with read-only/never-approve policy, and keeps raw codex exec output ineligible.
  • Accepts quoted or bare agent-role frontmatter, documents the visual-QA critic findings path, and reads multi-document thread/read output without weakening completion proof.
  • Releases both changed plugins together as vibe 1.1.104. The version checks now cover 1.1.104 in the skill contracts, READMEs, and benchmark driver. The version-skew test installs the shipped plugin tree so guards can load their runtime dependencies.

Delivery placement: unit ISS-14552

Validation

The original implementation passed the following focused checks.

  • node --test plugins/vibe/lib/handoff/scripts/codex-reviewer.test.mjs plugins/vibe/lib/handoff/scripts/codex-review-runtime.test.mjs plugins/vibe/lib/fleet-orchestrator/scripts/helpers.test.mjs: 55 passed.
  • npm run typecheck in tools/vibe-workers.
  • python3 plugins/vibe/tools/python/vibe_generic_scan.py check.
  • npm test and npm run typecheck in tools/plugin-manifests: 62 tests passed.
  • Plugin version gate: vibe and vibe-closedloop both advance from 1.1.103 to 1.1.104.
  • Standalone installed-plugin-cache smokes for claude-worker, writer-state, and codex-reviewer in both generated builds, outside the repository with no node_modules.

The following checks cover the correction tree at b166dc78b0f530839669e961fc6216591d34783f.

  • uv run pytest plugins/ passed 2,873 tests with 3 skips. The Node skill-script suite discovered by CI passed 2,696 tests with 8 skips.
  • npm test in tools/vibe-bench passed all 252 tests. uv run pytest plugins/vibe/evals/codex/test_run.py passed all 79 tests.
  • T0 typechecking, Ruff, Pyright, JavaScript syntax checks, and the Git diff check passed. The hosted plugin validation step passed on the previous head. Its command, npm run validate:plugins, invokes the Claude CLI and was excluded from the local rerun.
  • Two scoped gpt-6.2-astra reviews checked the committed tree digest. Guardrails and review-soul each reported zero findings.
  • Relative to the ISS-14116: Slim vibe-core and prevent the reported vibe bugs #438 release baseline, the diff adds 209 words and removes 261 across plugin Markdown, a net reduction of 52. This includes plugin READMEs and evaluation prompts and graders, and excludes the generated plugins/vibe-closedloop mirror.

Generated bundle note

claude-worker.mjs and writer-state.mjs shrink because the YAML parser is shipped once as lib/vibe/scripts/agent-frontmatter.mjs instead of being embedded in both bundles. Isolated installed-plugin smokes verify that the generated bundles remain standalone.

Overlap

Open PRs #183, #193, #197, #201, #204, and #381 overlap only in CHANGELOG.md. PRs #361 and #362 also touch the generic plugin manifests and README. PR #439 shares both distributions’ release manifests and READMEs, both Python release-contract tests, and the benchmark reply-checker test.

ISS-14552: launch and accept source-bound Codex App Server reviews, preserve helper role compatibility, and parse multi-document completion evidence.
- Bump generic and ClosedLoop plugin manifests together
- Move the ISS-14552 notes into the new release entry
- Record the final instruction-word reduction

Testing: 62 plugin-manifest tests, manifest typecheck, generated build, and instruction-word check

Risks: Release metadata only; runtime implementation is unchanged
@shafty023
shafty023 merged commit cf36406 into main Nov 20, 2026
13 checks passed
@shafty023
shafty023 deleted the vibe/iss-14552-codex-reviewer branch November 20, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant