Repository navigation
ISS-14552: add managed Codex reviewer launcher - #440
Merged
Merged
Conversation
ISS-14552: launch and accept source-bound Codex App Server reviews, preserve helper role compatibility, and parse multi-document completion evidence.
- Bump generic and ClosedLoop plugin manifests together - Move the ISS-14552 notes into the new release entry - Record the final instruction-word reduction Testing: 62 plugin-manifest tests, manifest typecheck, generated build, and instruction-word check Risks: Release metadata only; runtime implementation is unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex execoutput ineligible.thread/readoutput without weakening completion proof.Delivery placement: unit ISS-14552
Validation
The original implementation passed the following focused checks.
node --test plugins/vibe/lib/handoff/scripts/codex-reviewer.test.mjs plugins/vibe/lib/handoff/scripts/codex-review-runtime.test.mjs plugins/vibe/lib/fleet-orchestrator/scripts/helpers.test.mjs: 55 passed.npm run typecheckintools/vibe-workers.python3 plugins/vibe/tools/python/vibe_generic_scan.py check.npm testandnpm run typecheckintools/plugin-manifests: 62 tests passed.vibeandvibe-closedloopboth advance from 1.1.103 to 1.1.104.claude-worker,writer-state, andcodex-reviewerin both generated builds, outside the repository with nonode_modules.The following checks cover the correction tree at
b166dc78b0f530839669e961fc6216591d34783f.uv run pytest plugins/passed 2,873 tests with 3 skips. The Node skill-script suite discovered by CI passed 2,696 tests with 8 skips.npm testintools/vibe-benchpassed all 252 tests.uv run pytest plugins/vibe/evals/codex/test_run.pypassed all 79 tests.npm run validate:plugins, invokes the Claude CLI and was excluded from the local rerun.gpt-6.2-astrareviews checked the committed tree digest. Guardrails and review-soul each reported zero findings.plugins/vibe-closedloopmirror.Generated bundle note
claude-worker.mjsandwriter-state.mjsshrink because the YAML parser is shipped once aslib/vibe/scripts/agent-frontmatter.mjsinstead of being embedded in both bundles. Isolated installed-plugin smokes verify that the generated bundles remain standalone.Overlap
Open PRs #183, #193, #197, #201, #204, and #381 overlap only in
CHANGELOG.md. PRs #361 and #362 also touch the generic plugin manifests and README. PR #439 shares both distributions’ release manifests and READMEs, both Python release-contract tests, and the benchmark reply-checker test.