Repository navigation
Release 11.0 - #1097
Merged
k8s-ci-robot merged 44 commits intoMar 12, 2020
Merged
Release 11.0#1097
Conversation
Identity is not the same thing as equality in Python so use ==/!= to compare str, bytes, and int literals. On n Python >= 3.8, these instances will raise SyntaxWarnings so it is best to fix them now. https://docs.python.org/3.8/whatsnew/3.8.html#porting-to-python-3-8
Update README and CHANGELOG in master branch
Remove .swagger-codegen
Fix deprecation warning in e2e tests
Add Contribution 101
Use ==/!= to compare str, bytes, and int literals
Enables the use of dynamic client
…object_doc Fix Custom Objects API example
This removes the __del__ function from the generated Python client, and replaces it with a cleanup function. When a ThreadPool is created, the cleanup function is registered with the atexit module. This PR also allows the client to be used as a context manager, which will automatically clean up after itself rather than having to wait til process exit. This fixes issue kubernetes-client#1037, where the API client could hang indefinitely at garbage collection.
Cleanup ThreadPool with atexit rather than __del__
…ssues Document hot issues in release process
Grammar fixes to contributing doc
Add example code for enabling debugging
Update CHANGELOG to include 10.0.1
add basic watch configmap e2e test
Add kubernetes.dynamic to setup.py pkg list
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XXL
Member
Author
|
/assign |
palnabarun
marked this pull request as ready for review
March 11, 2020 12:27
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
The hotfixes were done using the changes in #1103 . The release branch does not necessarily need those changes. |
2 tasks done
roycaihw
reviewed
Mar 12, 2020
roycaihw
left a comment
roycaihw
left a comment
Member
There was a problem hiding this comment.
The API change looks clean to me.
/lgtm
/approve
$ git diff 3ef3dd471f230c6d9f1c3fb2127823f410ec11bc~ 3ef3dd471f230c6d9f1c3fb2127823f410ec11bc --stat | grep -v "| 2 +-"
kubernetes/README.md | 4 +-
kubernetes/client/__init__.py | 4 +-
kubernetes/client/api/custom_objects_api.py | 58 ++++++++++------------
kubernetes/client/api_client.py | 16 ++----
kubernetes/client/apis/__init__.py | 13 -----
kubernetes/client/configuration.py | 6 +--
kubernetes/docs/CustomObjectsApi.md | 16 +++---
kubernetes/test/test_api_client.py | 25 ----------
scripts/swagger.json | 4 +-
setup.py | 4 +-
1350 files changed, 1386 insertions(+), 1444 deletions(-)
| - Fix persist_config flag and function calls [kubernetes-client/python-base#169](https://github.com/kubernetes-client/python-base/pull/169) | ||
| - Fix memory inneficiencies in the WebSocket client [kubernetes-client/python-base#178](https://github.com/kubernetes-client/python-base/pull/178) | ||
| - Fix functionality to watch logs when log line is not a JSON-serialized object [kubernetes-client/python-base#171](https://github.com/kubernetes-client/python-base/pull/171) | ||
| - Detect binary payloads and send the correct opcode [kubernetes-client/python-base#152](https://github.com/kubernetes-client/python-base/pull/152) |
Member
There was a problem hiding this comment.
Thanks for going through the changes in python-base and collect the release notes.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull from master
Update constants
Update client
Apply hotfixes
Update CHANGELOG
Cherry-pick CHANGELOG and README commit (Cherry-pick CHANGELOG and README from release 11.0 branch #1104)