Repository navigation
fix(codex): clamp native efforts to selected model ladder - #7731
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Clamp unsupported effort values src/codex/catalog/effort.ts:56-69, 80-84, tests/codex-integration/codex-catalog-ladders.test.ts:218-221 |
The clamp recognizes none and minimal, converts ultra to max, and selects the highest supported effort at or below the request. If no supported effort is at or below the request, it selects the lowest supported effort. The test checks that none maps to low for gpt-6.1-sol. |
Cover final-route normalization tests/responses/responses-compaction-override.test.ts:296-347, docs-site/src/content/docs/reference/configuration/agents.md:387-389, structure/catalog.md:484, structure/transports/responses-failover.md:287-290 |
Tests cover direct and compaction-routed requests, plus combo failover to gpt-6.1-sol. The documentation describes applying the selected native model’s effort ladder before sending the request. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related issues
- Issue 7590 reports invalid native reasoning effort values for
gpt-6.1-sol, includingultra. This PR changes the same native effort normalization path, while preserving the existingultraconversion.
Possibly related PRs
- lidge-jun/opencodex#7600: Both changes modify native reasoning-effort normalization in
src/codex/catalog/effort.ts. This PR extends the clamp behavior while preserving theultratomaxconversion. - lidge-jun/opencodex#7605: Both describe the native-versus-routed wire contract. This PR adds effort clamping against the selected native model’s ladder.
Merge Risk: 
Minimal · up to 283f2
-
No actionable issue is established for the effort-normalization change. Complete the remaining CI checks before merging.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request has been marked Ready for Review. |
|
Maintainer dev integration record (release 2.93 dev-merge loop), per the MAINTAINERS.md maintainer-integration exception for dev. This is maintainer integration, not an approving review.
|
…with routed Flex tiers
Summary
gpt-6.1-sol, unsupportednoneandminimalbecomelow.ultrawire conversion.Verification
bun test tests/codex-integration/codex-catalog-ladders.test.ts --test-name-pattern 'native model rejects none'failed: expectedlow, receivednull.bun test tests/codex-integration/codex-catalog-ladders.test.ts tests/responses/responses-compaction-override.test.ts: 88 passed, 0 failed. The outbound-body checks cover direct, compaction-switch, and combo-failover sends.bunx tsc --noEmit --pretty false,bun scripts/privacy-scan.ts, andbun scripts/structure-ssot.tspassed. An independent read-only review found no concrete defect.bun scripts/test.ts --changed=devselected 1,253 of 2,615 test files and reached its built-in 900-second limit (exit 124). The full selected suite is not claimed as passing; CI must complete the remaining coverage.opencodex 2.93.0. The shared proxy was not replaced while other requests were active.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.