Repository navigation
Calendar: event times, on the viewer's local day (#1802) - #1898
Closed
michielbdejong wants to merge 7 commits into
Closed
michielbdejong wants to merge 7 commits into
michielbdejong wants to merge 7 commits into
Conversation
The row dialog opened from a calendar view shows a Repeat field instead of the raw recurrence JSON: none, daily, weekly on chosen days, monthly by date or nth weekday, or yearly, ending never, on a date or after N times, with a summary in words. It writes the payload the view already expands; a payload it cannot show reads as Custom, kept as is, with its JSON one click away. A table without a recurrence property gets one (shortname atomic-calendar-recurrence, as in the Event ontology) when a row first repeats. A row's own series (calendarId "atomic") follows the row's date columns, so moving the row moves the series; imported payloads stay the provider's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A Playwright test makes an event repeat weekly from the row dialog and checks it appears on the following weeks. The Custom hint moves into its own component: inside its guard the extractor dropped it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Setting undefined through Resource.set failed validation, so turning a repeat off raised an error. Remove the value instead. The e2e test now turns the repeat off again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Unchecking All day in a calendar row's dialog reveals a start and end
time. They are stored in atomic-calendar-start / atomic-calendar-end,
the exact-instant properties the atomic-plugins Event ontology already
defines (RFC 3339 strings with their offset), added to the class when a
row first gets a time. Day, End day and All day keep their meaning: Day
still says which date, the exclusive End day is untouched, and an
all-day row stays date-only.
Timed events, rows and imported timed recurrences alike, are placed on
the viewer's local day and show local times on their chips ("09:30
Dentist"); a Tuesday 19:30 New York meeting is Wednesday 01:30 in
Amsterdam.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Michiel's decision: a start time without an end time stores no end; the event shows as a point in time. This PR keeps that as implemented. |
The table view's row dialog now shows the calendar's Repeat field for the recurrence property instead of its raw JSON, with the JSON behind Show JSON. It uses the calendar's detection (`atomic-calendar-recurrence` or the imported `lt-google-calendar-property-` one) and repeats from the calendar's Day, else the class's first date column. A table creates no property: a class without a recurrence or date column, or a row without a day, keeps the JSON editor. The recurrence cell shows the Repeat summary, read-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in the table view's Repeat field (#1801). Resolves the CalendarView import conflict (calendarRangeColumns now finds All day / End day), moves useTableCalendarRow to useCalendarRowProps, and keeps the table's row dialog to the Repeat field only (`repeatOnly`): Start and End are table columns of their own, and the table creates no property. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Michiel's decision: the table view's row dialog does not get the time fields (All day, Start, End), because the table has its own columns. The |
Member
|
Trekmeester review (not batched tonight; this needs maintainer sign-off, since it's a stored-format change):
|
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1802
Stacked on #1896 (
claude/calendar-repeat): both change the calendar's row dialog (CalendarRowFields),CalendarViewandcalendarRows. Merge #1896 first; until then the diff here includes it. The #1802 changes are the last two commits.Decisions (Michiel, 25 Sep): an event belongs to the viewer's local day, like Google Calendar. Per #1803, existing properties keep their meaning; the exclusive End day is unchanged.
What changes
Where times are stored
In
atomic-calendar-start/atomic-calendar-end, the properties the atomic-plugins Event ontology (ontology/classes/event-v1) already defines for exactly this: the exact start / exclusive end instant, as an RFC 3339 string with its UTC offset (a string rather than a timestamp, so the offset is kept). No existing property is reinterpreted:New:
browser/lib/src/calendar-time.ts,Calendar/EventTimeFields.tsx;useCalendarRecurrencePropbecameuseCalendarRowProps(recurrence + start + end).Tests
Calendar/calendarOccurrences.test.ts: Tuesday 19:30 New York → Wednesday 01:30 for an Amsterdam viewer; Tuesday for a New York viewer; all-day events keep their dates and exclusive end in UTC+14 and UTC−11.Calendar/calendarRows.test.ts: reading a timed row; an all-day row with a stray Start stays date-only; Day moves the time; a start without an end; writing/reading local wall times with their offset (DST).Calendar/EventTimeFields.test.tsx(component): unchecking All day reveals the time inputs and stores nothing until a start is given; a timed row shows its times, and checking All day clears them.e2e/tests/calendar.spec.tspass.Screenshots
Before / after, desktop and 375 px (Europe/Amsterdam, en-GB), shared with the developer in chat:
1802-before-dialog-{desktop,375}.png,1802-before-calendar-{desktop,375}.png,1802-after-1802-dialog-{desktop,375}.png,1802-after-1802-calendar-{desktop,375}.png.Questions for Michiel
🤖 Generated with Claude Code