Repository navigation
Conversation
nix develop provides the pinned Rust, Node, pnpm, wasm-pack, wasm-bindgen and wasm-opt, which cannot be downloaded and run on NixOS. nix build builds the server in the sandbox with a placeholder data browser (overridable); the server-side plugin runtime is left out as nixpkgs has no wasm32-wasip2 std.
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
Author
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep · project thread
Before: The repo had no Nix files. On NixOS the build tools that
pnpmandwasm-packdownload (wasm-bindgen, wasm-opt) can't run, and there was no way to build the server with Nix.After:
nix developgives a shell with Rust 1.98.1 (with the wasm32 std), Node 22, pnpm 10, wasm-pack, wasm-bindgen 0.2.122 and wasm-opt.nix build/nix runbuilds the server in the Nix sandbox.How:
flake.nixuses nixpkgs only (nixos-unstable ships exactly the Rust version inrust-toolchain.toml; the dev shell warns if they drift).flake.lockpins the channel tarball. The package buildsatomic-serverwithATOMICSERVER_SKIP_JS_BUILD, sobuild.rsnever callspnpm.Limits, also written in CONTRIBUTING.md:
devoniangit dependency). The package embeds a placeholder page; pass a real bundle with.override { dataBrowser = ./path/to/dist; }. A pure frontend derivation needs apnpm.fetchDepshash, which has to be generated on a machine with GitHub access.wasm32-wasip2std.Tested on x86_64 Linux (not NixOS itself):
nix build .#atomic-serversucceeds (23 min cold), the binary starts and serves on/with HTTP 200, and innix developthe tool versions are right andcargo check -p atomic-wasm --target wasm32-unknown-unknownpasses. The fullpnpm installandbuild:wasmwere not run, becausedevonianis blocked here.Generated by Claude Code