Repository navigation
Conversation
Setup switched the server URL and waited 20 seconds for a connection. setServerUrl opens no socket after a manual Disconnect (persisted in localStorage), and reuses a socket left from an earlier attempt at the same node, so setup could time out with nothing in the console. It now calls store.reconnect, which clears that flag, opens a new socket and reports the actual connection or auth error.
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
Author
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: connecting a drive to Cloud Server could fail after 20 seconds with "Timed out connecting to the Cloud Server node. Retry setup.", and nothing in the console said why. This happened to a drive recovered from the cloud vault on app.atomic.place.
After: setup always opens a new socket to the assigned node. If the connection or sign-in fails, the error names the actual reason.
How:
enableCloudSyncForDriveusedsetServerUrland thenwaitForServerConnected(20_000).setServerUrlopens no socket after a manual Disconnect, because that flag is kept in localStorage across reloads. It also reuses a socket left from an earlier attempt at the same node. Setup now callsstore.reconnect(20_000). That clears the flag, replaces any socket and rejects with the socket's own error. ThecloudSync.setuptests are updated for this.