Skip to content

Move the browser workspace to pnpm 11 (split out of #1281) - #1931

Closed
michielbdejong wants to merge 2 commits into
developfrom
claude/pnpm-11
Closed

michielbdejong wants to merge 2 commits into
developfrom
claude/pnpm-11

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Polle's (@Polleps) pnpm 11 move from #1281, split out so the Forms PR (#1923) stays about forms. The first commit is his; the second is mine.

Polle's commit

  • browser/package.json: packageManager: pnpm@11.10.0.
  • pnpm-workspace.yaml: allows the sharp and unix-dgram build scripts.
  • .dagger/src/index.ts:
  • create-template/templates/sveltekit-site: the @swc pins are also in package.json pnpm.overrides, for older pnpm.

My commit: the GitHub workflows added since (main, main-ci, release, tauri-release) still pinned pnpm 10. They now install 11.10.0 too.

Checked locally with pnpm 11.10.0

  • pnpm install leaves pnpm-lock.yaml unchanged.
  • pnpm install --frozen-lockfile passes.
  • pnpm run -r build succeeds.

This PR needs a green Main pipeline before batching, because it changes how every CI job installs. I've started one. .dagger/package.json (the Dagger module itself) stays on pnpm 10; it's a separate install.

🤖 Generated with Claude Code

Polleps and others added 2 commits September 30, 2026 12:14
- browser/package.json: packageManager pnpm@11.10.0.
- pnpm-workspace.yaml: allow the sharp and unix-dgram build scripts.
- Dagger installs exactly that version with npm instead of letting
  corepack's pnpm 10 self-switch (which fails on pnpm 11, pnpm/pnpm#12528),
  sets shamefully-hoist through PNPM_CONFIG_SHAMEFULLY_HOIST so pnpm 11's
  implicit pre-run install agrees with it, and points PATH at pnpm 11's
  bin dir in the Playwright image.
- sveltekit-site template: the @swc pins also in package.json
  pnpm.overrides, for pnpm versions that don't read them from the
  workspace file.

Split out of #1281 (Forms); see #1923.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflows added after #1281's pnpm 11 change still pinned pnpm 10
(main, main-ci, release, tauri-release). Keep them equal to
browser/package.json's packageManager.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

joepio commented Oct 5, 2026

Copy link
Copy Markdown
Member

Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included.


Generated by Claude Code

@joepio joepio closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants