Repository navigation
Move the browser workspace to pnpm 11 (split out of #1281) - #1931
Closed
michielbdejong wants to merge 2 commits into
Closed
michielbdejong wants to merge 2 commits into
michielbdejong wants to merge 2 commits into
Conversation
- browser/package.json: packageManager pnpm@11.10.0. - pnpm-workspace.yaml: allow the sharp and unix-dgram build scripts. - Dagger installs exactly that version with npm instead of letting corepack's pnpm 10 self-switch (which fails on pnpm 11, pnpm/pnpm#12528), sets shamefully-hoist through PNPM_CONFIG_SHAMEFULLY_HOIST so pnpm 11's implicit pre-run install agrees with it, and points PATH at pnpm 11's bin dir in the Playwright image. - sveltekit-site template: the @swc pins also in package.json pnpm.overrides, for pnpm versions that don't read them from the workspace file. Split out of #1281 (Forms); see #1923. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflows added after #1281's pnpm 11 change still pinned pnpm 10 (main, main-ci, release, tauri-release). Keep them equal to browser/package.json's packageManager. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 3 tasks
This was referenced Sep 30, 2026
joepio
added a commit
that referenced
this pull request
Oct 5, 2026
… chat, search, CI) (#2060) Combines #1530, #1638, #1663, #1835, #1869, #1896, #1898, #1911, #1912, #1913, #1914, #1918, #1919, #1929, #1931, #1949, #1958, #1959, #1961, #1963, #1968, #1975, #1981, #1985, #1988, #2038, #2041, #2047 and #2050, tested in one full Mancave run on the exact head (run 4999, green).
Member
|
Landed on develop in the combined batch #2060 (95707c0), tested together in one full run. Closing as included. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polle's (@Polleps) pnpm 11 move from #1281, split out so the Forms PR (#1923) stays about forms. The first commit is his; the second is mine.
Polle's commit
browser/package.json:packageManager: pnpm@11.10.0.pnpm-workspace.yaml: allows thesharpandunix-dgrambuild scripts..dagger/src/index.ts:PNPM_CONFIG_SHAMEFULLY_HOIST, so pnpm 11's implicit pre-run install agrees with it;bindir on PATH in the Playwright image.create-template/templates/sveltekit-site: the@swcpins are also inpackage.jsonpnpm.overrides, for older pnpm.My commit: the GitHub workflows added since (main, main-ci, release, tauri-release) still pinned pnpm 10. They now install 11.10.0 too.
Checked locally with pnpm 11.10.0
pnpm installleavespnpm-lock.yamlunchanged.pnpm install --frozen-lockfilepasses.pnpm run -r buildsucceeds.This PR needs a green Main pipeline before batching, because it changes how every CI job installs. I've started one.
.dagger/package.json(the Dagger module itself) stays on pnpm 10; it's a separate install.🤖 Generated with Claude Code